From ffb0e291793bd1d603a7f48880799b47ea688e99 Mon Sep 17 00:00:00 2001
From: Emmanuel T Odeke <emmanuel@orijtech.com>
Date: Sun, 27 Nov 2022 03:18:50 -0800
Subject: [PATCH] fix: tools/cosmovisor: return on failing to remove existing
 symlink (#14032)

Fixes #14031
Fixes https://github.com/cosmos/cosmos-sdk/security/code-scanning/6794
---
 tools/cosmovisor/args.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/cosmovisor/args.go b/tools/cosmovisor/args.go
index 6913529c16..dd39b1f031 100644
--- a/tools/cosmovisor/args.go
+++ b/tools/cosmovisor/args.go
@@ -286,7 +286,9 @@ func (cfg *Config) SetCurrentUpgrade(u upgradetypes.Plan) (rerr error) {
 
 	// remove link if it exists
 	if _, err := os.Stat(link); err == nil {
-		os.Remove(link)
+		if err := os.Remove(link); err != nil {
+			return fmt.Errorf("failed to remove existing link: %w", err)
+		}
 	}
 
 	// point to the new directory