From fc6df7e6511e1bb92b56cd9adc98c55c4e97d2ef Mon Sep 17 00:00:00 2001 From: withtimezone Date: Mon, 29 Sep 2025 23:32:54 +0800 Subject: [PATCH] refactor: use b.Loop() to simplify the code and improve performance (#25368) Signed-off-by: withtimezone --- codec/bench_test.go | 12 ++++-------- codec/proto_codec_test.go | 3 +-- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/codec/bench_test.go b/codec/bench_test.go index d5b5fa132d..1d8586d230 100644 --- a/codec/bench_test.go +++ b/codec/bench_test.go @@ -33,8 +33,7 @@ func BenchmarkLegacyGetSigners(b *testing.B) { Amount: nil, }} - b.ResetTimer() - for i := 0; i < b.N; i++ { + for b.Loop() { _ = msg.GetSigners() } } @@ -50,8 +49,7 @@ func BenchmarkProtoreflectGetSigners(b *testing.B) { Amount: nil, } - b.ResetTimer() - for i := 0; i < b.N; i++ { + for b.Loop() { _, err := signingCtx.GetSigners(msg) if err != nil { panic(err) @@ -72,8 +70,7 @@ func BenchmarkProtoreflectGetSignersWithUnmarshal(b *testing.B) { a, err := codectypes.NewAnyWithValue(msg) require.NoError(b, err) - b.ResetTimer() - for i := 0; i < b.N; i++ { + for b.Loop() { _, _, err := cdc.GetMsgAnySigners(a) if err != nil { panic(err) @@ -97,8 +94,7 @@ func BenchmarkProtoreflectGetSignersDynamicpb(b *testing.B) { err = protov2.Unmarshal(bz, dynamicmsg) require.NoError(b, err) - b.ResetTimer() - for i := 0; i < b.N; i++ { + for b.Loop() { _, err := signingCtx.GetSigners(dynamicmsg) if err != nil { panic(err) diff --git a/codec/proto_codec_test.go b/codec/proto_codec_test.go index b93b25a957..4fb2120a1f 100644 --- a/codec/proto_codec_test.go +++ b/codec/proto_codec_test.go @@ -165,10 +165,9 @@ func BenchmarkProtoCodecMarshalLengthPrefixed(b *testing.B) { }), } - b.ResetTimer() b.ReportAllocs() - for i := 0; i < b.N; i++ { + for b.Loop() { blob, err := pCdc.MarshalLengthPrefixed(msg) if err != nil { b.Fatal(err)