diff --git a/tests/cli/basictx.sh b/tests/cli/basictx.sh index e9a6b0e5fb..550bd2c430 100755 --- a/tests/cli/basictx.sh +++ b/tests/cli/basictx.sh @@ -43,10 +43,8 @@ test00GetAccount() { RECV=$(getAddr $POOR) assertFalse "requires arg" "${CLIENT_EXE} query account" - ACCT=$(${CLIENT_EXE} query account $SENDER) - assertTrue "must have proper genesis account" $? - assertEquals "no tx" "0" $(echo $ACCT | jq .data.sequence) - assertEquals "has money" "9007199254740992" $(echo $ACCT | jq .data.coins[0].amount) + + checkAccount $SENDER "0" "9007199254740992" ACCT2=$(${CLIENT_EXE} query account $RECV) assertFalse "has no genesis account" $? @@ -60,31 +58,16 @@ test01SendTx() { assertFalse "bad password" "echo foo | ${CLIENT_EXE} tx send --amount=992mycoin --sequence=1 --to=$RECV --name=$RICH 2>/dev/null" # we have to remove the password request from stdout, to just get the json RES=$(echo qwertyuiop | ${CLIENT_EXE} tx send --amount=992mycoin --sequence=1 --to=$RECV --name=$RICH 2>/dev/null | tail -n +2) - assertTrue "sent tx" $? + txSucceeded "$RES" + HASH=$(echo $RES | jq .hash | tr -d \") TX_HEIGHT=$(echo $RES | jq .height) - assertEquals "good check" "0" $(echo $RES | jq .check_tx.code) - assertEquals "good deliver" "0" $(echo $RES | jq .deliver_tx.code) - # make sure sender goes down - ACCT=$(${CLIENT_EXE} query account $SENDER) - assertTrue "must have genesis account" $? - assertEquals "one tx" "1" $(echo $ACCT | jq .data.sequence) - assertEquals "has money" "9007199254740000" $(echo $ACCT | jq .data.coins[0].amount) - - # make sure recipient goes up - ACCT2=$(${CLIENT_EXE} query account $RECV) - assertTrue "must have new account" $? - assertEquals "no tx" "0" $(echo $ACCT2 | jq .data.sequence) - assertEquals "has money" "992" $(echo $ACCT2 | jq .data.coins[0].amount) + checkAccount $SENDER "1" "9007199254740000" + checkAccount $RECV "0" "992" # make sure tx is indexed - TX=$(${CLIENT_EXE} query tx $HASH) - assertTrue "found tx" $? - assertEquals "proper height" $TX_HEIGHT $(echo $TX | jq .height) - assertEquals "type=send" '"send"' $(echo $TX | jq .data.type) - assertEquals "proper sender" "\"$SENDER\"" $(echo $TX | jq .data.data.inputs[0].address) - assertEquals "proper out amount" "992" $(echo $TX | jq .data.data.outputs[0].coins[0].amount) + checkSendTx $HASH $TX_HEIGHT $SENDER "992" } diff --git a/tests/cli/common.sh b/tests/cli/common.sh index 07fe1a54b1..4a60128444 100644 --- a/tests/cli/common.sh +++ b/tests/cli/common.sh @@ -70,3 +70,34 @@ getAddr() { # print the addr echo $RAW | cut -d' ' -f2 } + +# checkAccount $ADDR $SEQUENCE $BALANCE +# assumes just one coin, checks the balance of first coin in any case +checkAccount() { + # make sure sender goes down + ACCT=$(${CLIENT_EXE} query account $1) + assertTrue "must have genesis account" $? + assertEquals "proper sequence" "$2" $(echo $ACCT | jq .data.sequence) + assertEquals "proper money" "$3" $(echo $ACCT | jq .data.coins[0].amount) +} + +# txSucceeded $RES +# must be called right after the `tx` command, makes sure it got a success response +txSucceeded() { + assertTrue "sent tx" $? + assertEquals "good check" "0" $(echo $1 | jq .check_tx.code) + assertEquals "good deliver" "0" $(echo $1 | jq .deliver_tx.code) +} + +# checkSendTx $HASH $HEIGHT $SENDER $AMOUNT +# this looks up the tx by hash, and makes sure the height and type match +# and that the first input was from this sender for this amount +checkSendTx() { + TX=$(${CLIENT_EXE} query tx $1) + assertTrue "found tx" $? + assertEquals "proper height" $2 $(echo $TX | jq .height) + assertEquals "type=send" '"send"' $(echo $TX | jq .data.type) + assertEquals "proper sender" "\"$3\"" $(echo $TX | jq .data.data.inputs[0].address) + assertEquals "proper out amount" "$4" $(echo $TX | jq .data.data.outputs[0].coins[0].amount) +} + diff --git a/tests/cli/counter.sh b/tests/cli/counter.sh index 3b00adb881..461fb410e5 100755 --- a/tests/cli/counter.sh +++ b/tests/cli/counter.sh @@ -37,22 +37,19 @@ oneTimeTearDown() { sleep 1 } -# blatently copied to make sure it works with counter as well + test00GetAccount() { SENDER=$(getAddr $RICH) RECV=$(getAddr $POOR) assertFalse "requires arg" "${CLIENT_EXE} query account" - ACCT=$(${CLIENT_EXE} query account $SENDER) - assertTrue "must have proper genesis account" $? - assertEquals "no tx" "0" $(echo $ACCT | jq .data.sequence) - assertEquals "has money" "9007199254740992" $(echo $ACCT | jq .data.coins[0].amount) + + checkAccount $SENDER "0" "9007199254740992" ACCT2=$(${CLIENT_EXE} query account $RECV) assertFalse "has no genesis account" $? } -# blatently copied to make sure it works with counter as well test01SendTx() { SENDER=$(getAddr $RICH) RECV=$(getAddr $POOR) @@ -61,31 +58,15 @@ test01SendTx() { assertFalse "bad password" "echo foo | ${CLIENT_EXE} tx send --amount=992mycoin --sequence=1 --to=$RECV --name=$RICH 2>/dev/null" # we have to remove the password request from stdout, to just get the json RES=$(echo qwertyuiop | ${CLIENT_EXE} tx send --amount=992mycoin --sequence=1 --to=$RECV --name=$RICH 2>/dev/null | tail -n +2) - assertTrue "sent tx" $? + txSucceeded "$RES" HASH=$(echo $RES | jq .hash | tr -d \") TX_HEIGHT=$(echo $RES | jq .height) - assertEquals "good check" "0" $(echo $RES | jq .check_tx.code) - assertEquals "good deliver" "0" $(echo $RES | jq .deliver_tx.code) - # make sure sender goes down - ACCT=$(${CLIENT_EXE} query account $SENDER) - assertTrue "must have genesis account" $? - assertEquals "one tx" "1" $(echo $ACCT | jq .data.sequence) - assertEquals "has money" "9007199254740000" $(echo $ACCT | jq .data.coins[0].amount) - - # make sure recipient goes up - ACCT2=$(${CLIENT_EXE} query account $RECV) - assertTrue "must have new account" $? - assertEquals "no tx" "0" $(echo $ACCT2 | jq .data.sequence) - assertEquals "has money" "992" $(echo $ACCT2 | jq .data.coins[0].amount) + checkAccount $SENDER "1" "9007199254740000" + checkAccount $RECV "0" "992" # make sure tx is indexed - TX=$(${CLIENT_EXE} query tx $HASH) - assertTrue "found tx" $? - assertEquals "proper height" $TX_HEIGHT $(echo $TX | jq .height) - assertEquals "type=send" '"send"' $(echo $TX | jq .data.type) - assertEquals "proper sender" "\"$SENDER\"" $(echo $TX | jq .data.data.inputs[0].address) - assertEquals "proper out amount" "992" $(echo $TX | jq .data.data.outputs[0].coins[0].amount) + checkSendTx $HASH $TX_HEIGHT $SENDER "992" } test02GetCounter() { @@ -93,23 +74,27 @@ test02GetCounter() { assertFalse "no default count" $? } +# checkAccount $COUNT $BALANCE +# assumes just one coin, checks the balance of first coin in any case +checkCounter() { + # make sure sender goes down + ACCT=$(${CLIENT_EXE} query counter) + assertTrue "count is set" $? + assertEquals "proper count" "$1" $(echo $ACCT | jq .data.Counter) + assertEquals "proper money" "$2" $(echo $ACCT | jq .data.TotalFees[0].amount) +} + test02AddCount() { SENDER=$(getAddr $RICH) assertFalse "bad password" "echo hi | ${CLIENT_EXE} tx counter --amount=1000mycoin --sequence=2 --name=${RICH} 2>/dev/null" # we have to remove the password request from stdout, to just get the json RES=$(echo qwertyuiop | ${CLIENT_EXE} tx counter --amount=10mycoin --sequence=2 --name=${RICH} --valid --countfee=5mycoin 2>/dev/null | tail -n +2) - assertTrue "sent tx" $? + txSucceeded "$RES" HASH=$(echo $RES | jq .hash | tr -d \") TX_HEIGHT=$(echo $RES | jq .height) - assertEquals "good check" "0" $(echo $RES | jq .check_tx.code) - assertEquals "good deliver" "0" $(echo $RES | jq .deliver_tx.code) - # check new state - COUNT=$(${CLIENT_EXE} query counter) - assertTrue "count now set" $? - assertEquals "one tx" "1" $(echo $COUNT | jq .data.Counter) - assertEquals "has money" "5" $(echo $COUNT | jq .data.TotalFees[0].amount) + checkCounter "1" "5" # FIXME: cannot load apptx properly. # Look at the stack trace