LaconicNetwork/cosmos-sdk
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore: revert multisig M>N rule (backport #23439) (#23444)

Browse Source 
Co-authored-by: Marko <marko@baricevic.me>
This commit is contained in:
mergify[bot] 2025-01-17 16:12:12 +01:00 committed by GitHub
parent 0390254b29
commit f42fc60826
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crypto/keys/multisig/multisig.go
View File

@ -60,9 +60,6 @@ func (m *LegacyAminoPubKey) VerifyMultisignature(getSignBytes multisigtypes.GetS
if int(m.Threshold) <= 0 {
return fmt.Errorf("invalid threshold: must be > 0, got %d", m.Threshold)
}
if len(pubKeys) <= int(m.Threshold) {
return fmt.Errorf("invalid N-M multisig: N (%d) must be > M (%d)", len(pubKeys), m.Threshold)
}
// ensure bit array is the correct size
if len(pubKeys) != size {
return fmt.Errorf("bit array size is incorrect, expecting: %d", len(pubKeys))

12
crypto/keys/multisig/multisig_test.go
View File

@ -508,18 +508,6 @@ func TestVerifyMultisignatureNMRule(t *testing.T) {
m: 0,
expectErr: "invalid threshold: must be > 0, got 0",
},
{
name: "invalid: N=M",
n: 3,
m: 3,
expectErr: "invalid N-M multisig: N (3) must be > M (3)",
},
{
name: "invalid: N < M",
n: 2,
m: 3,
expectErr: "invalid N-M multisig: N (2) must be > M (3)",
},
}
for _, tc := range tests {