LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore: x/evidence audit changes (backport #16715) (#16725)

Browse Source 
Co-authored-by: Likhita Polavarapu <78951027+likhita-809@users.noreply.github.com>
This commit is contained in:
mergify[bot] 2023-06-27 14:41:51 +00:00 committed by GitHub
parent 1ac4a4dbfe
commit efae407c06
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
x/evidence/CHANGELOG.md
View File

@ -39,4 +39,4 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Client Breaking Changes
* [#16625](https://github.com/cosmos/cosmos-sdk/pull/16625) The `simd q evidence evidence` command supports only querying an evidence by hash. For querying all evidences, use `simd q evidence list` instad.
* [#16625](https://github.com/cosmos/cosmos-sdk/pull/16625) The `simd q evidence evidence` command supports only querying an evidence by hash. For querying all evidences, use `simd q evidence list` instead.

6
x/evidence/keeper/keeper_test.go
View File

@ -35,11 +35,7 @@ var (
newPubKey("0B485CFC0EECC619440448436F8FC9DF40566F2369E72400281454CB552AFB52"),
}
valAddresses = []sdk.ValAddress{
sdk.ValAddress(pubkeys[0].Address()),
sdk.ValAddress(pubkeys[1].Address()),
sdk.ValAddress(pubkeys[2].Address()),
}
valAddress = sdk.ValAddress(pubkeys[0].Address())
)
func newPubKey(pk string) (res cryptotypes.PubKey) {

6
x/evidence/keeper/msg_server_test.go
View File

@ -19,7 +19,7 @@ func (s *KeeperTestSuite) TestSubmitEvidence() {
ConsensusAddress: sdk.ConsAddress(pk.PubKey().Address().Bytes()).String(),
}
validEvidence, err := types.NewMsgSubmitEvidence(sdk.AccAddress(valAddresses[0]), e)
validEvidence, err := types.NewMsgSubmitEvidence(sdk.AccAddress(valAddress), e)
s.Require().NoError(err)
e2 := &types.Equivocation{
@ -29,7 +29,7 @@ func (s *KeeperTestSuite) TestSubmitEvidence() {
ConsensusAddress: sdk.ConsAddress(pk.PubKey().Address().Bytes()).String(),
}
invalidEvidence, err := types.NewMsgSubmitEvidence(sdk.AccAddress(valAddresses[0]), e2)
invalidEvidence, err := types.NewMsgSubmitEvidence(sdk.AccAddress(valAddress), e2)
s.Require().NoError(err)
testCases := []struct {
@ -47,7 +47,7 @@ func (s *KeeperTestSuite) TestSubmitEvidence() {
{
name: "missing evidence",
req: &types.MsgSubmitEvidence{
Submitter: sdk.AccAddress(valAddresses[0]).String(),
Submitter: sdk.AccAddress(valAddress).String(),
},
expErr: true,
expErrMsg: "missing evidence: invalid evidence",

6
x/evidence/types/msgs.go
View File

@ -30,12 +30,6 @@ func NewMsgSubmitEvidence(s sdk.AccAddress, evi exported.Evidence) (*MsgSubmitEv
return &MsgSubmitEvidence{Submitter: s.String(), Evidence: any}, nil
}
// GetSigners returns the single expected signer for a MsgSubmitEvidence.
func (m MsgSubmitEvidence) GetSigners() []sdk.AccAddress {
submitter, _ := sdk.AccAddressFromBech32(m.Submitter)
return []sdk.AccAddress{submitter}
}
func (m MsgSubmitEvidence) GetEvidence() exported.Evidence {
if m.Evidence == nil {
return nil