refactor: Mark tips as beta (#12089)
## Description Following our SDK call, we decided to mark the Tip decorator as beta for now, and not include it in the default posthandler chain. This PR also fixes events not all included in the response in SimulateTx. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This commit is contained in:
@@ -2,26 +2,14 @@ package posthandler
|
||||
|
||||
import (
|
||||
sdk "github.com/cosmos/cosmos-sdk/types"
|
||||
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
||||
"github.com/cosmos/cosmos-sdk/x/auth/types"
|
||||
)
|
||||
|
||||
// HandlerOptions are the options required for constructing a default SDK PostHandler.
|
||||
type HandlerOptions struct {
|
||||
BankKeeper types.BankKeeper
|
||||
}
|
||||
type HandlerOptions struct{}
|
||||
|
||||
// NewAnteHandler returns an AnteHandler that checks and increments sequence
|
||||
// numbers, checks signatures & account numbers, and deducts fees from the first
|
||||
// signer.
|
||||
// NewPostHandler returns an empty posthandler chain.
|
||||
func NewPostHandler(options HandlerOptions) (sdk.AnteHandler, error) {
|
||||
if options.BankKeeper == nil {
|
||||
return nil, sdkerrors.Wrap(sdkerrors.ErrLogic, "bank keeper is required for posthandler")
|
||||
}
|
||||
|
||||
postDecorators := []sdk.AnteDecorator{
|
||||
NewTipDecorator(options.BankKeeper),
|
||||
}
|
||||
postDecorators := []sdk.AnteDecorator{}
|
||||
|
||||
return sdk.ChainAnteDecorators(postDecorators...), nil
|
||||
}
|
||||
|
||||
@@ -16,6 +16,8 @@ type tipDecorator struct {
|
||||
|
||||
// NewTipDecorator returns a new decorator for handling transactions with
|
||||
// tips.
|
||||
//
|
||||
// IMPORTANT: This decorator is still in beta, please use it at your own risk.
|
||||
func NewTipDecorator(bankKeeper types.BankKeeper) sdk.AnteDecorator {
|
||||
return tipDecorator{
|
||||
bankKeeper: bankKeeper,
|
||||
|
||||
Reference in New Issue
Block a user