From e9311958312f6b0b5c9c647614a52319fd70868b Mon Sep 17 00:00:00 2001 From: Christopher Goes Date: Wed, 26 Sep 2018 18:06:52 +0200 Subject: [PATCH] Remove unnecessary changes --- x/mock/simulation/random_simulate_blocks.go | 1 + x/stake/keeper/validator_test.go | 15 --------------- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/x/mock/simulation/random_simulate_blocks.go b/x/mock/simulation/random_simulate_blocks.go index 3c9e676a9a..ee93cfea39 100644 --- a/x/mock/simulation/random_simulate_blocks.go +++ b/x/mock/simulation/random_simulate_blocks.go @@ -398,6 +398,7 @@ func RandomRequestBeginBlock(r *rand.Rand, validators map[string]mockValidator, // updateValidators mimicks Tendermint's update logic // nolint: unparam func updateValidators(tb testing.TB, r *rand.Rand, current map[string]mockValidator, updates []abci.ValidatorUpdate, event func(string)) map[string]mockValidator { + for _, update := range updates { switch { case update.Power == 0: diff --git a/x/stake/keeper/validator_test.go b/x/stake/keeper/validator_test.go index c12758de67..566e8a46f8 100644 --- a/x/stake/keeper/validator_test.go +++ b/x/stake/keeper/validator_test.go @@ -699,21 +699,6 @@ func TestGetValidTendermintUpdatesAllNone(t *testing.T) { updates := keeper.GetValidTendermintUpdates(ctx) assert.Equal(t, 2, len(updates)) - - // test from something to nothing - // tendermintUpdate set: {} -> {c1, c2, c3, c4} - keeper.ClearTendermintUpdates(ctx) - require.Equal(t, 0, len(keeper.GetTendermintUpdates(ctx))) - - keeper.RemoveValidator(ctx, validators[0].OperatorAddr) - keeper.RemoveValidator(ctx, validators[1].OperatorAddr) - - updates = keeper.GetTendermintUpdates(ctx) - assert.Equal(t, 2, len(updates)) - assert.Equal(t, tmtypes.TM2PB.PubKey(validators[0].ConsPubKey), updates[0].PubKey) - assert.Equal(t, tmtypes.TM2PB.PubKey(validators[1].ConsPubKey), updates[1].PubKey) - assert.Equal(t, int64(0), updates[0].Power) - assert.Equal(t, int64(0), updates[1].Power) assert.Equal(t, validators[0].ABCIValidatorUpdate(), updates[0]) assert.Equal(t, validators[1].ABCIValidatorUpdate(), updates[1]) }