LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

Update pending and skip statik in test_lint

Browse Source
This commit is contained in:
HaoyangLiu
2018-09-02 22:30:24 +08:00
parent e742b02d3b
commit e496bbd6f5
5 changed files with 29 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/keys/add.go
+26 -25
View File
@@ -164,7 +164,28 @@ type NewKeyBody struct {
Seed string `json:"seed"`
}
// add new key REST handler
func paramCheck(m NewKeyBody, kb keys.Keybase) (int, string) {
if m.Name == "" {
return http.StatusBadRequest, fmt.Sprintf("You have to specify a name for the locally stored account.")
}
if m.Password == "" {
return http.StatusBadRequest, fmt.Sprintf("You have to specify a password for the locally stored account.")
}
// check if already exists
infos, err := kb.List()
if err != nil {
return http.StatusInternalServerError, err.Error()
}
for _, i := range infos {
if i.GetName() == m.Name {
return http.StatusConflict, fmt.Sprintf("Account with name %s already exists.", m.Name)
}
}
return http.StatusOK, ""
}
// AddNewKeyRequestHandler add new key REST handler
func AddNewKeyRequestHandler(w http.ResponseWriter, r *http.Request) {
var kb keys.Keybase
var m NewKeyBody
@@ -190,32 +211,12 @@ func AddNewKeyRequestHandler(w http.ResponseWriter, r *http.Request) {
return
}
if err != nil {
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte(err.Error()))
code, errMsg := paramCheck(m, kb)
if code != http.StatusOK {
w.WriteHeader(code)
w.Write([]byte(errMsg))
return
}
if m.Name == "" {
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte("You have to specify a name for the locally stored account."))
return
}
if m.Password == "" {
w.WriteHeader(http.StatusBadRequest)
w.Write([]byte("You have to specify a password for the locally stored account."))
return
}
// check if already exists
infos, err := kb.List()
for _, i := range infos {
if i.GetName() == m.Name {
w.WriteHeader(http.StatusConflict)
w.Write([]byte(fmt.Sprintf("Account with name %s already exists.", m.Name)))
return
}
}
// create account
seed := m.Seed
if seed == "" {
client/lcd/README.md
-22
View File
@@ -1,22 +0,0 @@
# How to update API docs
Due to the rest handlers and related data structures are distributed in many sub-folds, currently there is no tool which can automatically extract all APIs information and generate API docs. So here we have to write APIs' docs manually.
## Steps
1. Install the command line tool first.
```
go get github.com/rakyll/statik
```
2. Edit API docs
1. Directly Edit API docs manually: `client/lcd/swaggerui/swagger.jso`
2. Edit API docs within this [SwaggerHub](https://app.swaggerhub.com). Please refer to this [link](https://app.swaggerhub.com/help/index) for how to use the about website to edit API docs.
3. Download `swagger.json` and replace the old `swagger.json` under `client/lcd/swaggerui` folds
4. Regenerate `client/lcd/statik/statik.go` file
```
statik -src=client/lcd/swaggerui -dest=client/lcd
```
5. Compile new gaiacli
```
make install
```