Merge PR #3674: Remove password/keybase from REST Client

x/auth/client/rest/query.go

@@ -31,10 +31,6 @@ func RegisterRoutes(cliCtx context.CLIContext, r *mux.Router, cdc *codec.Codec,
 		"/tx/encode",
 		EncodeTxRequestHandlerFn(cdc, cliCtx),
 	).Methods("POST")
-	r.HandleFunc(
-		"/tx/sign",
-		SignTxRequestHandlerFn(cdc, cliCtx),
-	).Methods("POST")
 }
 
 // query accountREST Handler

x/auth/client/rest/requests.go

@@ -5,5 +5,5 @@ import "github.com/cosmos/cosmos-sdk/x/auth"
 // BroadcastReq requests broadcasting a transaction
 type BroadcastReq struct {
 	Tx     auth.StdTx `json:"tx"`
-	Return string     `json:"return"`
+	Return string     `json:"return"` // TODO: Do we need this?
 }

x/auth/client/rest/sign.go

@@ -1,81 +0,0 @@
-package rest
-
-import (
-	"net/http"
-
-	"github.com/cosmos/cosmos-sdk/client/context"
-	"github.com/cosmos/cosmos-sdk/client/utils"
-	"github.com/cosmos/cosmos-sdk/codec"
-	"github.com/cosmos/cosmos-sdk/crypto/keys/keyerror"
-	sdk "github.com/cosmos/cosmos-sdk/types"
-	"github.com/cosmos/cosmos-sdk/types/rest"
-
-	"github.com/cosmos/cosmos-sdk/x/auth"
-	authtxb "github.com/cosmos/cosmos-sdk/x/auth/client/txbuilder"
-)
-
-// SignBody defines the properties of a sign request's body.
-type SignBody struct {
-	Tx        auth.StdTx   `json:"tx"`
-	AppendSig bool         `json:"append_sig"`
-	BaseReq   rest.BaseReq `json:"base_req"`
-}
-
-// nolint: unparam
-// sign tx REST handler
-func SignTxRequestHandlerFn(cdc *codec.Codec, cliCtx context.CLIContext) http.HandlerFunc {
-	return func(w http.ResponseWriter, r *http.Request) {
-		var m SignBody
-
-		if !rest.ReadRESTReq(w, r, cdc, &m) {
-			return
-		}
-
-		if !m.BaseReq.ValidateBasic(w) {
-			return
-		}
-
-		// validate tx
-		// discard error if it's CodeNoSignatures as the tx comes with no signatures
-		if err := m.Tx.ValidateBasic(); err != nil && err.Code() != sdk.CodeNoSignatures {
-			rest.WriteErrorResponse(w, http.StatusBadRequest, err.Error())
-			return
-		}
-
-		// derive the from account address and name from the Keybase
-		fromAddress, fromName, err := context.GetFromFields(m.BaseReq.From)
-		if err != nil {
-			rest.WriteErrorResponse(w, http.StatusBadRequest, err.Error())
-			return
-		}
-
-		cliCtx = cliCtx.WithFromName(fromName).WithFromAddress(fromAddress)
-
-		txBldr := authtxb.NewTxBuilder(
-			utils.GetTxEncoder(cdc),
-			m.BaseReq.AccountNumber,
-			m.BaseReq.Sequence,
-			m.Tx.Fee.Gas,
-			1.0,
-			false,
-			m.BaseReq.ChainID,
-			m.Tx.GetMemo(),
-			m.Tx.Fee.Amount,
-			nil,
-		)
-
-		signedTx, err := txBldr.SignStdTx(cliCtx.GetFromName(), m.BaseReq.Password, m.Tx, m.AppendSig)
-		if keyerror.IsErrKeyNotFound(err) {
-			rest.WriteErrorResponse(w, http.StatusBadRequest, err.Error())
-			return
-		} else if keyerror.IsErrWrongPassword(err) {
-			rest.WriteErrorResponse(w, http.StatusUnauthorized, err.Error())
-			return
-		} else if err != nil {
-			rest.WriteErrorResponse(w, http.StatusInternalServerError, err.Error())
-			return
-		}
-
-		rest.PostProcessResponse(w, cdc, signedTx, cliCtx.Indent)
-	}
-}