LaconicNetwork/cosmos-sdk
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore(store): use the built-in clear to clear the map (#23381)

Browse Source 
Co-authored-by: Alex | Interchain Labs <alex@skip.money>
This commit is contained in:
caseylove 2025-01-14 22:33:52 +08:00 committed by GitHub
parent 5fb5ddaa1c
commit dfb5cc29f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
store/cachekv/store.go
View File

@ -104,12 +104,8 @@ func (store *Store) resetCaches() {
// Clear the cache using the map clearing idiom
// and not allocating fresh objects.
// Please see https://bencher.orijtech.com/perfclinic/mapclearing/
for key := range store.cache {
delete(store.cache, key)
}
for key := range store.unsortedCache {
delete(store.unsortedCache, key)
}
clear(store.cache)
clear(store.unsortedCache)
}
store.sortedCache = internal.NewBTree()
}
@ -369,9 +365,7 @@ func (store *Store) dirtyItems(start, end []byte) {
func (store *Store) clearUnsortedCacheSubset(unsorted []*kv.Pair, sortState sortState) { //nolint:staticcheck // We are in store v1.
n := len(store.unsortedCache)
if len(unsorted) == n { // This pattern allows the Go compiler to emit the map clearing idiom for the entire map.
for key := range store.unsortedCache {
delete(store.unsortedCache, key)
}
clear(store.unsortedCache)
} else { // Otherwise, normally delete the unsorted keys from the map.
for _, kv := range unsorted {
delete(store.unsortedCache, conv.UnsafeBytesToStr(kv.Key))