LaconicNetwork/cosmos-sdk
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

refactor(gov)!: use collections for Vote state management. (#16164)

Browse Source 
Co-authored-by: unknown unknown <unknown@unknown>
This commit is contained in:
testinginprod 2023-05-16 05:42:03 +02:00 committed by GitHub
parent bf3749207e
commit deba79d7aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 84 additions and 215 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CHANGELOG.md
View File

@ -196,14 +196,19 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (types/math) [#16040](https://github.com/cosmos/cosmos-sdk/pull/16040) Remove unused aliases in math.go
* (x/gov) [#16106](https://github.com/cosmos/cosmos-sdk/pull/16106) Remove gRPC query methods from Keeper
* (x/gov) [#16118](https://github.com/cosmos/cosmos-sdk/pull/16118/) Use collections for constituion and params state management.
* (x/gov) [](https://github.com/cosmos/cosmos-sdk/pull/16127) Use collections for deposit management:
* (x/gov) [#16127](https://github.com/cosmos/cosmos-sdk/pull/16127) Use collections for deposit state management:
- The following methods are removed from the gov keeper: `GetDeposit`, `GetAllDeposits`, `IterateAllDeposits`.
- The following functions are removed from the gov types: `DepositKey`, `DepositsKey`.
* (x/gov) [#16164](https://github.com/cosmos/cosmos-sdk/pull/16164) Use collections for vote state management:
- Removed: types `VoteKey`, `VoteKeys`
- Removed: keeper `IterateVotes`, `IterateAllVotes`, `GetVotes`, `GetVote`, `SetVote`
* (sims) [#16155](https://github.com/cosmos/cosmos-sdk/pull/16155)
* `simulation.NewOperationMsg` now marshals the operation msg as proto bytes instead of legacy amino JSON bytes.
* `simulation.NewOperationMsg` is now 2-arity instead of 3-arity with the obsolete argument `codec.ProtoCodec` removed.
* The field `OperationMsg.Msg` is now of type `[]byte` instead of `json.RawMessage`.
### Client Breaking Changes
* (x/staking) [#15701](https://github.com/cosmos/cosmos-sdk/pull/15701) `HistoricalInfoKey` now has a binary format.

41
x/gov/genesis.go
View File

@ -1,8 +1,11 @@
package gov
import (
"errors"
"fmt"
"cosmossdk.io/collections"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/gov/keeper"
"github.com/cosmos/cosmos-sdk/x/gov/types"
@ -42,7 +45,14 @@ func InitGenesis(ctx sdk.Context, ak types.AccountKeeper, bk types.BankKeeper, k
}
for _, vote := range data.Votes {
k.SetVote(ctx, *vote)
addr, err := ak.StringToBytes(vote.Voter)
if err != nil {
panic(err)
}
err = k.Votes.Set(ctx, collections.Join(vote.ProposalId, sdk.AccAddress(addr)), *vote)
if err != nil {
panic(err)
}
}
for _, proposal := range data.Proposals {
@ -90,21 +100,22 @@ func ExportGenesis(ctx sdk.Context, k *keeper.Keeper) (*v1.GenesisState, error)
}
var proposalsDeposits v1.Deposits
err = k.Deposits.Walk(ctx, nil, func(_ collections.Pair[uint64, sdk.AccAddress], value v1.Deposit) (stop bool, err error) {
proposalsDeposits = append(proposalsDeposits, &value)
return false, nil
})
if err != nil && !errors.Is(err, collections.ErrInvalidIterator) {
panic(err)
}
// export proposals votes
var proposalsVotes v1.Votes
for _, proposal := range proposals {
deposits, err := k.GetDeposits(ctx, proposal.Id)
if err != nil {
return nil, err
}
proposalsDeposits = append(proposalsDeposits, deposits...)
votes, err := k.GetVotes(ctx, proposal.Id)
if err != nil {
return nil, err
}
proposalsVotes = append(proposalsVotes, votes...)
err = k.Votes.Walk(ctx, nil, func(_ collections.Pair[uint64, sdk.AccAddress], value v1.Vote) (stop bool, err error) {
proposalsVotes = append(proposalsVotes, &value)
return false, nil
})
if err != nil && !errors.Is(err, collections.ErrInvalidIterator) {
panic(err)
}
return &v1.GenesisState{

24
x/gov/keeper/grpc_query.go
View File

@ -82,9 +82,9 @@ func (q queryServer) Proposals(ctx context.Context, req *v1.QueryProposalsReques
return nil, err
}
_, err = q.k.GetVote(ctx, p.Id, voter)
has, err := q.k.Votes.Has(ctx, collections.Join(p.Id, sdk.AccAddress(voter)))
// if no error, vote found, matchVoter = true
matchVoter = err == nil
matchVoter = err == nil && has
}
// match depositor (if supplied)
@ -131,9 +131,9 @@ func (q queryServer) Vote(ctx context.Context, req *v1.QueryVoteRequest) (*v1.Qu
if err != nil {
return nil, err
}
vote, err := q.k.GetVote(ctx, req.ProposalId, voter)
vote, err := q.k.Votes.Get(ctx, collections.Join(req.ProposalId, sdk.AccAddress(voter)))
if err != nil {
if errors.IsOf(err, types.ErrVoteNotFound) {
if errors.IsOf(err, collections.ErrNotFound) {
return nil, status.Errorf(codes.InvalidArgument,
"voter: %v not found for proposal: %v", req.Voter, req.ProposalId)
}
@ -154,18 +154,10 @@ func (q queryServer) Votes(ctx context.Context, req *v1.QueryVotesRequest) (*v1.
}
var votes v1.Votes
store := q.k.storeService.OpenKVStore(ctx)
votesStore := prefix.NewStore(runtime.KVStoreAdapter(store), types.VotesKey(req.ProposalId))
pageRes, err := query.Paginate(votesStore, req.Pagination, func(key, value []byte) error {
var vote v1.Vote
if err := q.k.cdc.Unmarshal(value, &vote); err != nil {
return err
}
votes = append(votes, &vote)
return nil
})
_, pageRes, err := query.CollectionFilteredPaginate(ctx, q.k.Votes, req.Pagination, func(_ collections.Pair[uint64, sdk.AccAddress], value v1.Vote) (include bool, err error) {
votes = append(votes, &value)
return false, nil // not including results because they're being appended.
}, query.WithCollectionPaginationPairPrefix[uint64, sdk.AccAddress](req.ProposalId))
if err != nil {
return nil, status.Error(codes.Internal, err.Error())
}

2
x/gov/keeper/keeper.go
View File

@ -54,6 +54,7 @@ type Keeper struct {
Constitution collections.Item[string]
Params collections.Item[v1.Params]
Deposits collections.Map[collections.Pair[uint64, sdk.AccAddress], v1.Deposit]
Votes collections.Map[collections.Pair[uint64, sdk.AccAddress], v1.Vote]
}
// GetAuthority returns the x/gov module's authority.
@ -101,6 +102,7 @@ func NewKeeper(
Constitution: collections.NewItem(sb, types.ConstitutionKey, "constitution", collections.StringValue),
Params: collections.NewItem(sb, types.ParamsKey, "params", codec.CollValue[v1.Params](cdc)),
Deposits: collections.NewMap(sb, types.DepositsKeyPrefix, "deposits", collections.PairKeyCodec(collections.Uint64Key, sdk.AddressKeyAsIndexKey(sdk.AccAddressKey)), codec.CollValue[v1.Deposit](cdc)), //nolint: staticcheck // Needed to retain state compatibility
Votes: collections.NewMap(sb, types.VotesKeyPrefix, "votes", collections.PairKeyCodec(collections.Uint64Key, sdk.AddressKeyAsIndexKey(sdk.AccAddressKey)), codec.CollValue[v1.Vote](cdc)), //nolint: staticcheck // Needed to retain state compatibility
}
schema, err := sb.Build()
if err != nil {

2
x/gov/keeper/migrations.go
View File

@ -38,7 +38,7 @@ func (m Migrator) Migrate3to4(ctx sdk.Context) error {
return v4.MigrateStore(ctx, m.keeper.storeService, m.legacySubspace, m.keeper.cdc)
}
// Migrate3to4 migrates from version 4 to 5.
// Migrate4to5 migrates from version 4 to 5.
func (m Migrator) Migrate4to5(ctx sdk.Context) error {
return v5.MigrateStore(ctx, m.keeper.storeService, m.keeper.cdc)
}

4
x/gov/keeper/proposal.go
View File

@ -318,9 +318,9 @@ func (keeper Keeper) GetProposalsFiltered(ctx context.Context, params v1.QueryPr
// match voter address (if supplied)
if len(params.Voter) > 0 {
_, err = keeper.GetVote(ctx, p.Id, params.Voter)
has, err := keeper.Votes.Has(ctx, collections.Join(p.Id, params.Voter))
// if no error, vote found, matchVoter = true
matchVoter = err == nil
matchVoter = err == nil && has
}
// match depositor (if supplied)

4
x/gov/keeper/proposal_test.go
View File

@ -7,6 +7,8 @@ import (
"testing"
"time"
"cosmossdk.io/collections"
"github.com/stretchr/testify/require"
"github.com/cosmos/cosmos-sdk/testutil/testdata"
@ -200,7 +202,7 @@ func (suite *KeeperTestSuite) TestGetProposalsFiltered() {
d := v1.NewDeposit(proposalID, addr1, nil)
v := v1.NewVote(proposalID, addr1, v1.NewNonSplitVoteOption(v1.OptionYes), "")
suite.govKeeper.SetDeposit(suite.ctx, d)
suite.govKeeper.SetVote(suite.ctx, v)
require.NoError(suite.T(), suite.govKeeper.Votes.Set(suite.ctx, collections.Join(proposalID, addr1), v))
}
suite.govKeeper.SetProposal(suite.ctx, p)

13
x/gov/keeper/tally.go
View File

@ -2,6 +2,9 @@ package keeper
import (
"context"
"errors"
"cosmossdk.io/collections"
"cosmossdk.io/math"
@ -37,12 +40,12 @@ func (keeper Keeper) Tally(ctx context.Context, proposal v1.Proposal) (passes, b
return false
})
err = keeper.IterateVotes(ctx, proposal.Id, func(vote v1.Vote) error {
rng := collections.NewPrefixedPairRange[uint64, sdk.AccAddress](proposal.Id)
err = keeper.Votes.Walk(ctx, rng, func(key collections.Pair[uint64, sdk.AccAddress], vote v1.Vote) (bool, error) {
// if validator, just record it in the map
voter, err := keeper.authKeeper.StringToBytes(vote.Voter)
if err != nil {
return err
return false, err
}
valAddrStr := sdk.ValAddress(voter).String()
@ -75,10 +78,10 @@ func (keeper Keeper) Tally(ctx context.Context, proposal v1.Proposal) (passes, b
return false
})
return keeper.deleteVote(ctx, vote.ProposalId, voter)
return false, keeper.Votes.Remove(ctx, collections.Join(vote.ProposalId, sdk.AccAddress(voter)))
})
if err != nil {
if err != nil && !errors.Is(err, collections.ErrInvalidIterator) {
return false, false, tallyResults, err
}

121
x/gov/keeper/vote.go
View File

@ -4,10 +4,9 @@ import (
"context"
"fmt"
"cosmossdk.io/errors"
storetypes "cosmossdk.io/store/types"
"cosmossdk.io/collections"
"github.com/cosmos/cosmos-sdk/runtime"
"cosmossdk.io/errors"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/gov/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
@ -38,7 +37,7 @@ func (keeper Keeper) AddVote(ctx context.Context, proposalID uint64, voterAddr s
}
vote := v1.NewVote(proposalID, voterAddr, options, metadata)
err = keeper.SetVote(ctx, vote)
err = keeper.Votes.Set(ctx, collections.Join(proposalID, voterAddr), vote)
if err != nil {
return err
}
@ -58,118 +57,8 @@ func (keeper Keeper) AddVote(ctx context.Context, proposalID uint64, voterAddr s
return nil
}
// GetAllVotes returns all the votes from the store
func (keeper Keeper) GetAllVotes(ctx context.Context) (votes v1.Votes, err error) {
err = keeper.IterateAllVotes(ctx, func(vote v1.Vote) error {
votes = append(votes, &vote)
return nil
})
return
}
// GetVotes returns all the votes from a proposal
func (keeper Keeper) GetVotes(ctx context.Context, proposalID uint64) (votes v1.Votes, err error) {
err = keeper.IterateVotes(ctx, proposalID, func(vote v1.Vote) error {
votes = append(votes, &vote)
return nil
})
return
}
// GetVote gets the vote from an address on a specific proposal
func (keeper Keeper) GetVote(ctx context.Context, proposalID uint64, voterAddr sdk.AccAddress) (vote v1.Vote, err error) {
store := keeper.storeService.OpenKVStore(ctx)
bz, err := store.Get(types.VoteKey(proposalID, voterAddr))
if err != nil {
return vote, err
}
if bz == nil {
return vote, types.ErrVoteNotFound
}
err = keeper.cdc.Unmarshal(bz, &vote)
if err != nil {
return vote, err
}
return vote, nil
}
// SetVote sets a Vote to the gov store
func (keeper Keeper) SetVote(ctx context.Context, vote v1.Vote) error {
store := keeper.storeService.OpenKVStore(ctx)
bz, err := keeper.cdc.Marshal(&vote)
if err != nil {
return err
}
addr, err := keeper.authKeeper.StringToBytes(vote.Voter)
if err != nil {
return err
}
return store.Set(types.VoteKey(vote.ProposalId, addr), bz)
}
// IterateAllVotes iterates over all the stored votes and performs a callback function
func (keeper Keeper) IterateAllVotes(ctx context.Context, cb func(vote v1.Vote) error) error {
store := keeper.storeService.OpenKVStore(ctx)
iterator := storetypes.KVStorePrefixIterator(runtime.KVStoreAdapter(store), types.VotesKeyPrefix)
defer iterator.Close()
for ; iterator.Valid(); iterator.Next() {
var vote v1.Vote
err := keeper.cdc.Unmarshal(iterator.Value(), &vote)
if err != nil {
return err
}
err = cb(vote)
// exit early without error if cb returns ErrStopIterating
if errors.IsOf(err, errors.ErrStopIterating) {
return nil
} else if err != nil {
return err
}
}
return nil
}
// IterateVotes iterates over all the proposals votes and performs a callback function
func (keeper Keeper) IterateVotes(ctx context.Context, proposalID uint64, cb func(vote v1.Vote) error) error {
store := keeper.storeService.OpenKVStore(ctx)
iterator := storetypes.KVStorePrefixIterator(runtime.KVStoreAdapter(store), types.VotesKey(proposalID))
defer iterator.Close()
for ; iterator.Valid(); iterator.Next() {
var vote v1.Vote
err := keeper.cdc.Unmarshal(iterator.Value(), &vote)
if err != nil {
return err
}
err = cb(vote)
// exit early without error if cb returns ErrStopIterating
if errors.IsOf(err, errors.ErrStopIterating) {
return nil
} else if err != nil {
return err
}
}
return nil
}
// deleteVotes deletes the all votes from a given proposalID.
func (keeper Keeper) deleteVotes(ctx context.Context, proposalID uint64) error {
store := keeper.storeService.OpenKVStore(ctx)
return store.Delete(types.VotesKey(proposalID))
}
// deleteVote deletes a vote from a given proposalID and voter from the store
func (keeper Keeper) deleteVote(ctx context.Context, proposalID uint64, voterAddr sdk.AccAddress) error {
store := keeper.storeService.OpenKVStore(ctx)
return store.Delete(types.VoteKey(proposalID, voterAddr))
// TODO(tip): fix https://github.com/cosmos/cosmos-sdk/issues/16162
return nil
}

25
x/gov/keeper/vote_test.go
View File

@ -3,12 +3,13 @@ package keeper_test
import (
"testing"
"cosmossdk.io/collections"
sdkmath "cosmossdk.io/math"
"github.com/stretchr/testify/require"
simtestutil "github.com/cosmos/cosmos-sdk/testutil/sims"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/x/gov/types"
v1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1"
)
@ -38,7 +39,7 @@ func TestVotes(t *testing.T) {
// Test first vote
require.NoError(t, govKeeper.AddVote(ctx, proposalID, addrs[0], v1.NewNonSplitVoteOption(v1.OptionAbstain), metadata))
vote, err := govKeeper.GetVote(ctx, proposalID, addrs[0])
vote, err := govKeeper.Votes.Get(ctx, collections.Join(proposalID, addrs[0]))
require.Nil(t, err)
require.Equal(t, addrs[0].String(), vote.Voter)
require.Equal(t, proposalID, vote.ProposalId)
@ -47,7 +48,7 @@ func TestVotes(t *testing.T) {
// Test change of vote
require.NoError(t, govKeeper.AddVote(ctx, proposalID, addrs[0], v1.NewNonSplitVoteOption(v1.OptionYes), ""))
vote, err = govKeeper.GetVote(ctx, proposalID, addrs[0])
vote, err = govKeeper.Votes.Get(ctx, collections.Join(proposalID, addrs[0]))
require.Nil(t, err)
require.Equal(t, addrs[0].String(), vote.Voter)
require.Equal(t, proposalID, vote.ProposalId)
@ -61,7 +62,7 @@ func TestVotes(t *testing.T) {
v1.NewWeightedVoteOption(v1.OptionAbstain, sdkmath.LegacyNewDecWithPrec(5, 2)),
v1.NewWeightedVoteOption(v1.OptionNoWithVeto, sdkmath.LegacyNewDecWithPrec(5, 2)),
}, ""))
vote, err = govKeeper.GetVote(ctx, proposalID, addrs[1])
vote, err = govKeeper.Votes.Get(ctx, collections.Join(proposalID, addrs[1]))
require.Nil(t, err)
require.Equal(t, addrs[1].String(), vote.Voter)
require.Equal(t, proposalID, vote.ProposalId)
@ -77,9 +78,17 @@ func TestVotes(t *testing.T) {
// Test vote iterator
// NOTE order of deposits is determined by the addresses
votes, _ := govKeeper.GetAllVotes(ctx)
var votes v1.Votes
require.NoError(t, govKeeper.Votes.Walk(ctx, nil, func(_ collections.Pair[uint64, sdk.AccAddress], value v1.Vote) (stop bool, err error) {
votes = append(votes, &value)
return false, nil
}))
require.Len(t, votes, 2)
propVotes, _ := govKeeper.GetVotes(ctx, proposalID)
var propVotes v1.Votes
require.NoError(t, govKeeper.Votes.Walk(ctx, collections.NewPrefixedPairRange[uint64, sdk.AccAddress](proposalID), func(_ collections.Pair[uint64, sdk.AccAddress], value v1.Vote) (stop bool, err error) {
propVotes = append(propVotes, &value)
return false, nil
}))
require.Equal(t, votes, propVotes)
require.Equal(t, addrs[0].String(), votes[0].Voter)
require.Equal(t, proposalID, votes[0].ProposalId)
@ -94,6 +103,6 @@ func TestVotes(t *testing.T) {
require.Equal(t, votes[1].Options[3].Weight, sdkmath.LegacyNewDecWithPrec(5, 2).String())
// non existent vote
_, err = govKeeper.GetVote(ctx, proposalID+100, addrs[1])
require.ErrorIs(t, err, types.ErrVoteNotFound)
_, err = govKeeper.Votes.Get(ctx, collections.Join(proposalID+100, addrs[1]))
require.ErrorIs(t, err, collections.ErrNotFound)
}

6
x/gov/migrations/v2/store_test.go
View File

@ -72,7 +72,7 @@ func TestMigrateStore(t *testing.T) {
{
"VotesKeyPrefix",
v1.VoteKey(proposalID, addr1), oldVoteValue,
types.VoteKey(proposalID, addr1), newVoteValue,
voteKey(proposalID, addr1), newVoteValue,
},
}
@ -103,3 +103,7 @@ func TestMigrateStore(t *testing.T) {
func depositKey(proposalID uint64, depositorAddr sdk.AccAddress) []byte {
return append(append(types.DepositsKeyPrefix, sdk.Uint64ToBigEndian(proposalID)...), address.MustLengthPrefix(depositorAddr.Bytes())...)
}
func voteKey(proposalID uint64, addr sdk.AccAddress) []byte {
return append(append(types.VotesKeyPrefix, sdk.Uint64ToBigEndian(proposalID)...), address.MustLengthPrefix(addr.Bytes())...)
}

34
x/gov/types/keys.go
View File

@ -7,7 +7,6 @@ import (
"cosmossdk.io/collections"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/address"
"github.com/cosmos/cosmos-sdk/types/kv"
)
@ -49,7 +48,7 @@ var (
DepositsKeyPrefix = collections.NewPrefix(16)
VotesKeyPrefix = []byte{0x20}
VotesKeyPrefix = collections.NewPrefix(32)
// ParamsKey is the key to query all gov params
ParamsKey = collections.NewPrefix(48)
@ -102,22 +101,11 @@ func InactiveProposalQueueKey(proposalID uint64, endTime time.Time) []byte {
return append(InactiveProposalByTimeKey(endTime), GetProposalIDBytes(proposalID)...)
}
// VotesKey gets the first part of the votes key based on the proposalID
func VotesKey(proposalID uint64) []byte {
return append(VotesKeyPrefix, GetProposalIDBytes(proposalID)...)
}
// VoteKey key of a specific vote from the store
func VoteKey(proposalID uint64, voterAddr sdk.AccAddress) []byte {
return append(VotesKey(proposalID), address.MustLengthPrefix(voterAddr.Bytes())...)
}
// Split keys function; used for iterators
// SplitProposalKey split the proposal key and returns the proposal id
func SplitProposalKey(key []byte) (proposalID uint64) {
kv.AssertKeyLength(key[1:], 8)
return GetProposalIDFromBytes(key[1:])
}
@ -131,16 +119,6 @@ func SplitInactiveProposalQueueKey(key []byte) (proposalID uint64, endTime time.
return splitKeyWithTime(key)
}
// SplitKeyDeposit split the deposits key and returns the proposal id and depositor address
func SplitKeyDeposit(key []byte) (proposalID uint64, depositorAddr sdk.AccAddress) {
return splitKeyWithAddress(key)
}
// SplitKeyVote split the votes key and returns the proposal id and voter address
func SplitKeyVote(key []byte) (proposalID uint64, voterAddr sdk.AccAddress) {
return splitKeyWithAddress(key)
}
// private functions
func splitKeyWithTime(key []byte) (proposalID uint64, endTime time.Time) {
@ -154,13 +132,3 @@ func splitKeyWithTime(key []byte) (proposalID uint64, endTime time.Time) {
proposalID = GetProposalIDFromBytes(key[1+lenTime:])
return
}
func splitKeyWithAddress(key []byte) (proposalID uint64, addr sdk.AccAddress) {
// Both Vote and Deposit store keys are of format:
// <prefix (1 Byte)><proposalID (8 bytes)><addrLen (1 Byte)><addr_Bytes>
kv.AssertKeyAtLeastLength(key, 10)
proposalID = GetProposalIDFromBytes(key[1:9])
kv.AssertKeyAtLeastLength(key, 11)
addr = sdk.AccAddress(key[10:])
return
}

16
x/gov/types/keys_test.go
View File

@ -5,13 +5,8 @@ import (
"time"
"github.com/stretchr/testify/require"
"github.com/cosmos/cosmos-sdk/crypto/keys/ed25519"
sdk "github.com/cosmos/cosmos-sdk/types"
)
var addr = sdk.AccAddress(ed25519.GenPrivKey().PubKey().Address())
func TestProposalKeys(t *testing.T) {
// key proposal
key := ProposalKey(1)
@ -35,14 +30,3 @@ func TestProposalKeys(t *testing.T) {
require.Panics(t, func() { SplitProposalKey([]byte("test")) })
require.Panics(t, func() { SplitInactiveProposalQueueKey([]byte("test")) })
}
func TestVoteKeys(t *testing.T) {
key := VotesKey(2)
proposalID := SplitProposalKey(key)
require.Equal(t, int(proposalID), 2)
key = VoteKey(2, addr)
proposalID, voterAddr := SplitKeyDeposit(key)
require.Equal(t, int(proposalID), 2)
require.Equal(t, addr, voterAddr)
}