From dc004c85f2e8b8fb4f66caac2703228c5bf544cf Mon Sep 17 00:00:00 2001 From: Marko Date: Wed, 2 Nov 2022 12:12:36 +0100 Subject: [PATCH] quick lint while doing other prs (#13726) --- tests/integration/bank/keeper/deterministic_test.go | 2 -- testutil/testdata/grpc_query.go | 8 +++----- tx/textual/valuerenderer/string.go | 3 +-- types/mempool/mempool_test.go | 3 ++- x/gov/migrations/v4/store_test.go | 1 - 5 files changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/integration/bank/keeper/deterministic_test.go b/tests/integration/bank/keeper/deterministic_test.go index d94c67ddfe..238740d51f 100644 --- a/tests/integration/bank/keeper/deterministic_test.go +++ b/tests/integration/bank/keeper/deterministic_test.go @@ -185,7 +185,6 @@ func (suite *DeterministicTestSuite) TestGRPCQueryTotalSupply() { initialSupply := res.GetSupply() rapid.Check(suite.T(), func(t *rapid.T) { - numCoins := rapid.IntRange(1, 3).Draw(t, "num-count") coins := make(sdk.Coins, 0, numCoins) @@ -233,7 +232,6 @@ func (suite *DeterministicTestSuite) TestGRPCQueryTotalSupplyOf() { req := &banktypes.QuerySupplyOfRequest{Denom: coin.GetDenom()} testdata.DeterministicIterations(suite.ctx, suite.Require(), req, suite.queryClient.SupplyOf, 0, true) - }) coin := sdk.NewCoin("bar", sdk.NewInt(100)) diff --git a/testutil/testdata/grpc_query.go b/testutil/testdata/grpc_query.go index 85c14f7f1a..1b74e8ae72 100644 --- a/testutil/testdata/grpc_query.go +++ b/testutil/testdata/grpc_query.go @@ -12,11 +12,9 @@ import ( sdk "github.com/cosmos/cosmos-sdk/types" ) -var ( - // iterCount defines the number of iterations to run on each query to test - // determinism. - iterCount = 1000 -) +// iterCount defines the number of iterations to run on each query to test +// determinism. +var iterCount = 1000 type QueryImpl struct{} diff --git a/tx/textual/valuerenderer/string.go b/tx/textual/valuerenderer/string.go index b84a68f51a..d79dc46b0d 100644 --- a/tx/textual/valuerenderer/string.go +++ b/tx/textual/valuerenderer/string.go @@ -7,8 +7,7 @@ import ( "google.golang.org/protobuf/reflect/protoreflect" ) -type stringValueRenderer struct { -} +type stringValueRenderer struct{} // NewStringValueRenderer returns a ValueRenderer for protocol buffer string values. // It renders the string as-is without quotation. diff --git a/types/mempool/mempool_test.go b/types/mempool/mempool_test.go index d6f8e81346..38944a501c 100644 --- a/types/mempool/mempool_test.go +++ b/types/mempool/mempool_test.go @@ -55,7 +55,8 @@ func (tx testTx) GetSignaturesV2() (res []txsigning.SignatureV2, err error) { res = append(res, txsigning.SignatureV2{ PubKey: testPubKey{address: tx.address}, Data: nil, - Sequence: tx.nonce}) + Sequence: tx.nonce, + }) return res, nil } diff --git a/x/gov/migrations/v4/store_test.go b/x/gov/migrations/v4/store_test.go index 74fb64bcd1..cb6cd9bab4 100644 --- a/x/gov/migrations/v4/store_test.go +++ b/x/gov/migrations/v4/store_test.go @@ -119,7 +119,6 @@ func TestMigrateStore(t *testing.T) { // Check if proposal 2 is in the new store but not proposal 1 require.Nil(t, store.Get(v4.VotingPeriodProposalKey(proposal1.Id))) require.Equal(t, []byte{0x1}, store.Get(v4.VotingPeriodProposalKey(proposal2.Id))) - } func getTestProposal() []sdk.Msg {