From d3e51cf8a7474015926a67b76a67b9712d175e59 Mon Sep 17 00:00:00 2001
From: Prathyusha Lakkireddy <prathyusha@vitwit.com>
Date: Mon, 15 Feb 2021 21:13:09 +0530
Subject: [PATCH] Improve create proposal code (#8586)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
---
 x/gov/types/proposal.go | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/x/gov/types/proposal.go b/x/gov/types/proposal.go
index 0c856647f6..f9b59cbfc0 100644
--- a/x/gov/types/proposal.go
+++ b/x/gov/types/proposal.go
@@ -18,15 +18,6 @@ const DefaultStartingProposalID uint64 = 1
 
 // NewProposal creates a new Proposal instance
 func NewProposal(content Content, id uint64, submitTime, depositEndTime time.Time) (Proposal, error) {
-	p := Proposal{
-		ProposalId:       id,
-		Status:           StatusDepositPeriod,
-		FinalTallyResult: EmptyTallyResult(),
-		TotalDeposit:     sdk.NewCoins(),
-		SubmitTime:       submitTime,
-		DepositEndTime:   depositEndTime,
-	}
-
 	msg, ok := content.(proto.Message)
 	if !ok {
 		return Proposal{}, fmt.Errorf("%T does not implement proto.Message", content)
@@ -37,6 +28,15 @@ func NewProposal(content Content, id uint64, submitTime, depositEndTime time.Tim
 		return Proposal{}, err
 	}
 
+	p := Proposal{
+		ProposalId:       id,
+		Status:           StatusDepositPeriod,
+		FinalTallyResult: EmptyTallyResult(),
+		TotalDeposit:     sdk.NewCoins(),
+		SubmitTime:       submitTime,
+		DepositEndTime:   depositEndTime,
+	}
+
 	p.Content = any
 
 	return p, nil