From d2b7f56627a36479ec2b7bd8a2ccacf5818e49c2 Mon Sep 17 00:00:00 2001 From: sjtucoder Date: Thu, 13 Feb 2025 05:43:17 +0900 Subject: [PATCH] refactor: using slices.Contains to simplify the code (#23634) Signed-off-by: sjtucoder Co-authored-by: Alex | Interchain Labs --- x/circuit/keeper/msg_server.go | 7 +------ x/group/keeper/msg_server.go | 9 ++------- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/x/circuit/keeper/msg_server.go b/x/circuit/keeper/msg_server.go index ef1eda853d..52a45a3283 100644 --- a/x/circuit/keeper/msg_server.go +++ b/x/circuit/keeper/msg_server.go @@ -228,10 +228,5 @@ func (srv msgServer) ResetCircuitBreaker(ctx context.Context, msg *types.MsgRese // hasPermissionForMsg returns true if the account can trip or reset the message. func hasPermissionForMsg(perms types.Permissions, msg string) bool { - for _, msgurl := range perms.LimitTypeUrls { - if msg == msgurl { - return true - } - } - return false + return slices.Contains(perms.LimitTypeUrls, msg) } diff --git a/x/group/keeper/msg_server.go b/x/group/keeper/msg_server.go index 5191b2dc3b..ee431fe3e5 100644 --- a/x/group/keeper/msg_server.go +++ b/x/group/keeper/msg_server.go @@ -6,6 +6,7 @@ import ( "encoding/binary" "encoding/json" "fmt" + "slices" "strings" errorsmod "cosmossdk.io/errors" @@ -1140,13 +1141,7 @@ func (k Keeper) validateMembers(members []group.MemberRequest) error { // isProposer checks that an address is a proposer of a given proposal. func isProposer(proposal group.Proposal, address string) bool { - for _, proposer := range proposal.Proposers { - if proposer == address { - return true - } - } - - return false + return slices.Contains(proposal.Proposers, address) } func validateMsgs(msgs []sdk.Msg) error {