test: rename e2e tests (#13913)

2022-12-15 10:55:01 +01:00
parent fe34e5df32
commit ce167a2074
56 changed files with 451 additions and 455 deletions
@@ -10,11 +10,10 @@ import (

 	"cosmossdk.io/simapp"
 	"github.com/cosmos/cosmos-sdk/testutil/network"
-	clienttestutil "github.com/cosmos/cosmos-sdk/x/params/client/testutil"
 )

-func TestIntegrationTestSuite(t *testing.T) {
+func TestE2ETestSuite(t *testing.T) {
 	cfg := network.DefaultConfig(simapp.NewTestNetworkFixture)
 	cfg.NumValidators = 1
-	suite.Run(t, clienttestutil.NewIntegrationTestSuite(cfg))
+	suite.Run(t, NewE2ETestSuite(cfg))
 }
@@ -0,0 +1,85 @@
+package testutil
+
+import (
+	"fmt"
+
+	"github.com/cosmos/gogoproto/proto"
+
+	"github.com/cosmos/cosmos-sdk/testutil"
+	"github.com/cosmos/cosmos-sdk/x/params/types/proposal"
+)
+
+func (s *E2ETestSuite) TestQueryParamsGRPC() {
+	val := s.network.Validators[0]
+	baseURL := val.APIAddress
+
+	testCases := []struct {
+		name     string
+		url      string
+		headers  map[string]string
+		expErr   bool
+		respType proto.Message
+		expected proto.Message
+	}{
+		{
+			"with no subspace, key",
+			fmt.Sprintf("%s/cosmos/params/v1beta1/params?subspace=%s&key=%s", baseURL, "", ""),
+			map[string]string{},
+			true,
+			&proposal.QueryParamsResponse{},
+			nil,
+		},
+		{
+			"with wrong subspace",
+			fmt.Sprintf("%s/cosmos/params/v1beta1/params?subspace=%s&key=%s", baseURL, "wrongSubspace", "foo"),
+			map[string]string{},
+			true,
+			&proposal.QueryParamsResponse{},
+			nil,
+		},
+		{
+			"with wrong key",
+			fmt.Sprintf("%s/cosmos/params/v1beta1/params?subspace=%s&key=%s", baseURL, mySubspace, "wrongKey"),
+			map[string]string{},
+			false,
+			&proposal.QueryParamsResponse{},
+			&proposal.QueryParamsResponse{
+				Param: proposal.ParamChange{
+					Subspace: mySubspace,
+					Key:      "wrongKey",
+				},
+			},
+		},
+		{
+			"params",
+			fmt.Sprintf("%s/cosmos/params/v1beta1/params?subspace=%s&key=%s", baseURL, mySubspace, "bar"),
+			map[string]string{},
+			false,
+			&proposal.QueryParamsResponse{},
+			&proposal.QueryParamsResponse{
+				Param: proposal.ParamChange{
+					Subspace: mySubspace,
+					Key:      "bar",
+					Value:    `"1234"`,
+				},
+			},
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+		s.Run(tc.name, func() {
+			resp, err := testutil.GetRequestWithHeaders(tc.url, tc.headers)
+			s.Require().NoError(err)
+
+			err = val.ClientCtx.Codec.UnmarshalJSON(resp, tc.respType)
+
+			if tc.expErr {
+				s.Require().Error(err)
+			} else {
+				s.Require().NoError(err)
+				s.Require().Equal(tc.expected.String(), tc.respType.String())
+			}
+		})
+	}
+}
@@ -0,0 +1,143 @@
+package testutil
+
+import (
+	"fmt"
+	"strings"
+
+	"github.com/stretchr/testify/suite"
+	abci "github.com/tendermint/tendermint/abci/types"
+	dbm "github.com/tendermint/tm-db"
+
+	"cosmossdk.io/depinject"
+	"github.com/cosmos/cosmos-sdk/baseapp"
+	"github.com/cosmos/cosmos-sdk/client/flags"
+	"github.com/cosmos/cosmos-sdk/runtime"
+	servertypes "github.com/cosmos/cosmos-sdk/server/types"
+	pruningtypes "github.com/cosmos/cosmos-sdk/store/pruning/types"
+	clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
+	"github.com/cosmos/cosmos-sdk/testutil/network"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/params/client/cli"
+	"github.com/cosmos/cosmos-sdk/x/params/keeper"
+	"github.com/cosmos/cosmos-sdk/x/params/testutil"
+	paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
+)
+
+// mySubspace is a x/params subspace created for the purpose of this
+// test suite.
+const mySubspace = "foo"
+
+// myParams defines some params in the `mySubspace` subspace.
+type myParams struct{}
+
+func (p *myParams) ParamSetPairs() paramtypes.ParamSetPairs {
+	return paramtypes.ParamSetPairs{
+		paramtypes.NewParamSetPair([]byte("bar"), 1234, func(value interface{}) error { return nil }),
+	}
+}
+
+type E2ETestSuite struct {
+	suite.Suite
+
+	cfg     network.Config
+	network *network.Network
+}
+
+func NewE2ETestSuite(cfg network.Config) *E2ETestSuite {
+	return &E2ETestSuite{cfg: cfg}
+}
+
+func (s *E2ETestSuite) SetupSuite() {
+	s.T().Log("setting up e2e test suite")
+
+	// Create a new AppConstructor for this test suite, where we manually
+	// add a subspace and `myParams` to the x/params store.
+	s.cfg.AppConstructor = func(val network.ValidatorI) servertypes.Application {
+		var (
+			appBuilder   *runtime.AppBuilder
+			paramsKeeper keeper.Keeper
+		)
+		if err := depinject.Inject(testutil.AppConfig, &appBuilder, &paramsKeeper); err != nil {
+			panic(err)
+		}
+
+		// Add this test's `myParams` to the x/params store.
+		paramSet := myParams{}
+		subspace := paramsKeeper.Subspace(mySubspace).WithKeyTable(paramtypes.NewKeyTable().RegisterParamSet(&paramSet))
+
+		app := appBuilder.Build(
+			val.GetCtx().Logger,
+			dbm.NewMemDB(),
+			nil,
+			baseapp.SetPruning(pruningtypes.NewPruningOptionsFromString(val.GetAppConfig().Pruning)),
+			baseapp.SetMinGasPrices(val.GetAppConfig().MinGasPrices),
+		)
+
+		s.Require().NoError(app.Load(false))
+
+		// Make sure not to forget to persist `myParams` into the actual store,
+		// this is done in InitChain.
+		app.SetInitChainer(func(ctx sdk.Context, req abci.RequestInitChain) abci.ResponseInitChain {
+			subspace.SetParamSet(ctx, &paramSet)
+
+			return app.InitChainer(ctx, req)
+		})
+
+		s.Require().NoError(app.LoadLatestVersion())
+
+		return app
+	}
+
+	var err error
+	s.network, err = network.New(s.T(), s.T().TempDir(), s.cfg)
+	s.Require().NoError(err)
+
+	s.Require().NoError(s.network.WaitForNextBlock())
+}
+
+func (s *E2ETestSuite) TearDownSuite() {
+	s.T().Log("tearing down e2e test suite")
+	s.network.Cleanup()
+}
+
+func (s *E2ETestSuite) TestNewQuerySubspaceParamsCmd() {
+	val := s.network.Validators[0]
+
+	testCases := []struct {
+		name           string
+		args           []string
+		expectedOutput string
+	}{
+		{
+			"json output",
+			[]string{
+				"foo", "bar",
+				fmt.Sprintf("--%s=json", flags.FlagOutput),
+			},
+			`{"subspace":"foo","key":"bar","value":"\"1234\""}`,
+		},
+		{
+			"text output",
+			[]string{
+				"foo", "bar",
+				fmt.Sprintf("--%s=text", flags.FlagOutput),
+			},
+			`key: bar
+subspace: foo
+value: '"1234"'`,
+		},
+	}
+
+	for _, tc := range testCases {
+		tc := tc
+
+		s.Run(tc.name, func() {
+			cmd := cli.NewQuerySubspaceParamsCmd()
+			clientCtx := val.ClientCtx
+
+			out, err := clitestutil.ExecTestCLICmd(clientCtx, cmd, tc.args)
+			s.Require().NoError(err)
+			s.Require().Equal(tc.expectedOutput, strings.TrimSpace(out.String()))
+		})
+	}
+}