chore: bump golangci-lint and fix all linting issues (#21761)

x/group/internal/orm/auto_uint64_test.go

@@ -48,7 +48,6 @@ func TestAutoUInt64PrefixScan(t *testing.T) {
 		Metadata: metadata,
 	}
 	for _, g := range []testdata.TableModel{t1, t2, t3} {
-		g := g
 		_, err := tb.Create(store, &g)
 		require.NoError(t, err)
 	}

x/group/internal/orm/index_test.go

@@ -125,7 +125,6 @@ func TestIndexPrefixScan(t *testing.T) {
 		Metadata: []byte("metadata-b"),
 	}
 	for _, g := range []testdata.TableModel{g1, g2, g3} {
-		g := g
 		_, err := tb.Create(store, &g)
 		require.NoError(t, err)
 	}

x/group/internal/orm/iterator.go

@@ -298,7 +298,7 @@ func assertDest(dest ModelSlicePtr, destRef, tmpSlice *reflect.Value) (reflect.T
 
 	protoMarshaler := reflect.TypeOf((*proto.Message)(nil)).Elem()
 	if !elemType.Implements(protoMarshaler) &&
-		!reflect.PtrTo(elemType).Implements(protoMarshaler) {
+		!reflect.PointerTo(elemType).Implements(protoMarshaler) {
 		return nil, errorsmod.Wrapf(grouperrors.ErrORMInvalidArgument, "unsupported type :%s", elemType)
 	}
 

x/group/internal/orm/iterator_test.go

@@ -244,7 +244,6 @@ func TestPaginate(t *testing.T) {
 	}
 
 	for _, g := range []testdata.TableModel{t1, t2, t3, t4, t5} {
-		g := g
 		_, err := tb.Create(store, &g)
 		require.NoError(t, err)
 	}

x/group/internal/orm/orm_scenario_test.go

@@ -281,7 +281,6 @@ func TestGasCostsPrimaryKeyTable(t *testing.T) {
 	for i, m := range tms {
 		testCtx.Ctx = testCtx.Ctx.WithGasMeter(storetypes.NewInfiniteGasMeter())
 
-		m := m
 		err = k.primaryKeyTable.Delete(store, &m)
 
 		require.NoError(t, err)

x/group/internal/orm/primary_key_test.go

@@ -48,7 +48,6 @@ func TestPrimaryKeyTablePrefixScan(t *testing.T) {
 		Metadata: metadata,
 	}
 	for _, g := range []testdata.TableModel{t1, t2, t3} {
-		g := g
 		require.NoError(t, tb.Create(store, &g))
 	}