chore: bump golangci-lint and fix all linting issues (#21761)

x/gov/client/cli/prompt_test.go

@@ -72,7 +72,6 @@ func TestPromptParseInteger(t *testing.T) {
 	}
 
 	for _, tc := range values {
-		tc := tc
 		t.Run(tc.in, func(t *testing.T) {
 			origStdin := readline.Stdin
 			defer func() {

x/gov/client/cli/tx_test.go

@@ -160,8 +160,6 @@ func (s *CLITestSuite) TestNewCmdSubmitProposal() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.NewCmdSubmitProposal()
 
@@ -256,8 +254,6 @@ func (s *CLITestSuite) TestNewCmdSubmitLegacyProposal() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.NewCmdSubmitLegacyProposal()
 
@@ -360,7 +356,6 @@ func (s *CLITestSuite) TestNewCmdWeightedVote() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.NewCmdWeightedVote()
 			out, err := clitestutil.ExecTestCLICmd(s.clientCtx, cmd, tc.args)

x/gov/client/utils/query_test.go

@@ -193,8 +193,6 @@ func TestGetPaginatedVotes(t *testing.T) {
 			},
 		},
 	} {
-		tc := tc
-
 		t.Run(tc.description, func(t *testing.T) {
 			marshaled := make([][]byte, len(tc.msgs))
 			clientCtx := client.Context{}.
@@ -298,8 +296,6 @@ func TestGetSingleVote(t *testing.T) {
 			},
 		},
 	} {
-		tc := tc
-
 		t.Run(tc.description, func(t *testing.T) {
 			marshaled := make([][]byte, len(tc.msgs))
 			clientCtx := client.Context{}.