From caf76300c072b5802ce98c9fb3e881324367b9d4 Mon Sep 17 00:00:00 2001
From: emidev98 <49301655+emidev98@users.noreply.github.com>
Date: Sun, 12 Nov 2023 17:28:08 +0200
Subject: [PATCH] chore(x/gov): clean validation code (#18449)

---
 x/gov/keeper/keeper.go | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/x/gov/keeper/keeper.go b/x/gov/keeper/keeper.go
index 536187c694..97f5a3d4bc 100644
--- a/x/gov/keeper/keeper.go
+++ b/x/gov/keeper/keeper.go
@@ -193,22 +193,22 @@ func (k Keeper) ModuleAccountAddress() sdk.AccAddress {
 // validateProposalLengths checks message metadata, summary and title
 // to have the expected length otherwise returns an error.
 func (k Keeper) validateProposalLengths(metadata, title, summary string) error {
-    if err := k.assertMetadataLength(metadata); err != nil {
-        return err
-    }
-    if err := k.assertSummaryLength(summary); err != nil {
-        return err
-    }
-    if err := k.assertTitleLength(title); err != nil {
-        return err
-    }
-    return nil
+	if err := k.assertMetadataLength(metadata); err != nil {
+		return err
+	}
+	if err := k.assertSummaryLength(summary); err != nil {
+		return err
+	}
+	if err := k.assertTitleLength(title); err != nil {
+		return err
+	}
+	return nil
 }
 
 // assertTitleLength returns an error if given title length
 // is greater than a pre-defined MaxTitleLen.
 func (k Keeper) assertTitleLength(title string) error {
-	if title != "" && uint64(len(title)) > k.config.MaxTitleLen {
+	if uint64(len(title)) > k.config.MaxTitleLen {
 		return types.ErrTitleTooLong.Wrapf("got title with length %d", len(title))
 	}
 	return nil
@@ -217,7 +217,7 @@ func (k Keeper) assertTitleLength(title string) error {
 // assertMetadataLength returns an error if given metadata length
 // is greater than a pre-defined MaxMetadataLen.
 func (k Keeper) assertMetadataLength(metadata string) error {
-	if metadata != "" && uint64(len(metadata)) > k.config.MaxMetadataLen {
+	if uint64(len(metadata)) > k.config.MaxMetadataLen {
 		return types.ErrMetadataTooLong.Wrapf("got metadata with length %d", len(metadata))
 	}
 	return nil
@@ -226,7 +226,7 @@ func (k Keeper) assertMetadataLength(metadata string) error {
 // assertSummaryLength returns an error if given summary length
 // is greater than a pre-defined MaxSummaryLen.
 func (k Keeper) assertSummaryLength(summary string) error {
-	if summary != "" && uint64(len(summary)) > k.config.MaxSummaryLen {
+	if uint64(len(summary)) > k.config.MaxSummaryLen {
 		return types.ErrSummaryTooLong.Wrapf("got summary with length %d", len(summary))
 	}
 	return nil