Merge PR #4847: Sim refactor 1 move store decoders to modules

* move store decoders to modules

* fix

* module pattern

* compile

* update Decoders params

* fix

* address @colin-axner comments

* Update cmd_test.go

* simulation manager

* mino fixes

* cleanup

* Apply suggestions from code review

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

* address @rigelrozanski comments

* changelog

* Apply suggestions from code review

Co-Authored-By: colin axner <colinaxner@berkeley.edu>

* restructure modules simulation pkgs

* address @alexanderbez comments

* fix

x/slashing/simulation/decoder.go

@@ -0,0 +1,41 @@
+package simulation
+
+import (
+	"bytes"
+	"fmt"
+
+	"github.com/tendermint/tendermint/crypto"
+	cmn "github.com/tendermint/tendermint/libs/common"
+
+	"github.com/cosmos/cosmos-sdk/codec"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/slashing/internal/types"
+)
+
+// DecodeStore unmarshals the KVPair's Value to the corresponding slashing type
+func DecodeStore(cdc *codec.Codec, kvA, kvB cmn.KVPair) string {
+	switch {
+	case bytes.Equal(kvA.Key[:1], types.ValidatorSigningInfoKey):
+		var infoA, infoB types.ValidatorSigningInfo
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvA.Value, &infoA)
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvB.Value, &infoB)
+		return fmt.Sprintf("%v\n%v", infoA, infoB)
+
+	case bytes.Equal(kvA.Key[:1], types.ValidatorMissedBlockBitArrayKey):
+		var missedA, missedB bool
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvA.Value, &missedA)
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvB.Value, &missedB)
+		return fmt.Sprintf("missedA: %v\nmissedB: %v", missedA, missedB)
+
+	case bytes.Equal(kvA.Key[:1], types.AddrPubkeyRelationKey):
+		var pubKeyA, pubKeyB crypto.PubKey
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvA.Value, &pubKeyA)
+		cdc.MustUnmarshalBinaryLengthPrefixed(kvB.Value, &pubKeyB)
+		bechPKA := sdk.MustBech32ifyAccPub(pubKeyA)
+		bechPKB := sdk.MustBech32ifyAccPub(pubKeyB)
+		return fmt.Sprintf("PubKeyA: %s\nPubKeyB: %s", bechPKA, bechPKB)
+
+	default:
+		panic(fmt.Sprintf("invalid slashing key prefix %X", kvA.Key[:1]))
+	}
+}

x/slashing/simulation/decoder_test.go

@@ -0,0 +1,66 @@
+package simulation
+
+import (
+	"fmt"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/tendermint/tendermint/crypto/ed25519"
+	cmn "github.com/tendermint/tendermint/libs/common"
+
+	"github.com/cosmos/cosmos-sdk/codec"
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/cosmos/cosmos-sdk/x/slashing/internal/types"
+)
+
+var (
+	delPk1    = ed25519.GenPrivKey().PubKey()
+	delAddr1  = sdk.AccAddress(delPk1.Address())
+	valAddr1  = sdk.ValAddress(delPk1.Address())
+	consAddr1 = sdk.ConsAddress(delPk1.Address().Bytes())
+)
+
+func makeTestCodec() (cdc *codec.Codec) {
+	cdc = codec.New()
+	sdk.RegisterCodec(cdc)
+	codec.RegisterCrypto(cdc)
+	types.RegisterCodec(cdc)
+	return
+}
+
+func TestDecodeStore(t *testing.T) {
+	cdc := makeTestCodec()
+
+	info := types.NewValidatorSigningInfo(consAddr1, 0, 1, time.Now().UTC(), false, 0)
+	bechPK := sdk.MustBech32ifyAccPub(delPk1)
+	missed := true
+
+	kvPairs := cmn.KVPairs{
+		cmn.KVPair{Key: types.GetValidatorSigningInfoKey(consAddr1), Value: cdc.MustMarshalBinaryLengthPrefixed(info)},
+		cmn.KVPair{Key: types.GetValidatorMissedBlockBitArrayKey(consAddr1, 6), Value: cdc.MustMarshalBinaryLengthPrefixed(missed)},
+		cmn.KVPair{Key: types.GetAddrPubkeyRelationKey(delAddr1), Value: cdc.MustMarshalBinaryLengthPrefixed(delPk1)},
+		cmn.KVPair{Key: []byte{0x99}, Value: []byte{0x99}},
+	}
+
+	tests := []struct {
+		name        string
+		expectedLog string
+	}{
+		{"ValidatorSigningInfo", fmt.Sprintf("%v\n%v", info, info)},
+		{"ValidatorMissedBlockBitArray", fmt.Sprintf("missedA: %v\nmissedB: %v", missed, missed)},
+		{"AddrPubkeyRelation", fmt.Sprintf("PubKeyA: %s\nPubKeyB: %s", bechPK, bechPK)},
+		{"other", ""},
+	}
+	for i, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			switch i {
+			case len(tests) - 1:
+				require.Panics(t, func() { DecodeStore(cdc, kvPairs[i], kvPairs[i]) }, tt.name)
+			default:
+				require.Equal(t, tt.expectedLog, DecodeStore(cdc, kvPairs[i], kvPairs[i]), tt.name)
+			}
+		})
+	}
+}

x/slashing/simulation/operations/msgs.go

@@ -1,4 +1,4 @@
-package simulation
+package operations
 
 import (
 	"fmt"