Merge PR #4847: Sim refactor 1 move store decoders to modules

* move store decoders to modules

* fix

* module pattern

* compile

* update Decoders params

* fix

* address @colin-axner comments

* Update cmd_test.go

* simulation manager

* mino fixes

* cleanup

* Apply suggestions from code review

Co-Authored-By: frog power 4000 <rigel.rozanski@gmail.com>

* address @rigelrozanski comments

* changelog

* Apply suggestions from code review

Co-Authored-By: colin axner <colinaxner@berkeley.edu>

* restructure modules simulation pkgs

* address @alexanderbez comments

* fix

store/types/utils.go

@@ -18,7 +18,7 @@ func KVStoreReversePrefixIterator(kvs KVStore, prefix []byte) Iterator {
 
 // DiffKVStores compares two KVstores and returns all the key/value pairs
 // that differ from one another. It also skips value comparison for a set of provided prefixes
-func DiffKVStores(a KVStore, b KVStore, prefixesToSkip [][]byte) (kvs []cmn.KVPair) {
+func DiffKVStores(a KVStore, b KVStore, prefixesToSkip [][]byte) (kvAs, kvBs []cmn.KVPair) {
 	iterA := a.Iterator(nil, nil)
 	iterB := b.Iterator(nil, nil)
 
@@ -36,7 +36,8 @@ func DiffKVStores(a KVStore, b KVStore, prefixesToSkip [][]byte) (kvs []cmn.KVPa
 			iterB.Next()
 		}
 		if !bytes.Equal(kvA.Key, kvB.Key) {
-			kvs = append(kvs, []cmn.KVPair{kvA, kvB}...)
+			kvAs = append(kvAs, kvA)
+			kvBs = append(kvBs, kvB)
 		}
 		compareValue := true
 		for _, prefix := range prefixesToSkip {
@@ -46,7 +47,8 @@ func DiffKVStores(a KVStore, b KVStore, prefixesToSkip [][]byte) (kvs []cmn.KVPa
 			}
 		}
 		if compareValue && !bytes.Equal(kvA.Value, kvB.Value) {
-			kvs = append(kvs, []cmn.KVPair{kvA, kvB}...)
+			kvAs = append(kvAs, kvA)
+			kvBs = append(kvBs, kvB)
 		}
 	}
 	return