sort *all* GetSignBytes:

- call MustSortJSON before return JSON bytes to guarantee alphabetic
ordering

- moved SortJSON and MustSortJSON to types package to avoid cyclic
package dep
This commit is contained in:
Liamsi
2018-07-06 01:12:57 +01:00
parent 0f1ceb073e
commit b7f902fba5
20 changed files with 100 additions and 143 deletions
+1 -6
View File
@@ -3,7 +3,6 @@ package auth
import (
"encoding/json"
"github.com/cosmos/cosmos-sdk/server"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/tendermint/tendermint/crypto"
)
@@ -142,11 +141,7 @@ func StdSignBytes(chainID string, accnum int64, sequence int64, fee StdFee, msgs
if err != nil {
panic(err)
}
bz, err = server.SortJSON(bz)
if err != nil {
panic(err)
}
return bz
return sdk.MustSortJSON(bz)
}
// StdSignMsg is a convenience structure for passing along