LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

update msg vote validate basic and test

Browse Source
This commit is contained in:
antstalepresh 2020-10-29 22:43:08 +10:00
parent fe0d0a5045
commit b3d86e1a8d
2 changed files with 16 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
x/gov/types/msgs.go
View File

@ -192,6 +192,11 @@ func (msg MsgVote) ValidateBasic() error {
if msg.Voter == "" {
return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, msg.Voter)
}
if len(msg.SubVotes) == 0 {
return sdkerrors.Wrap(sdkerrors.ErrInvalidRequest, SubVotes(msg.SubVotes).String())
}
for _, subvote := range msg.SubVotes {
if !ValidSubVote(subvote) {
return sdkerrors.Wrap(ErrInvalidVote, subvote.String())

19
x/gov/types/msgs_test.go
View File

@ -97,19 +97,22 @@ func TestMsgVote(t *testing.T) {
tests := []struct {
proposalID uint64
voterAddr sdk.AccAddress
option VoteOption
subvotes SubVotes
expectPass bool
}{
{0, addrs[0], OptionYes, true},
{0, sdk.AccAddress{}, OptionYes, false},
{0, addrs[0], OptionNo, true},
{0, addrs[0], OptionNoWithVeto, true},
{0, addrs[0], OptionAbstain, true},
{0, addrs[0], VoteOption(0x13), false},
{0, addrs[0], SubVotes{NewSubVote(OptionYes, 1)}, true},
{0, sdk.AccAddress{}, SubVotes{NewSubVote(OptionYes, 1)}, false},
{0, addrs[0], SubVotes{NewSubVote(OptionNo, 1)}, true},
{0, addrs[0], SubVotes{NewSubVote(OptionNoWithVeto, 1)}, true},
{0, addrs[0], SubVotes{NewSubVote(OptionAbstain, 1)}, true},
{0, addrs[0], SubVotes{NewSubVote(OptionYes, 1), NewSubVote(OptionAbstain, 1)}, true},
{0, addrs[0], SubVotes{NewSubVote(OptionYes, 0)}, false},
{0, addrs[0], SubVotes{}, false},
{0, addrs[0], SubVotes{NewSubVote(VoteOption(0x13), 1)}, false},
}
for i, tc := range tests {
msg := NewMsgVote(tc.voterAddr, tc.proposalID, SubVotes{NewSubVote(tc.option, 1)})
msg := NewMsgVote(tc.voterAddr, tc.proposalID, tc.subvotes)
if tc.expectPass {
require.Nil(t, msg.ValidateBasic(), "test: %v", i)
} else {