LaconicNetwork/cosmos-sdk
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix(hubl): malformed msgName and error handling (#16601)

Browse Source 
Co-authored-by: Julien Robert <julien@rbrt.fr>
This commit is contained in:
Carlos Santiago Yanzon 2023-06-20 11:43:38 -03:00 committed by GitHub
parent d4f1e88b65
commit abae2567cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/hubl/internal/compat.go
View File

@ -30,7 +30,7 @@ func loadFileDescriptorsGRPCReflection(ctx context.Context, client *grpc.ClientC
InterfaceName: iface,
})
if err == nil {
interfaceImplNames = append(interfaceImplNames, implRes.ImplementationMessageNames...)
interfaceImplNames = append(interfaceImplNames, implMsgNameCleanup(implRes.ImplementationMessageNames)...)
}
}
}
@ -56,6 +56,8 @@ func loadFileDescriptorsGRPCReflection(ctx context.Context, client *grpc.ClientC
}
switch res := in.MessageResponse.(type) {
case *grpc_reflection_v1alpha.ServerReflectionResponse_ErrorResponse:
panic(err)
case *grpc_reflection_v1alpha.ServerReflectionResponse_ListServicesResponse:
waitListServiceRes <- res.ListServicesResponse //nolint:staticcheck // SA1019: we want to keep using v1alpha
case *grpc_reflection_v1alpha.ServerReflectionResponse_FileDescriptorResponse:
@ -261,6 +263,19 @@ func guessAutocli(files *protoregistry.Files) *autocliv1.AppOptionsResponse {
return &autocliv1.AppOptionsResponse{ModuleOptions: res}
}
// Removes the first character "/" from the received name
func implMsgNameCleanup(implMessages []string) (cleanImplMessages []string) {
for _, implMessage := range implMessages {
if len(implMessage) >= 1 && implMessage[0] == '/' {
cleanImplMessages = append(cleanImplMessages, implMessage[1:])
} else {
cleanImplMessages = append(cleanImplMessages, implMessage)
}
}
return cleanImplMessages
}
var defaultAutocliMappings = map[protoreflect.FullName]string{
"cosmos.auth.v1beta1.Query": "auth query",
"cosmos.authz.v1beta1.Query": "authz query",