From aa8bf41eb94d073c834718cda24b6be23943a52a Mon Sep 17 00:00:00 2001 From: auricom <27022259+auricom@users.noreply.github.com> Date: Wed, 11 Sep 2024 14:30:19 +0200 Subject: [PATCH] ci: rocksdb version in makefile (#21654) --- .github/scripts/get-rocksdb-version.sh | 12 ++++++++++++ .github/scripts/install-rocksdb.sh | 2 +- .github/workflows/build.yml | 5 ++--- .github/workflows/lint.yml | 5 ++--- .github/workflows/test.yml | 6 ++++-- scripts/build/build.mk | 2 ++ 6 files changed, 23 insertions(+), 9 deletions(-) create mode 100755 .github/scripts/get-rocksdb-version.sh diff --git a/.github/scripts/get-rocksdb-version.sh b/.github/scripts/get-rocksdb-version.sh new file mode 100755 index 0000000000..7f72b96911 --- /dev/null +++ b/.github/scripts/get-rocksdb-version.sh @@ -0,0 +1,12 @@ +#!/usr/bin/env bash +set -Eeuo pipefail + +# Search for rocksdb_version in makefile +rocksdb_version=$(grep "rocksdb_version" ./scripts/build/build.mk | cut -d'=' -f2) + +if [[ -z "${rocksdb_version}" ]]; then + echo "Error: rocksdb_version not found in ./scripts/build/build.mk" >&2 + exit 1 +else + echo "ROCKSDB_VERSION=${rocksdb_version}" >> "${GITHUB_ENV}" +fi \ No newline at end of file diff --git a/.github/scripts/install-rocksdb.sh b/.github/scripts/install-rocksdb.sh index 8579431bfc..00829abeef 100755 --- a/.github/scripts/install-rocksdb.sh +++ b/.github/scripts/install-rocksdb.sh @@ -12,7 +12,7 @@ sudo apt update && sudo apt-get install -y libsnappy-dev zlib1g-dev libbz2-dev l # Clone RocksDB repository git clone https://github.com/facebook/rocksdb.git /home/runner/rocksdb cd /home/runner/rocksdb || exit 1 -git checkout "v${ROCKSDB_VERSION}" +git checkout "${ROCKSDB_VERSION}" # Build shared library sudo make -j "$(nproc --all)" shared_lib diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3239b74606..b5da647b06 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -13,9 +13,6 @@ concurrency: group: ci-${{ github.ref }}-build cancel-in-progress: true -env: - ROCKSDB_VERSION: 8.11.3 - jobs: build: runs-on: ubuntu-latest @@ -28,6 +25,8 @@ jobs: with: go-version: "1.23" check-latest: true + - name: Get rocksdb version + run: ./.github/scripts/get-rocksdb-version.sh - name: Fix permissions for cache run: sudo chown $(whoami) /usr/local/lib /usr/local/include - name: Restore rocksdb libraries cache diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2995ea9a32..d1e43afeb8 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,9 +9,6 @@ on: permissions: contents: read -env: - ROCKSDB_VERSION: 8.11.3 - jobs: golangci: name: golangci-lint @@ -30,6 +27,8 @@ jobs: Makefile **/Makefile .golangci.yml + - name: Get rocksdb version + run: ./.github/scripts/get-rocksdb-version.sh - name: Fix permissions for cache run: sudo chown $(whoami) /usr/local/lib /usr/local/include - name: Restore rocksdb libraries cache diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 563df8a185..9264cad238 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -13,8 +13,6 @@ concurrency: group: ci-${{ github.ref }}-tests cancel-in-progress: true -env: - ROCKSDB_VERSION: 8.11.3 jobs: split-test-files: @@ -790,6 +788,8 @@ jobs: store/**/*.go store/go.mod store/go.sum + - name: Get rocksdb version + run: ./.github/scripts/get-rocksdb-version.sh - name: Fix permissions for cache run: sudo chown $(whoami) /usr/local/lib /usr/local/include - name: Restore rocksdb libraries cache @@ -848,6 +848,8 @@ jobs: store/v2/**/*.go store/v2/go.mod store/v2/go.sum + - name: Get rocksdb version + run: ./.github/scripts/get-rocksdb-version.sh - name: Fix permissions for cache run: sudo chown $(whoami) /usr/local/lib /usr/local/include - name: Restore rocksdb libraries cache diff --git a/scripts/build/build.mk b/scripts/build/build.mk index 1fb1908d75..8bad1e1811 100644 --- a/scripts/build/build.mk +++ b/scripts/build/build.mk @@ -12,6 +12,8 @@ HTTPS_GIT := https://github.com/cosmos/cosmos-sdk.git DOCKER := $(shell which docker) PROJECT_NAME = $(shell git remote get-url origin | xargs basename -s .git) +rocksdb_version=v8.11.3 + ifeq ($(findstring .,$(VERSION)),) VERSION := 0.0.0 endif