From a6589949fb87f27728e478b5bd665d3807c54d5c Mon Sep 17 00:00:00 2001 From: Christopher Goes Date: Tue, 1 May 2018 00:19:28 +0200 Subject: [PATCH] Remove unnecessary code --- baseapp/baseapp_test.go | 13 ++++++------- examples/democoin/x/simplestake/msgs.go | 5 ++--- examples/kvstore/tx.go | 13 ------------- mock/tx.go | 13 ------------- types/tx_msg.go | 3 +-- 5 files changed, 9 insertions(+), 38 deletions(-) diff --git a/baseapp/baseapp_test.go b/baseapp/baseapp_test.go index fe061622c2..aab64fc200 100644 --- a/baseapp/baseapp_test.go +++ b/baseapp/baseapp_test.go @@ -318,13 +318,12 @@ type testUpdatePowerTx struct { const msgType = "testUpdatePowerTx" -func (tx testUpdatePowerTx) Type() string { return msgType } -func (tx testUpdatePowerTx) Get(key interface{}) (value interface{}) { return nil } -func (tx testUpdatePowerTx) GetMsg() sdk.Msg { return tx } -func (tx testUpdatePowerTx) GetSignBytes() []byte { return nil } -func (tx testUpdatePowerTx) ValidateBasic() sdk.Error { return nil } -func (tx testUpdatePowerTx) GetSigners() []sdk.Address { return nil } -func (tx testUpdatePowerTx) GetSignatures() []sdk.StdSignature { return nil } +func (tx testUpdatePowerTx) Type() string { return msgType } +func (tx testUpdatePowerTx) GetMsg() sdk.Msg { return tx } +func (tx testUpdatePowerTx) GetSignBytes() []byte { return nil } +func (tx testUpdatePowerTx) ValidateBasic() sdk.Error { return nil } +func (tx testUpdatePowerTx) GetSigners() []sdk.Address { return nil } +func (tx testUpdatePowerTx) GetSignatures() []sdk.StdSignature { return nil } func TestValidatorChange(t *testing.T) { diff --git a/examples/democoin/x/simplestake/msgs.go b/examples/democoin/x/simplestake/msgs.go index 0a77070035..01797a65bf 100644 --- a/examples/democoin/x/simplestake/msgs.go +++ b/examples/democoin/x/simplestake/msgs.go @@ -26,9 +26,8 @@ func NewMsgBond(addr sdk.Address, stake sdk.Coin, pubKey crypto.PubKey) MsgBond } //nolint -func (msg MsgBond) Type() string { return moduleName } //TODO update "stake/declarecandidacy" -func (msg MsgBond) Get(key interface{}) (value interface{}) { return nil } -func (msg MsgBond) GetSigners() []sdk.Address { return []sdk.Address{msg.Address} } +func (msg MsgBond) Type() string { return moduleName } //TODO update "stake/declarecandidacy" +func (msg MsgBond) GetSigners() []sdk.Address { return []sdk.Address{msg.Address} } // basic validation of the bond message func (msg MsgBond) ValidateBasic() sdk.Error { diff --git a/examples/kvstore/tx.go b/examples/kvstore/tx.go index c084925b76..12bce0736f 100644 --- a/examples/kvstore/tx.go +++ b/examples/kvstore/tx.go @@ -13,19 +13,6 @@ type kvstoreTx struct { bytes []byte } -func (tx kvstoreTx) Get(key interface{}) (value interface{}) { - switch k := key.(type) { - case string: - switch k { - case "key": - return tx.key - case "value": - return tx.value - } - } - return nil -} - func (tx kvstoreTx) Type() string { return "kvstore" } diff --git a/mock/tx.go b/mock/tx.go index cc79b1172a..81dea45718 100644 --- a/mock/tx.go +++ b/mock/tx.go @@ -26,19 +26,6 @@ func NewTx(key, value string) kvstoreTx { } } -func (tx kvstoreTx) Get(key interface{}) (value interface{}) { - switch k := key.(type) { - case string: - switch k { - case "key": - return tx.key - case "value": - return tx.value - } - } - return nil -} - func (tx kvstoreTx) Type() string { return "kvstore" } diff --git a/types/tx_msg.go b/types/tx_msg.go index 7ac7b9bb26..c3a22b60fb 100644 --- a/types/tx_msg.go +++ b/types/tx_msg.go @@ -171,8 +171,7 @@ func NewTestMsg(addrs ...Address) *TestMsg { } //nolint -func (msg *TestMsg) Type() string { return "TestMsg" } -func (msg *TestMsg) Get(key interface{}) (value interface{}) { return nil } +func (msg *TestMsg) Type() string { return "TestMsg" } func (msg *TestMsg) GetSignBytes() []byte { bz, err := json.Marshal(msg.signers) if err != nil {