diff --git a/client/cmd.go b/client/cmd.go index b8ff6711d7..eccf59c351 100644 --- a/client/cmd.go +++ b/client/cmd.go @@ -146,7 +146,7 @@ func ReadPersistentCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Cont return clientCtx, nil } -// ReadQueryCommandFlags returns an updated Context with fields set based on flags +// readQueryCommandFlags returns an updated Context with fields set based on flags // defined in AddQueryFlagsToCmd. An error is returned if any flag query fails. // // Note, the provided clientCtx may have field pre-populated. The following order @@ -156,7 +156,7 @@ func ReadPersistentCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Cont // - client.Context field not pre-populated & flag set: uses set flag value // - client.Context field pre-populated & flag not set: uses pre-populated value // - client.Context field pre-populated & flag set: uses set flag value -func ReadQueryCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, error) { +func readQueryCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, error) { if clientCtx.Height == 0 || flagSet.Changed(flags.FlagHeight) { height, _ := flagSet.GetInt64(flags.FlagHeight) clientCtx = clientCtx.WithHeight(height) @@ -170,7 +170,7 @@ func ReadQueryCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, return ReadPersistentCommandFlags(clientCtx, flagSet) } -// ReadTxCommandFlags returns an updated Context with fields set based on flags +// readTxCommandFlags returns an updated Context with fields set based on flags // defined in AddTxFlagsToCmd. An error is returned if any flag query fails. // // Note, the provided clientCtx may have field pre-populated. The following order @@ -180,7 +180,7 @@ func ReadQueryCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, // - client.Context field not pre-populated & flag set: uses set flag value // - client.Context field pre-populated & flag not set: uses pre-populated value // - client.Context field pre-populated & flag set: uses set flag value -func ReadTxCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, error) { +func readTxCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, error) { clientCtx, err := ReadPersistentCommandFlags(clientCtx, flagSet) if err != nil { return clientCtx, err @@ -242,6 +242,30 @@ func ReadTxCommandFlags(clientCtx Context, flagSet *pflag.FlagSet) (Context, err return clientCtx, nil } +// GetClientQueryContext returns a Context from a command with fields set based on flags +// defined in AddQueryFlagsToCmd. An error is returned if any flag query fails. +// +// - client.Context field not pre-populated & flag not set: uses default flag value +// - client.Context field not pre-populated & flag set: uses set flag value +// - client.Context field pre-populated & flag not set: uses pre-populated value +// - client.Context field pre-populated & flag set: uses set flag value +func GetClientQueryContext(cmd *cobra.Command) (Context, error) { + ctx := GetClientContextFromCmd(cmd) + return readQueryCommandFlags(ctx, cmd.Flags()) +} + +// GetClientTxContext returns a Context from a command with fields set based on flags +// defined in AddTxFlagsToCmd. An error is returned if any flag query fails. +// +// - client.Context field not pre-populated & flag not set: uses default flag value +// - client.Context field not pre-populated & flag set: uses set flag value +// - client.Context field pre-populated & flag not set: uses pre-populated value +// - client.Context field pre-populated & flag set: uses set flag value +func GetClientTxContext(cmd *cobra.Command) (Context, error) { + ctx := GetClientContextFromCmd(cmd) + return readTxCommandFlags(ctx, cmd.Flags()) +} + // GetClientContextFromCmd returns a Context from a command or an empty Context // if it has not been set. func GetClientContextFromCmd(cmd *cobra.Command) Context { diff --git a/client/cmd_test.go b/client/cmd_test.go index c4c8fd4da3..02e2c414f6 100644 --- a/client/cmd_test.go +++ b/client/cmd_test.go @@ -64,13 +64,8 @@ func TestSetCmdClientContextHandler(t *testing.T) { return client.SetCmdClientContextHandler(initClientCtx, cmd) }, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - _, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) - if err != nil { - return err - } - - return nil + _, err := client.GetClientTxContext(cmd) + return err }, } diff --git a/client/keys/add.go b/client/keys/add.go index c91f639c4a..ae937b5a4b 100644 --- a/client/keys/add.go +++ b/client/keys/add.go @@ -85,12 +85,12 @@ the flag --nosort is set. func runAddCmd(cmd *cobra.Command, args []string) error { buf := bufio.NewReader(cmd.InOrStdin()) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } - var ( - kr keyring.Keyring - err error - ) + var kr keyring.Keyring dryRun, _ := cmd.Flags().GetBool(flags.FlagDryRun) if dryRun { diff --git a/client/keys/delete.go b/client/keys/delete.go index 3cc61e6de8..e092171014 100644 --- a/client/keys/delete.go +++ b/client/keys/delete.go @@ -29,7 +29,10 @@ private keys stored in a ledger device cannot be deleted with the CLI. Args: cobra.MinimumNArgs(1), RunE: func(cmd *cobra.Command, args []string) error { buf := bufio.NewReader(cmd.InOrStdin()) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } for _, name := range args { info, err := clientCtx.Keyring.Key(name) diff --git a/client/keys/export.go b/client/keys/export.go index ac2b6b4768..7e9cb88ed6 100644 --- a/client/keys/export.go +++ b/client/keys/export.go @@ -32,7 +32,10 @@ and export your keys in ASCII-armored encrypted format.`, Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { buf := bufio.NewReader(cmd.InOrStdin()) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } unarmored, _ := cmd.Flags().GetBool(flagUnarmoredHex) unsafe, _ := cmd.Flags().GetBool(flagUnsafe) diff --git a/client/keys/import.go b/client/keys/import.go index ce1cd36b58..2b7e230654 100644 --- a/client/keys/import.go +++ b/client/keys/import.go @@ -19,7 +19,10 @@ func ImportKeyCommand() *cobra.Command { Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { buf := bufio.NewReader(cmd.InOrStdin()) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } bz, err := ioutil.ReadFile(args[1]) if err != nil { diff --git a/client/keys/list.go b/client/keys/list.go index bb848190a5..de7681acc9 100644 --- a/client/keys/list.go +++ b/client/keys/list.go @@ -24,7 +24,10 @@ along with their associated name and address.`, } func runListCmd(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } infos, err := clientCtx.Keyring.List() if err != nil { diff --git a/client/keys/show.go b/client/keys/show.go index 2cb3c457f2..b72585d9dc 100644 --- a/client/keys/show.go +++ b/client/keys/show.go @@ -53,7 +53,10 @@ consisting of all the keys provided by name and multisig threshold.`, func runShowCmd(cmd *cobra.Command, args []string) (err error) { var info keyring.Info - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } if len(args) == 1 { info, err = fetchKey(clientCtx.Keyring, args[0]) diff --git a/client/rpc/block.go b/client/rpc/block.go index 8bf7f12af8..c3f80ae22e 100644 --- a/client/rpc/block.go +++ b/client/rpc/block.go @@ -21,8 +21,10 @@ func BlockCommand() *cobra.Command { Short: "Get verified data for a the block at given height", Args: cobra.MaximumNArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } var height *int64 // optional height diff --git a/client/rpc/status.go b/client/rpc/status.go index f390a1ab99..82f6552024 100644 --- a/client/rpc/status.go +++ b/client/rpc/status.go @@ -40,7 +40,10 @@ func StatusCommand() *cobra.Command { Use: "status", Short: "Query remote node for status", RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } status, err := getNodeStatus(clientCtx) if err != nil { diff --git a/client/rpc/validators.go b/client/rpc/validators.go index a8bb759c49..66c594966e 100644 --- a/client/rpc/validators.go +++ b/client/rpc/validators.go @@ -29,8 +29,10 @@ func ValidatorCommand() *cobra.Command { Short: "Get the full tendermint validator set at given height", Args: cobra.MaximumNArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } var height *int64 // optional height diff --git a/server/start.go b/server/start.go index 011f3496db..2cb165eb4f 100644 --- a/server/start.go +++ b/server/start.go @@ -103,7 +103,10 @@ which accepts a path for the resulting pprof file. }, RunE: func(cmd *cobra.Command, _ []string) error { serverCtx := GetServerContextFromCmd(cmd) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } withTM, _ := cmd.Flags().GetBool(flagWithTendermint) if !withTM { @@ -114,7 +117,7 @@ which accepts a path for the resulting pprof file. serverCtx.Logger.Info("starting ABCI with Tendermint") // amino is needed here for backwards compatibility of REST routes - err := startInProcess(serverCtx, clientCtx, appCreator) + err = startInProcess(serverCtx, clientCtx, appCreator) errCode, ok := err.(ErrorCode) if !ok { return err diff --git a/simapp/simd/cmd/testnet.go b/simapp/simd/cmd/testnet.go index 5144373f91..0717b39842 100644 --- a/simapp/simd/cmd/testnet.go +++ b/simapp/simd/cmd/testnet.go @@ -56,7 +56,10 @@ Example: simd testnet --v 4 --output-dir ./output --starting-ip-address 192.168.10.2 `, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } serverCtx := server.GetServerContextFromCmd(cmd) config := serverCtx.Config diff --git a/x/auth/client/cli/broadcast.go b/x/auth/client/cli/broadcast.go index 0a728bb9b5..ef5eefc410 100644 --- a/x/auth/client/cli/broadcast.go +++ b/x/auth/client/cli/broadcast.go @@ -25,8 +25,7 @@ $ tx broadcast ./mytxn.json `), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } diff --git a/x/auth/client/cli/query.go b/x/auth/client/cli/query.go index b7c7e1d1e6..2590858b4c 100644 --- a/x/auth/client/cli/query.go +++ b/x/auth/client/cli/query.go @@ -52,8 +52,7 @@ func QueryParamsCmd() *cobra.Command { $ query auth params `), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -81,12 +80,10 @@ func GetAccountCmd() *cobra.Command { Short: "Query for account by address", Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - key, err := sdk.AccAddressFromBech32(args[0]) if err != nil { return err @@ -124,12 +121,10 @@ $ %s query txs --%s 'message.sender=cosmos1...&message.action=withdraw_delegator `, eventFormat, version.AppName, flagEvents), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - eventsRaw, _ := cmd.Flags().GetString(flagEvents) eventsStr := strings.Trim(eventsRaw, "'") @@ -188,12 +183,10 @@ func QueryTxCmd() *cobra.Command { Short: "Query for a transaction by hash in a committed block", Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - output, err := authclient.QueryTx(clientCtx, args[0]) if err != nil { return err diff --git a/x/auth/client/cli/tx_multisign.go b/x/auth/client/cli/tx_multisign.go index 56e1e1b5c9..2910244f6b 100644 --- a/x/auth/client/cli/tx_multisign.go +++ b/x/auth/client/cli/tx_multisign.go @@ -62,12 +62,10 @@ recommended to set such parameters manually. func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { return func(cmd *cobra.Command, args []string) (err error) { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err = client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - parsedTx, err := authclient.ReadTxFromFile(clientCtx, args[0]) if err != nil { return diff --git a/x/auth/client/cli/tx_sign.go b/x/auth/client/cli/tx_sign.go index 9f5f33501b..251282bb8e 100644 --- a/x/auth/client/cli/tx_sign.go +++ b/x/auth/client/cli/tx_sign.go @@ -60,8 +60,7 @@ account key. It implies --signature-only. func makeSignBatchCmd() func(cmd *cobra.Command, args []string) error { return func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } @@ -204,13 +203,12 @@ func preSignCmd(cmd *cobra.Command, _ []string) { } func makeSignCmd() func(cmd *cobra.Command, args []string) error { - return func(cmd *cobra.Command, args []string) (err error) { - clientCtx := client.GetClientContextFromCmd(cmd) - f := cmd.Flags() - clientCtx, err = client.ReadTxCommandFlags(clientCtx, f) + return func(cmd *cobra.Command, args []string) error { + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } + f := cmd.Flags() txFactory := tx.NewFactoryCLI(clientCtx, f) clientCtx, txF, newTx, err := readTxAndInitContexts(clientCtx, cmd, args[0]) @@ -295,7 +293,7 @@ func makeSignCmd() func(cmd *cobra.Command, args []string) error { }() _, err = fp.Write(append(json, '\n')) - return + return err } } diff --git a/x/auth/client/cli/validate_sigs.go b/x/auth/client/cli/validate_sigs.go index 06d24011d2..52290ed8e9 100644 --- a/x/auth/client/cli/validate_sigs.go +++ b/x/auth/client/cli/validate_sigs.go @@ -38,12 +38,10 @@ transaction will be not be performed as that will require RPC communication with func makeValidateSignaturesCmd() func(cmd *cobra.Command, args []string) error { return func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - clientCtx, txBldr, stdTx, err := readTxAndInitContexts(clientCtx, cmd, args[0]) if err != nil { return err diff --git a/x/auth/vesting/client/cli/tx.go b/x/auth/vesting/client/cli/tx.go index 0974552c8a..9cacdfdaab 100644 --- a/x/auth/vesting/client/cli/tx.go +++ b/x/auth/vesting/client/cli/tx.go @@ -47,12 +47,10 @@ set by the committed block's time. The end_time must be provided as a UNIX epoch timestamp.`, Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - toAddr, err := sdk.AccAddressFromBech32(args[0]) if err != nil { return err diff --git a/x/bank/client/cli/query.go b/x/bank/client/cli/query.go index d809f0b6e6..38badd7332 100644 --- a/x/bank/client/cli/query.go +++ b/x/bank/client/cli/query.go @@ -54,12 +54,10 @@ Example: ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - denom, err := cmd.Flags().GetString(FlagDenom) if err != nil { return err @@ -121,12 +119,10 @@ To query for the total supply of a specific coin denomination use: ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - denom, err := cmd.Flags().GetString(FlagDenom) if err != nil { return err diff --git a/x/bank/client/cli/tx.go b/x/bank/client/cli/tx.go index 21a2e6c330..d88a95fc6c 100644 --- a/x/bank/client/cli/tx.go +++ b/x/bank/client/cli/tx.go @@ -34,13 +34,10 @@ ignored as it is implied from [from_key_or_address].`, Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { cmd.Flags().Set(flags.FlagFrom, args[0]) - - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - toAddr, err := sdk.AccAddressFromBech32(args[1]) if err != nil { return err diff --git a/x/bank/client/testutil/cli_helpers.go b/x/bank/client/testutil/cli_helpers.go index 92062a182b..820c668c45 100644 --- a/x/bank/client/testutil/cli_helpers.go +++ b/x/bank/client/testutil/cli_helpers.go @@ -75,13 +75,10 @@ ignored as it is implied from [from_key_or_address].`, Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { cmd.Flags().Set(flags.FlagFrom, args[0]) - - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - toAddr, err := sdk.AccAddressFromBech32(args[1]) if err != nil { return err diff --git a/x/crisis/client/cli/tx.go b/x/crisis/client/cli/tx.go index 58a77eafdb..c18231724e 100644 --- a/x/crisis/client/cli/tx.go +++ b/x/crisis/client/cli/tx.go @@ -34,13 +34,10 @@ func NewMsgVerifyInvariantTxCmd() *cobra.Command { Short: "Submit proof that an invariant broken to halt the chain", Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - moduleName, route := args[0], args[1] if moduleName == "" { return errors.New("invalid module name") diff --git a/x/distribution/client/cli/query.go b/x/distribution/client/cli/query.go index 316b7bf518..3b6032ce7b 100644 --- a/x/distribution/client/cli/query.go +++ b/x/distribution/client/cli/query.go @@ -44,8 +44,7 @@ func GetCmdQueryParams() *cobra.Command { Args: cobra.NoArgs, Short: "Query distribution params", RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -83,8 +82,7 @@ $ %s query distribution validator-outstanding-rewards %s1lwjmdnks33xwnmfayc64ycp ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -129,8 +127,7 @@ $ %s query distribution commission %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -175,8 +172,7 @@ $ %s query distribution slashes %svaloper1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -244,8 +240,7 @@ $ %s query distribution rewards %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p %s1ggh ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -306,8 +301,7 @@ $ %s query distribution community-pool ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } diff --git a/x/distribution/client/cli/tx.go b/x/distribution/client/cli/tx.go index 386174b083..d62bcd21fa 100644 --- a/x/distribution/client/cli/tx.go +++ b/x/distribution/client/cli/tx.go @@ -95,12 +95,10 @@ $ %s tx distribution withdraw-rewards %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - delAddr := clientCtx.GetFromAddress() valAddr, err := sdk.ValAddressFromBech32(args[0]) if err != nil { @@ -144,12 +142,10 @@ $ %s tx distribution withdraw-all-rewards --from mykey ), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - delAddr := clientCtx.GetFromAddress() // The transaction cannot be generated offline since it requires a query @@ -208,12 +204,10 @@ $ %s tx distribution set-withdraw-addr %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - delAddr := clientCtx.GetFromAddress() withdrawAddr, err := sdk.AccAddressFromBech32(args[0]) if err != nil { @@ -249,12 +243,10 @@ $ %s tx distribution fund-community-pool 100uatom --from mykey ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - depositorAddr := clientCtx.GetFromAddress() amount, err := sdk.ParseCoinsNormalized(args[0]) if err != nil { @@ -304,12 +296,10 @@ Where proposal.json contains: ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - proposal, err := ParseCommunityPoolSpendProposalWithDeposit(clientCtx.JSONMarshaler, args[0]) if err != nil { return err diff --git a/x/evidence/client/cli/query.go b/x/evidence/client/cli/query.go index b883ed280e..9c987fb15e 100644 --- a/x/evidence/client/cli/query.go +++ b/x/evidence/client/cli/query.go @@ -47,12 +47,10 @@ $ %s query %s --page=2 --limit=50 // can be queried for by hash or paginated evidence can be returned. func QueryEvidenceCmd() func(*cobra.Command, []string) error { return func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - if len(args) > 0 { return queryEvidence(clientCtx, args[0]) } diff --git a/x/genutil/client/cli/gentx.go b/x/genutil/client/cli/gentx.go index 790cc9921b..6ded1b76b9 100644 --- a/x/genutil/client/cli/gentx.go +++ b/x/genutil/client/cli/gentx.go @@ -58,7 +58,10 @@ $ %s gentx my-key-name --home=/path/to/home/dir --keyring-backend=os --chain-id= ), RunE: func(cmd *cobra.Command, args []string) error { serverCtx := server.GetServerContextFromCmd(cmd) - clientCtx := client.GetClientContextFromCmd(cmd) + clientCtx, err := client.GetClientQueryContext(cmd) + if err != nil { + return err + } cdc := clientCtx.JSONMarshaler config := serverCtx.Config diff --git a/x/gov/client/cli/query.go b/x/gov/client/cli/query.go index 1660927b4f..8c67cd96e5 100644 --- a/x/gov/client/cli/query.go +++ b/x/gov/client/cli/query.go @@ -60,8 +60,7 @@ $ %s query gov proposal 1 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -138,8 +137,7 @@ $ %s query gov proposals --page=2 --limit=100 } } - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -197,8 +195,7 @@ $ %s query gov vote 1 cosmos1skjwj5whet0lpe65qaq4rpq03hjxlwd9nf39lk ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -272,8 +269,7 @@ $ %[1]s query gov votes 1 --page=2 --limit=100 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -355,8 +351,7 @@ $ %s query gov deposit 1 cosmos1skjwj5whet0lpe65qaq4rpq03hjxlwd9nf39lk ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -426,8 +421,7 @@ $ %s query gov deposits 1 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -505,8 +499,7 @@ $ %s query gov tally 1 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -561,8 +554,7 @@ $ %s query gov params ), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -626,8 +618,7 @@ $ %s query gov param deposit ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -679,8 +670,7 @@ $ %s query gov proposer 1 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } diff --git a/x/gov/client/cli/tx.go b/x/gov/client/cli/tx.go index b13786ede8..16ca7f7c68 100644 --- a/x/gov/client/cli/tx.go +++ b/x/gov/client/cli/tx.go @@ -103,8 +103,7 @@ $ %s tx gov submit-proposal --title="Test Proposal" --description="My awesome pr ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } @@ -161,8 +160,7 @@ $ %s tx gov deposit 1 10stake --from mykey ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } @@ -215,12 +213,10 @@ $ %s tx gov vote 1 yes --from mykey ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - // Get voting address from := clientCtx.GetFromAddress() diff --git a/x/ibc/applications/transfer/client/cli/query.go b/x/ibc/applications/transfer/client/cli/query.go index b24f21dee5..7d281bb415 100644 --- a/x/ibc/applications/transfer/client/cli/query.go +++ b/x/ibc/applications/transfer/client/cli/query.go @@ -21,8 +21,7 @@ func GetCmdQueryDenomTrace() *cobra.Command { Example: fmt.Sprintf("%s query ibc-transfer denom-trace [hash]", version.AppName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -55,12 +54,10 @@ func GetCmdQueryDenomTraces() *cobra.Command { Example: fmt.Sprintf("%s query ibc-transfer denom-traces", version.AppName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pageReq, err := client.ReadPageRequest(cmd.Flags()) @@ -95,12 +92,10 @@ func GetCmdParams() *cobra.Command { Args: cobra.NoArgs, Example: fmt.Sprintf("%s query ibc-transfer params", version.AppName), RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) res, _ := queryClient.Params(context.Background(), &types.QueryParamsRequest{}) diff --git a/x/ibc/applications/transfer/client/cli/tx.go b/x/ibc/applications/transfer/client/cli/tx.go index 507840a582..c9c6fde517 100644 --- a/x/ibc/applications/transfer/client/cli/tx.go +++ b/x/ibc/applications/transfer/client/cli/tx.go @@ -35,12 +35,10 @@ to the counterparty channel. Any timeout set to 0 is disabled.`), Example: fmt.Sprintf("%s tx ibc-transfer transfer [src-port] [src-channel] [receiver] [amount]", version.AppName), Args: cobra.ExactArgs(4), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - sender := clientCtx.GetFromAddress() srcPort := args[0] srcChannel := args[1] diff --git a/x/ibc/core/02-client/client/cli/query.go b/x/ibc/core/02-client/client/cli/query.go index d6a32dd716..a1e9b45d22 100644 --- a/x/ibc/core/02-client/client/cli/query.go +++ b/x/ibc/core/02-client/client/cli/query.go @@ -29,12 +29,10 @@ func GetCmdQueryClientStates() *cobra.Command { Example: fmt.Sprintf("%s query %s %s states", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pageReq, err := client.ReadPageRequest(cmd.Flags()) @@ -70,12 +68,10 @@ func GetCmdQueryClientState() *cobra.Command { Example: fmt.Sprintf("%s query %s %s state [client-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - clientID := args[0] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -104,12 +100,10 @@ func GetCmdQueryConsensusStates() *cobra.Command { Example: fmt.Sprintf("%s query %s %s consensus-states [client-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - clientID := args[0] queryClient := types.NewQueryClient(clientCtx) @@ -149,16 +143,12 @@ If the '--latest' flag is included, the query returns the latest consensus state Example: fmt.Sprintf("%s query %s %s consensus-state [client-id] [height]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.RangeArgs(1, 2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - clientID := args[0] - queryLatestHeight, _ := cmd.Flags().GetBool(flagLatestHeight) - var height types.Height if !queryLatestHeight { @@ -199,12 +189,10 @@ func GetCmdQueryHeader() *cobra.Command { Example: fmt.Sprintf("%s query %s %s header", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - header, height, err := utils.QueryTendermintHeader(clientCtx) if err != nil { return err @@ -230,12 +218,10 @@ func GetCmdNodeConsensusState() *cobra.Command { Example: fmt.Sprintf("%s query %s %s node-state", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - state, height, err := utils.QueryNodeConsensusState(clientCtx) if err != nil { return err @@ -260,12 +246,10 @@ func GetCmdParams() *cobra.Command { Args: cobra.NoArgs, Example: fmt.Sprintf("%s query %s %s params", version.AppName, host.ModuleName, types.SubModuleName), RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) res, _ := queryClient.ClientParams(context.Background(), &types.QueryClientParamsRequest{}) diff --git a/x/ibc/core/03-connection/client/cli/query.go b/x/ibc/core/03-connection/client/cli/query.go index a4f9961711..071410398d 100644 --- a/x/ibc/core/03-connection/client/cli/query.go +++ b/x/ibc/core/03-connection/client/cli/query.go @@ -24,12 +24,10 @@ func GetCmdQueryConnections() *cobra.Command { Example: fmt.Sprintf("%s query %s %s connections", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pageReq, err := client.ReadPageRequest(cmd.Flags()) @@ -65,12 +63,10 @@ func GetCmdQueryConnection() *cobra.Command { Example: fmt.Sprintf("%s query %s %s end [connection-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - connectionID := args[0] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -99,12 +95,10 @@ func GetCmdQueryClientConnections() *cobra.Command { Example: fmt.Sprintf("%s query %s %s path [client-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - clientID := args[0] prove, _ := cmd.Flags().GetBool(flags.FlagProve) diff --git a/x/ibc/core/03-connection/client/cli/tx.go b/x/ibc/core/03-connection/client/cli/tx.go index 5044f003d2..339e2e9770 100644 --- a/x/ibc/core/03-connection/client/cli/tx.go +++ b/x/ibc/core/03-connection/client/cli/tx.go @@ -40,12 +40,10 @@ func NewConnectionOpenInitCmd() *cobra.Command { ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - clientID := args[0] counterpartyClientID := args[1] @@ -113,12 +111,10 @@ func NewConnectionOpenTryCmd() *cobra.Command { ), Args: cobra.ExactArgs(12), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - connectionID := args[0] clientID := args[1] counterpartyConnectionID := args[2] @@ -211,23 +207,21 @@ func NewConnectionOpenTryCmd() *cobra.Command { // connection open attempt from chain B to chain A func NewConnectionOpenAckCmd() *cobra.Command { cmd := &cobra.Command{ - Use: `open-ack [connection-id] [counterparty-connection-id] [path/to/client_state.json] [consensus-height] [proof-height] + Use: `open-ack [connection-id] [counterparty-connection-id] [path/to/client_state.json] [consensus-height] [proof-height] [path/to/proof_try.json] [path/to/proof_client.json] [path/to/proof_consensus.json] [version]`, Short: "relay the acceptance of a connection open attempt", Long: "Relay the acceptance of a connection open attempt from chain B to chain A", Example: fmt.Sprintf( - `%s tx %s %s open-ack [connection-id] [counterparty-connection-id] [path/to/client_state.json] [consensus-height] [proof-height] + `%s tx %s %s open-ack [connection-id] [counterparty-connection-id] [path/to/client_state.json] [consensus-height] [proof-height] [path/to/proof_try.json] [path/to/proof_client.json] [path/to/proof_consensus.json] [version]`, version.AppName, host.ModuleName, types.SubModuleName, ), Args: cobra.ExactArgs(9), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - connectionID := args[0] counterpartyConnectionID := args[1] @@ -308,14 +302,11 @@ func NewConnectionOpenConfirmCmd() *cobra.Command { ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - connectionID := args[0] - proofHeight, err := clienttypes.ParseHeight(args[1]) if err != nil { return err diff --git a/x/ibc/core/04-channel/client/cli/query.go b/x/ibc/core/04-channel/client/cli/query.go index e84006a861..5d059c08cf 100644 --- a/x/ibc/core/04-channel/client/cli/query.go +++ b/x/ibc/core/04-channel/client/cli/query.go @@ -29,8 +29,7 @@ func GetCmdQueryChannels() *cobra.Command { Example: fmt.Sprintf("%s query %s %s channels", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, _ []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -71,12 +70,10 @@ func GetCmdQueryChannel() *cobra.Command { ), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -106,8 +103,7 @@ func GetCmdQueryConnectionChannels() *cobra.Command { Example: fmt.Sprintf("%s query %s %s connections [connection-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -146,12 +142,10 @@ func GetCmdQueryChannelClientState() *cobra.Command { Example: fmt.Sprintf("%s query ibc channel client-state [port-id] [channel-id]", version.AppName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] @@ -179,8 +173,7 @@ func GetCmdQueryPacketCommitments() *cobra.Command { Example: fmt.Sprintf("%s query %s %s packet-commitments [port-id] [channel-id]", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -222,12 +215,10 @@ func GetCmdQueryPacketCommitment() *cobra.Command { ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -263,12 +254,10 @@ func GetCmdQueryPacketReceipt() *cobra.Command { ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -304,12 +293,10 @@ func GetCmdQueryPacketAcknowledgement() *cobra.Command { ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] prove, _ := cmd.Flags().GetBool(flags.FlagProve) @@ -348,8 +335,7 @@ The return value represents: Example: fmt.Sprintf("%s query %s %s unreceived-packets [port-id] [channel-id] --sequences=1,2,3", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -399,8 +385,7 @@ The return value represents: Example: fmt.Sprintf("%s query %s %s unreceived-acks [port-id] [channel-id] --sequences=1,2,3", version.AppName, host.ModuleName, types.SubModuleName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -448,12 +433,10 @@ func GetCmdQueryNextSequenceReceive() *cobra.Command { ), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] prove, _ := cmd.Flags().GetBool(flags.FlagProve) diff --git a/x/ibc/core/04-channel/client/cli/tx.go b/x/ibc/core/04-channel/client/cli/tx.go index d3150f2c91..21aafba194 100644 --- a/x/ibc/core/04-channel/client/cli/tx.go +++ b/x/ibc/core/04-channel/client/cli/tx.go @@ -28,12 +28,10 @@ func NewChannelOpenInitCmd() *cobra.Command { Short: "Creates and sends a ChannelOpenInit message", Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] counterpartyPortID := args[1] hops := strings.Split(args[2], "/") @@ -66,12 +64,10 @@ func NewChannelOpenTryCmd() *cobra.Command { Short: "Creates and sends a ChannelOpenTry message", Args: cobra.ExactArgs(7), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] counterpartyPortID := args[2] @@ -119,12 +115,10 @@ func NewChannelOpenAckCmd() *cobra.Command { Short: "Creates and sends a ChannelOpenAck message", Args: cobra.ExactArgs(5), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] counterpartyChannelID := args[2] @@ -165,12 +159,10 @@ func NewChannelOpenConfirmCmd() *cobra.Command { Short: "Creates and sends a ChannelOpenConfirm message", Args: cobra.ExactArgs(4), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] @@ -207,12 +199,10 @@ func NewChannelCloseInitCmd() *cobra.Command { Short: "Creates and sends a ChannelCloseInit message", Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] @@ -237,12 +227,10 @@ func NewChannelCloseConfirmCmd() *cobra.Command { Short: "Creates and sends a ChannelCloseConfirm message", Args: cobra.ExactArgs(4), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - portID := args[0] channelID := args[1] diff --git a/x/ibc/light-clients/06-solomachine/client/cli/tx.go b/x/ibc/light-clients/06-solomachine/client/cli/tx.go index 8d1709fc27..dea2d2ae73 100644 --- a/x/ibc/light-clients/06-solomachine/client/cli/tx.go +++ b/x/ibc/light-clients/06-solomachine/client/cli/tx.go @@ -31,12 +31,10 @@ func NewCreateClientCmd() *cobra.Command { Example: fmt.Sprintf("%s tx ibc %s create [sequence] [path/to/consensus_state] --from node0 --home ../node0/cli --chain-id $CID", version.AppName, types.SubModuleName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - sequence, err := strconv.ParseUint(args[0], 10, 64) if err != nil { return err @@ -90,12 +88,10 @@ func NewUpdateClientCmd() *cobra.Command { Example: fmt.Sprintf("%s tx ibc %s update [client-id] [path/to/header.json] --from node0 --home ../node0/cli --chain-id $CID", version.AppName, types.SubModuleName), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - clientID := args[0] cdc := codec.NewProtoCodec(clientCtx.InterfaceRegistry) @@ -138,12 +134,10 @@ func NewSubmitMisbehaviourCmd() *cobra.Command { Example: fmt.Sprintf("%s tx ibc %s misbehaviour [path/to/misbehaviour.json] --from node0 --home ../node0/cli --chain-id $CID", version.AppName, types.SubModuleName), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - cdc := codec.NewProtoCodec(clientCtx.InterfaceRegistry) m := &types.Misbehaviour{} diff --git a/x/ibc/light-clients/07-tendermint/client/cli/tx.go b/x/ibc/light-clients/07-tendermint/client/cli/tx.go index 04a274acec..f8b925e4f0 100644 --- a/x/ibc/light-clients/07-tendermint/client/cli/tx.go +++ b/x/ibc/light-clients/07-tendermint/client/cli/tx.go @@ -36,7 +36,7 @@ func NewCreateClientCmd() *cobra.Command { cmd := &cobra.Command{ Use: "create [path/to/consensus_state.json] [trusting_period] [unbonding_period] [max_clock_drift]", Short: "create new tendermint client", - Long: `Create a new tendermint IBC client. + Long: `Create a new tendermint IBC client. - 'trust-level' flag can be a fraction (eg: '1/3') or 'default' - 'proof-specs' flag can be JSON input, a path to a .json file or 'default' - 'upgrade-path' flag is a string specifying the upgrade path for this chain where a future upgraded client will be stored. The path is a comma-separated list representing the keys in order of the keyPath to the committed upgraded client. @@ -44,12 +44,10 @@ func NewCreateClientCmd() *cobra.Command { Example: fmt.Sprintf("%s tx ibc %s create [path/to/consensus_state.json] [trusting_period] [unbonding_period] [max_clock_drift] --trust-level default --consensus-params [path/to/consensus-params.json] --proof-specs [path/to/proof-specs.json] --upgrade-path upgrade/upgradedClient --from node0 --home ../node0/cli --chain-id $CID", version.AppName, types.SubModuleName), Args: cobra.ExactArgs(4), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - cdc := codec.NewProtoCodec(clientCtx.InterfaceRegistry) legacyAmino := codec.NewLegacyAmino() @@ -171,12 +169,10 @@ func NewUpdateClientCmd() *cobra.Command { ), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - clientID := args[0] cdc := codec.NewProtoCodec(clientCtx.InterfaceRegistry) @@ -225,12 +221,10 @@ func NewSubmitMisbehaviourCmd() *cobra.Command { ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - cdc := codec.NewProtoCodec(clientCtx.InterfaceRegistry) var m *types.Misbehaviour diff --git a/x/mint/client/cli/query.go b/x/mint/client/cli/query.go index 3f036ceae0..cce0d7c12b 100644 --- a/x/mint/client/cli/query.go +++ b/x/mint/client/cli/query.go @@ -38,12 +38,10 @@ func GetCmdQueryParams() *cobra.Command { Short: "Query the current minting parameters", Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) params := &types.QueryParamsRequest{} @@ -70,12 +68,10 @@ func GetCmdQueryInflation() *cobra.Command { Short: "Query the current minting inflation value", Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) params := &types.QueryInflationRequest{} @@ -102,12 +98,10 @@ func GetCmdQueryAnnualProvisions() *cobra.Command { Short: "Query the current minting annual provisions value", Args: cobra.NoArgs, RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) params := &types.QueryAnnualProvisionsRequest{} diff --git a/x/params/client/cli/query.go b/x/params/client/cli/query.go index d988084bfc..516ff3b6b4 100644 --- a/x/params/client/cli/query.go +++ b/x/params/client/cli/query.go @@ -34,8 +34,7 @@ func NewQuerySubspaceParamsCmd() *cobra.Command { Short: "Query for raw parameters by subspace and key", Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } diff --git a/x/params/client/cli/tx.go b/x/params/client/cli/tx.go index 154722a144..39b0242522 100644 --- a/x/params/client/cli/tx.go +++ b/x/params/client/cli/tx.go @@ -57,12 +57,10 @@ Where proposal.json contains: ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - proposal, err := paramscutils.ParseParamChangeProposalJSON(clientCtx.LegacyAmino, args[0]) if err != nil { return err diff --git a/x/slashing/client/cli/query.go b/x/slashing/client/cli/query.go index f6b470574b..b6b71a344c 100644 --- a/x/slashing/client/cli/query.go +++ b/x/slashing/client/cli/query.go @@ -45,12 +45,10 @@ $ query slashing signing-info cosmosvalconspub1zcjduepqfhvwcmt7p06fvdgexx `), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pk, err := sdk.GetPubKeyFromBech32(sdk.Bech32PubKeyTypeConsPub, args[0]) @@ -85,12 +83,10 @@ $ query slashing signing-infos `), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pageReq, err := client.ReadPageRequest(cmd.Flags()) @@ -125,12 +121,10 @@ func GetCmdQueryParams() *cobra.Command { $ query slashing params `), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) params := &types.QueryParamsRequest{} diff --git a/x/slashing/client/cli/tx.go b/x/slashing/client/cli/tx.go index 298a44e140..d896c8570c 100644 --- a/x/slashing/client/cli/tx.go +++ b/x/slashing/client/cli/tx.go @@ -34,12 +34,10 @@ func NewUnjailTxCmd() *cobra.Command { $ tx slashing unjail --from mykey `, RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - valAddr := clientCtx.GetFromAddress() msg := types.NewMsgUnjail(sdk.ValAddress(valAddr)) diff --git a/x/staking/client/cli/query.go b/x/staking/client/cli/query.go index 148d5c4186..1e8b0a5c53 100644 --- a/x/staking/client/cli/query.go +++ b/x/staking/client/cli/query.go @@ -63,12 +63,10 @@ $ %s query staking validator %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) addr, err := sdk.ValAddressFromBech32(args[0]) @@ -107,12 +105,10 @@ $ %s query staking validators ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) pageReq, err := client.ReadPageRequest(cmd.Flags()) if err != nil { @@ -155,12 +151,10 @@ $ %s query staking unbonding-delegations-from %s1gghjut3ccd8ay0zduzj64hwre2fxs9l ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) valAddr, err := sdk.ValAddressFromBech32(args[0]) @@ -212,12 +206,10 @@ $ %s query staking redelegations-from %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) valSrcAddr, err := sdk.ValAddressFromBech32(args[0]) @@ -269,12 +261,10 @@ $ %s query staking delegation %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p %s1gghju ), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) delAddr, err := sdk.AccAddressFromBech32(args[0]) @@ -325,12 +315,10 @@ $ %s query staking delegations %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) delAddr, err := sdk.AccAddressFromBech32(args[0]) @@ -382,12 +370,10 @@ $ %s query staking delegations-to %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) valAddr, err := sdk.ValAddressFromBech32(args[0]) @@ -440,12 +426,10 @@ $ %s query staking unbonding-delegation %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9 ), Args: cobra.ExactArgs(2), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) valAddr, err := sdk.ValAddressFromBech32(args[1]) @@ -496,12 +480,10 @@ $ %s query staking unbonding-delegations %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru ), Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) delegatorAddr, err := sdk.AccAddressFromBech32(args[0]) @@ -554,12 +536,10 @@ $ %s query staking redelegation %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p %s1l2r ), Args: cobra.ExactArgs(3), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) delAddr, err := sdk.AccAddressFromBech32(args[0]) @@ -616,12 +596,10 @@ $ %s query staking redelegation %s1gghjut3ccd8ay0zduzj64hwre2fxs9ld75ru9p ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) delAddr, err := sdk.AccAddressFromBech32(args[0]) @@ -670,12 +648,10 @@ $ %s query staking historical-info 5 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) height, err := strconv.ParseInt(args[0], 10, 64) @@ -715,12 +691,10 @@ $ %s query staking pool ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) res, err := queryClient.Pool(context.Background(), &types.QueryPoolRequest{}) @@ -753,12 +727,10 @@ $ %s query staking params ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } - queryClient := types.NewQueryClient(clientCtx) res, err := queryClient.Params(context.Background(), &types.QueryParamsRequest{}) diff --git a/x/staking/client/cli/tx.go b/x/staking/client/cli/tx.go index 72938ce0a0..10ceba6a45 100644 --- a/x/staking/client/cli/tx.go +++ b/x/staking/client/cli/tx.go @@ -53,12 +53,10 @@ func NewCreateValidatorCmd() *cobra.Command { Use: "create-validator", Short: "create new validator initialized with a self-delegation to it", RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever) txf, msg, err := NewBuildCreateValidatorMsg(clientCtx, txf, cmd.Flags()) @@ -93,14 +91,11 @@ func NewEditValidatorCmd() *cobra.Command { Use: "edit-validator", Short: "edit an existing validator account", RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - valAddr := clientCtx.GetFromAddress() - moniker, _ := cmd.Flags().GetString(FlagMoniker) identity, _ := cmd.Flags().GetString(FlagIdentity) website, _ := cmd.Flags().GetString(FlagWebsite) @@ -166,12 +161,10 @@ $ %s tx staking delegate %s1l2rsakp388kuv9k8qzq6lrm9taddae7fpx59wm 1000stake --f ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - amount, err := sdk.ParseCoinNormalized(args[1]) if err != nil { return err @@ -214,12 +207,10 @@ $ %s tx staking redelegate %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj %s1l2rsakp3 ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - delAddr := clientCtx.GetFromAddress() valSrcAddr, err := sdk.ValAddressFromBech32(args[0]) if err != nil { @@ -267,12 +258,10 @@ $ %s tx staking unbond %s1gghjut3ccd8ay0zduzj64hwre2fxs9ldmqhffj 100stake --from ), ), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - delAddr := clientCtx.GetFromAddress() valAddr, err := sdk.ValAddressFromBech32(args[0]) if err != nil { diff --git a/x/upgrade/client/cli/query.go b/x/upgrade/client/cli/query.go index cfd836d787..675dba3a9e 100644 --- a/x/upgrade/client/cli/query.go +++ b/x/upgrade/client/cli/query.go @@ -34,8 +34,7 @@ func GetCurrentPlanCmd() *cobra.Command { Long: "Gets the currently scheduled upgrade plan, if one exists", Args: cobra.ExactArgs(0), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } @@ -70,8 +69,7 @@ func GetAppliedPlanCmd() *cobra.Command { "This helps a client determine which binary was valid over a given range of blocks, as well as more context to understand past migrations.", Args: cobra.ExactArgs(1), RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadQueryCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientQueryContext(cmd) if err != nil { return err } diff --git a/x/upgrade/client/cli/tx.go b/x/upgrade/client/cli/tx.go index fd7a6ed760..1a341914e3 100644 --- a/x/upgrade/client/cli/tx.go +++ b/x/upgrade/client/cli/tx.go @@ -43,12 +43,10 @@ func NewCmdSubmitUpgradeProposal() *cobra.Command { "Please specify a unique name and height OR time for the upgrade to take effect.\n" + "You may include info to reference a binary download link, in a format compatible with: https://github.com/regen-network/cosmosd", RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - name := args[0] content, err := parseArgsToContent(cmd, name) if err != nil { @@ -97,12 +95,10 @@ func NewCmdSubmitCancelUpgradeProposal() *cobra.Command { Short: "Cancel the current software upgrade proposal", Long: "Cancel a software upgrade along with an initial deposit.", RunE: func(cmd *cobra.Command, args []string) error { - clientCtx := client.GetClientContextFromCmd(cmd) - clientCtx, err := client.ReadTxCommandFlags(clientCtx, cmd.Flags()) + clientCtx, err := client.GetClientTxContext(cmd) if err != nil { return err } - from := clientCtx.GetFromAddress() depositStr, err := cmd.Flags().GetString(cli.FlagDeposit)