Merge PR #5421: Refactor Error Handling

docs/architecture/adr-015-ibc-packet-receiver.md

@@ -204,7 +204,7 @@ type PacketDataI interface {
 	GetCommitment() []byte // Commitment form that will be stored in the state.
 	GetTimeoutHeight() uint64
 
-	ValidateBasic() sdk.Error
+	ValidateBasic() error
 	Type() string
 }
 ```

docs/building-modules/handler.md

@@ -25,19 +25,24 @@ Let us break it down:
 
 ## Implementation of a module `handler`s
 
-Module `handler`s are typically implemented in a `./handler.go` file inside the module's folder. The [module manager](./module-manager.md) is used to add the module's `handler`s to the [application's `router`](../core/baseapp.md#message-routing) via the `NewHandler()` method. Typically, the manager's `NewHandler()` method simply calls a `NewHandler()` method defined in `handler.go`, which looks like the following:
+Module `handler`s are typically implemented in a `./handler.go` file inside the module's folder. The
+[module manager](./module-manager.md) is used to add the module's `handler`s to the
+[application's `router`](../core/baseapp.md#message-routing) via the `NewHandler()` method. Typically,
+the manager's `NewHandler()` method simply calls a `NewHandler()` method defined in `handler.go`,
+which looks like the following:
 
 ```go
 func NewHandler(keeper Keeper) sdk.Handler {
-	return func(ctx sdk.Context, msg sdk.Msg) sdk.Result {
+	return func(ctx sdk.Context, msg sdk.Msg) (*sdk.Result, error) {
 		switch msg := msg.(type) {
 		case MsgType1:
 			return handleMsgType1(ctx, keeper, msg)
+
 		case MsgType2:
 			return handleMsgType2(ctx, keeper, msg)
+
 		default:
-			errMsg := fmt.Sprintf("Unrecognized nameservice Msg type: %v", msg.Type())
-			return sdk.ErrUnknownRequest(errMsg).Result()
+			return nil, sdkerrors.Wrapf(sdkerrors.ErrUnknownRequest, "unrecognized %s message type: %T", ModuleName, msg)
 		}
 	}
 }

docs/building-modules/querier.md

@@ -29,14 +29,16 @@ Module `querier`s are typically implemented in a `./internal/keeper/querier.go`
 
 ```go
 func NewQuerier(keeper Keeper) sdk.Querier {
-	return func(ctx sdk.Context, path []string, req abci.RequestQuery) (res []byte, err sdk.Error) {
+	return func(ctx sdk.Context, path []string, req abci.RequestQuery) ([]byte, error) {
 		switch path[0] {
 		case QueryType1:
 			return queryType1(ctx, path[1:], req, keeper)
+
 		case QueryType2:
 			return queryType2(ctx, path[1:], req, keeper)
+
 		default:
-			return nil, sdk.ErrUnknownRequest("unknown nameservice query endpoint")
+			return nil, sdkerrors.Wrapf(sdkerrors.ErrUnknownRequest, "unknown %s query endpoint: %s", types.ModuleName, path[0])
 		}
 	}
 }