From 994f2d68275d5781270aef0d8797aa15ce3660a6 Mon Sep 17 00:00:00 2001 From: Amaury <1293565+amaurym@users.noreply.github.com> Date: Wed, 25 Aug 2021 17:05:45 +0200 Subject: [PATCH] chore: Add proto comments for MsgCreatePeriodicVestingAccountResponse (#10007) ## Description We merged #9596, but we forgot to add proto comments for one message. Then, proto lint CI fails on unrelated PRs, e.g. https://github.com/cosmos/cosmos-sdk/pull/9759/checks?check_run_id=3421076482#step:4:24. This fixes it. Also related to https://github.com/cosmos/cosmos-sdk/issues/9978 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- docs/core/proto-docs.md | 3 ++- proto/cosmos/vesting/v1beta1/tx.proto | 2 ++ x/auth/vesting/types/tx.pb.go | 2 ++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/core/proto-docs.md b/docs/core/proto-docs.md index 29a74149cf..3390d76769 100644 --- a/docs/core/proto-docs.md +++ b/docs/core/proto-docs.md @@ -9568,7 +9568,8 @@ account. ### MsgCreatePeriodicVestingAccountResponse - +MsgCreateVestingAccountResponse defines the Msg/CreatePeriodicVestingAccount +response type. diff --git a/proto/cosmos/vesting/v1beta1/tx.proto b/proto/cosmos/vesting/v1beta1/tx.proto index 8cd4eb7a48..9432f0c3f3 100644 --- a/proto/cosmos/vesting/v1beta1/tx.proto +++ b/proto/cosmos/vesting/v1beta1/tx.proto @@ -46,4 +46,6 @@ message MsgCreatePeriodicVestingAccount { repeated Period vesting_periods = 4 [(gogoproto.nullable) = false]; } +// MsgCreateVestingAccountResponse defines the Msg/CreatePeriodicVestingAccount +// response type. message MsgCreatePeriodicVestingAccountResponse {} diff --git a/x/auth/vesting/types/tx.pb.go b/x/auth/vesting/types/tx.pb.go index 1124087de5..824e20b4be 100644 --- a/x/auth/vesting/types/tx.pb.go +++ b/x/auth/vesting/types/tx.pb.go @@ -215,6 +215,8 @@ func (m *MsgCreatePeriodicVestingAccount) GetVestingPeriods() []Period { return nil } +// MsgCreateVestingAccountResponse defines the Msg/CreatePeriodicVestingAccount +// response type. type MsgCreatePeriodicVestingAccountResponse struct { }