LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

chore: lint fixes (#24084)

Browse Source
This commit is contained in:
Alex | Interchain Labs 2025-03-20 16:20:39 -04:00 committed by GitHub
parent 978978a3fe
commit 98f0f76e73
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
60 changed files with 33 additions and 127 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
baseapp/abci_test.go
View File

@ -1336,7 +1336,6 @@ func TestABCI_GetBlockRetentionHeight(t *testing.T) {
}
for name, tc := range testCases {
tc := tc
tc.bapp.SetParamStore(&paramStore{db: dbm.NewMemDB()})
_, err = tc.bapp.InitChain(&abci.RequestInitChain{

2
client/cmd_test.go
View File

@ -125,8 +125,6 @@ func TestSetCmdClientContextHandler(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
cmd := newCmd()
_ = testutil.ApplyMockIODiscardOutErr(cmd)

1
client/flags/flags_test.go
View File

@ -22,7 +22,6 @@ func TestParseGasSetting(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
gs, err := flags.ParseGasSetting(tc.input)

1
client/tx/aux_builder_test.go
View File

@ -213,7 +213,6 @@ func TestAuxTxBuilder(t *testing.T) {
}
for _, tc := range testcases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
b = tx.NewAuxTxBuilder()
err := tc.malleate()

1
codec/amino_codec_test.go
View File

@ -71,7 +71,6 @@ func TestAminoCodecMarshalJSONIndent(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
cdc := codec.NewAminoCodec(createTestCodec())

1
codec/codec_common_test.go
View File

@ -121,7 +121,6 @@ func testMarshaling(t *testing.T, cdc interface {
}
for _, tc := range testCases {
tc := tc
m1 := mustMarshaler{cdc.Marshal, cdc.MustMarshal, cdc.Unmarshal, cdc.MustUnmarshal}
m2 := mustMarshaler{cdc.MarshalLengthPrefixed, cdc.MustMarshalLengthPrefixed, cdc.UnmarshalLengthPrefixed, cdc.MustUnmarshalLengthPrefixed}
m3 := mustMarshaler{

2
crypto/keyring/keyring_test.go
View File

@ -2002,7 +2002,7 @@ func TestRenameKey(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
kr := newKeyring(t, "testKeyring")
t.Run(tc.name, func(t *testing.T) {
tc.run(kr)

5
crypto/types/compact_bit_array_test.go
View File

@ -58,7 +58,6 @@ func TestBitArrayEqual(t *testing.T) {
{name: "different should not be equal", b1: big1, b2: big2, eq: false},
}
for _, tc := range cases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
eq := tc.b1.Equal(tc.b2)
require.Equal(t, tc.eq, eq)
@ -102,7 +101,6 @@ func TestJSONMarshalUnmarshal(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.bA.String(), func(t *testing.T) {
bz, err := json.Marshal(tc.bA)
require.NoError(t, err)
@ -162,7 +160,6 @@ func TestCompactMarshalUnmarshal(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.bA.String(), func(t *testing.T) {
bz := tc.bA.CompactMarshal()
@ -209,7 +206,7 @@ func TestCompactBitArrayNumOfTrueBitsBefore(t *testing.T) {
{`"______________xx"`, []int{14, 15}, []int{0, 1}},
}
for tcIndex, tc := range testCases {
tc := tc
tcIndex := tcIndex
t.Run(tc.marshalledBA, func(t *testing.T) {
var bA *CompactBitArray

6
simapp/app_test.go
View File

@ -132,8 +132,10 @@ func TestRunMigrations(t *testing.T) {
}
// Initialize the chain
app.InitChain(&abci.RequestInitChain{})
app.Commit()
_, err := app.InitChain(&abci.RequestInitChain{})
require.NoError(t, err)
_, err = app.Commit()
require.NoError(t, err)
testCases := []struct {
name string

27
simapp/export.go
View File

@ -164,7 +164,7 @@ func (app *SimApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []
/* Handle staking state. */
// iterate through redelegations, reset creation height
app.StakingKeeper.IterateRedelegations(ctx, func(_ int64, red stakingtypes.Redelegation) (stop bool) {
err = app.StakingKeeper.IterateRedelegations(ctx, func(_ int64, red stakingtypes.Redelegation) (stop bool) {
for i := range red.Entries {
red.Entries[i].CreationHeight = 0
}
@ -174,9 +174,12 @@ func (app *SimApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []
}
return false
})
if err != nil {
panic(fmt.Errorf("error while iterating redelegations: %w", err))
}
// iterate through unbonding delegations, reset creation height
app.StakingKeeper.IterateUnbondingDelegations(ctx, func(_ int64, ubd stakingtypes.UnbondingDelegation) (stop bool) {
err = app.StakingKeeper.IterateUnbondingDelegations(ctx, func(_ int64, ubd stakingtypes.UnbondingDelegation) (stop bool) {
for i := range ubd.Entries {
ubd.Entries[i].CreationHeight = 0
}
@ -186,12 +189,14 @@ func (app *SimApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []
}
return false
})
if err != nil {
panic(fmt.Errorf("error while iterating unbonding delegations: %w", err))
}
// Iterate through validators by power descending, reset bond heights, and
// update bond intra-tx counters.
store := ctx.KVStore(app.GetKey(stakingtypes.StoreKey))
iter := storetypes.KVStoreReversePrefixIterator(store, stakingtypes.ValidatorsKey)
counter := int16(0)
for ; iter.Valid(); iter.Next() {
addr := sdk.ValAddress(stakingtypes.AddressFromValidatorsKey(iter.Key()))
@ -205,8 +210,10 @@ func (app *SimApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []
validator.Jailed = true
}
app.StakingKeeper.SetValidator(ctx, validator)
counter++
err = app.StakingKeeper.SetValidator(ctx, validator)
if err != nil {
panic(fmt.Errorf("unable to set validator: %w", err))
}
}
if err := iter.Close(); err != nil {
@ -222,12 +229,18 @@ func (app *SimApp) prepForZeroHeightGenesis(ctx sdk.Context, jailAllowedAddrs []
/* Handle slashing state. */
// reset start height on signing infos
app.SlashingKeeper.IterateValidatorSigningInfos(
err = app.SlashingKeeper.IterateValidatorSigningInfos(
ctx,
func(addr sdk.ConsAddress, info slashingtypes.ValidatorSigningInfo) (stop bool) {
info.StartHeight = 0
app.SlashingKeeper.SetValidatorSigningInfo(ctx, addr, info)
err = app.SlashingKeeper.SetValidatorSigningInfo(ctx, addr, info)
if err != nil {
panic("unable to set validator signing info")
}
return false
},
)
if err != nil {
panic(fmt.Errorf("error while iterating validator signing info: %w", err))
}
}

3
simapp/sim_test.go
View File

@ -296,10 +296,11 @@ func TestAppSimulationAfterImport(t *testing.T) {
newApp := NewSimApp(log.NewNopLogger(), newDB, nil, true, appOptions, fauxMerkleModeOpt, baseapp.SetChainID(SimAppChainID))
require.Equal(t, "SimApp", newApp.Name())
newApp.InitChain(&abci.RequestInitChain{
_, err = newApp.InitChain(&abci.RequestInitChain{
AppStateBytes: exported.AppState,
ChainId: SimAppChainID,
})
require.NoError(t, err)
_, _, err = simulation.SimulateFromSeed(
t,

7
simapp/simd/cmd/testnet.go
View File

@ -18,10 +18,6 @@ import (
"cosmossdk.io/math/unsafe"
"cosmossdk.io/simapp"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/client/tx"
@ -35,8 +31,11 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/module"
"github.com/cosmos/cosmos-sdk/version"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
"github.com/cosmos/cosmos-sdk/x/genutil"
genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types"
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
)
var (

1
store/iavl/store_test.go
View File

@ -639,7 +639,6 @@ func TestSetInitialVersion(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
db := dbm.NewMemDB()

1
store/pruning/manager_test.go
View File

@ -75,7 +75,6 @@ func TestStrategies(t *testing.T) {
}
for name, tc := range testcases {
tc := tc // Local copy to avoid shadowing.
t.Run(name, func(t *testing.T) {
t.Parallel()

1
store/types/iterator_test.go
View File

@ -84,7 +84,6 @@ func TestPaginatedIterator(t *testing.T) {
reverse: true,
},
} {
tc := tc
t.Run(tc.desc, func(t *testing.T) {
var iter types.Iterator
if tc.reverse {

1
store/types/store_test.go
View File

@ -53,7 +53,6 @@ func TestStoreUpgrades(t *testing.T) {
}
for name, tc := range cases {
tc := tc
t.Run(name, func(t *testing.T) {
for _, r := range tc.expectAdd {
assert.Equal(t, tc.upgrades.IsAdded(r.key), true)

12
types/coin_test.go
View File

@ -168,7 +168,6 @@ func (s *coinTestSuite) TestAddCoin() {
}
for tcIndex, tc := range cases {
tc := tc
if tc.shouldPanic {
s.Require().Panics(func() { tc.inputOne.Add(tc.inputTwo) })
} else {
@ -208,7 +207,6 @@ func (s *coinTestSuite) TestSubCoin() {
}
for tcIndex, tc := range cases {
tc := tc
if tc.shouldPanic {
s.Require().Panics(func() { tc.inputOne.Sub(tc.inputTwo) })
} else {
@ -264,7 +262,6 @@ func (s *coinTestSuite) TestMulIntCoins() {
assert := s.Assert()
for i, tc := range testCases {
tc := tc
if tc.shouldPanic {
assert.Panics(func() { tc.input.MulInt(tc.multiplier) })
} else {
@ -291,7 +288,6 @@ func (s *coinTestSuite) TestQuoIntCoins() {
assert := s.Assert()
for i, tc := range testCases {
tc := tc
if tc.shouldPanic {
assert.Panics(func() { tc.input.QuoInt(tc.divisor) })
} else {
@ -316,7 +312,6 @@ func (s *coinTestSuite) TestIsGTECoin() {
}
for tcIndex, tc := range cases {
tc := tc
if tc.panics {
s.Require().Panics(func() { tc.inputOne.IsGTE(tc.inputTwo) })
} else {
@ -340,7 +335,6 @@ func (s *coinTestSuite) TestIsLTECoin() {
}
for tcIndex, tc := range cases {
tc := tc
if tc.panics {
s.Require().Panics(func() { tc.inputOne.IsLTE(tc.inputTwo) })
} else {
@ -366,7 +360,6 @@ func (s *coinTestSuite) TestIsLTCoin() {
}
for tcIndex, tc := range cases {
tc := tc
if tc.panics {
s.Require().Panics(func() { tc.inputOne.IsLT(tc.inputTwo) })
} else {
@ -634,7 +627,6 @@ func (s *coinTestSuite) TestSubCoins() {
assert := s.Assert()
for i, tc := range testCases {
tc := tc
if tc.shouldPanic {
assert.Panics(func() { tc.inputOne.Sub(tc.inputTwo...) })
} else {
@ -659,7 +651,7 @@ func (s *coinTestSuite) TestSafeSubCoin() {
}
for _, tc := range cases {
tc := tc
res, err := tc.inputOne.SafeSub(tc.inputTwo)
if err != nil {
s.Require().Contains(err.Error(), tc.expErrMsg)
@ -1290,7 +1282,7 @@ func (s *coinTestSuite) TestCoinValidate() {
}
for _, tc := range testCases {
tc := tc
t := s.T()
t.Run(tc.name, func(t *testing.T) {
err := tc.coin.Validate()

1
types/context_test.go
View File

@ -213,7 +213,6 @@ func (s *contextTestSuite) TestContextHeaderClone() {
}
for name, tc := range cases {
tc := tc
s.T().Run(name, func(t *testing.T) {
ctx := types.NewContext(nil, tc.h, false, nil)
s.Require().Equal(tc.h.Height, ctx.BlockHeight())

14
types/dec_coin_test.go
View File

@ -211,7 +211,6 @@ func (s *decCoinTestSuite) TestIsValid() {
}
for _, tc := range tests {
tc := tc
if tc.expectPass {
s.Require().True(tc.coin.IsValid(), tc.msg)
} else {
@ -246,7 +245,6 @@ func (s *decCoinTestSuite) TestSubDecCoin() {
decCoin := sdk.NewDecCoin("mytoken", math.NewInt(10))
for _, tc := range tests {
tc := tc
if tc.expectPass {
equal := tc.coin.Sub(decCoin)
s.Require().Equal(equal, decCoin, tc.msg)
@ -282,7 +280,6 @@ func (s *decCoinTestSuite) TestSubDecCoins() {
decCoins := sdk.NewDecCoinsFromCoins(sdk.NewCoin("btc", math.NewInt(10)), sdk.NewCoin("eth", math.NewInt(15)), sdk.NewCoin("mytoken", math.NewInt(5)))
for _, tc := range tests {
tc := tc
if tc.expectPass {
equal := tc.coins.Sub(decCoins)
s.Require().Equal(equal, decCoins, tc.msg)
@ -524,7 +521,6 @@ func (s *decCoinTestSuite) TestDecCoinsQuoDecTruncate() {
}
for i, tc := range testCases {
tc := tc
if tc.panics {
s.Require().Panics(func() { tc.coins.QuoDecTruncate(tc.input) })
} else {
@ -561,7 +557,6 @@ func (s *decCoinTestSuite) TestNewDecCoinsWithIsValid() {
}
for _, tc := range tests {
tc := tc
if tc.expectPass {
s.Require().True(tc.coin.IsValid(), tc.msg)
} else {
@ -588,7 +583,6 @@ func (s *decCoinTestSuite) TestNewDecCoinsWithZeroCoins() {
}
for _, tc := range tests {
tc := tc
s.Require().Equal(sdk.NewDecCoinsFromCoins(tc.coins...).Len(), tc.expectLength)
}
}
@ -620,7 +614,6 @@ func (s *decCoinTestSuite) TestDecCoins_AddDecCoinWithIsValid() {
}
for _, tc := range tests {
tc := tc
if tc.expectPass {
s.Require().True(tc.coin.IsValid(), tc.msg)
} else {
@ -676,7 +669,6 @@ func (s *decCoinTestSuite) TestDecCoins_GetDenomByIndex() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.expectedErr {
s.Require().Panics(func() { tc.input.GetDenomByIndex(tc.index) }, "Test should have panicked")
@ -718,7 +710,6 @@ func (s *decCoinTestSuite) TestDecCoins_IsAllPositive() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.expectedResult {
s.Require().True(tc.input.IsAllPositive(), "Test case #%d: %s", i, tc.name)
@ -788,7 +779,6 @@ func (s *decCoinTestSuite) TestDecCoin_IsGTE() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.expectedPanic {
s.Require().Panics(func() { tc.coin.IsGTE(tc.otherCoin) }, "Test case #%d: %s", i, tc.name)
@ -832,7 +822,6 @@ func (s *decCoinTestSuite) TestDecCoins_IsZero() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.expectedResult {
s.Require().True(tc.coins.IsZero(), "Test case #%d: %s", i, tc.name)
@ -887,7 +876,6 @@ func (s *decCoinTestSuite) TestDecCoins_MulDec() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
res := tc.coins.MulDec(tc.multiplier)
s.Require().Equal(tc.expectedResult, res, "Test case #%d: %s", i, tc.name)
@ -936,7 +924,6 @@ func (s *decCoinTestSuite) TestDecCoins_MulDecTruncate() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.expectedPanic {
s.Require().Panics(func() { tc.coins.MulDecTruncate(tc.multiplier) }, "Test case #%d: %s", i, tc.name)
@ -989,7 +976,6 @@ func (s *decCoinTestSuite) TestDecCoins_QuoDec() {
}
for i, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
if tc.panics {
s.Require().Panics(func() { tc.coins.QuoDec(tc.input) }, "Test case #%d: %s", i, tc.name)

1
types/events_test.go
View File

@ -268,7 +268,6 @@ func (s *eventsTestSuite) TestMarkEventsToIndex() {
}
for name, tc := range testCases {
tc := tc
s.T().Run(name, func(_ *testing.T) {
s.Require().Equal(tc.expected, sdk.MarkEventsToIndex(tc.events, tc.indexSet))
})

2
types/tx/direct_aux_test.go
View File

@ -33,7 +33,6 @@ func TestSignDocDirectAux(t *testing.T) {
}
for _, tc := range testcases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.sd.ValidateBasic()
@ -68,7 +67,6 @@ func TestAuxSignerData(t *testing.T) {
}
for _, tc := range testcases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.sd.ValidateBasic()

3
types/utils_test.go
View File

@ -33,7 +33,6 @@ func (s *utilsTestSuite) TestTimeFormatAndParse() {
{"2011-01-10T23:10:05.758230235Z", "2011-01-10T23:10:05.758230235", true},
}
for _, tc := range cases {
tc := tc
timeFromRFC, err := time.Parse(time.RFC3339Nano, tc.RFC3339NanoStr)
s.Require().Nil(err)
timeFromSDKFormat, err := time.Parse(sdk.SortableTimeFormat, tc.SDKSortableTimeStr)
@ -116,8 +115,6 @@ func (s *utilsTestSuite) TestParseTime() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
tm, err := sdk.ParseTime(tc.input)
if tc.expectErr {

1
x/auth/ante/basic_test.go
View File

@ -214,7 +214,6 @@ func TestTxHeightTimeoutDecorator(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
suite.txBuilder = suite.clientCtx.TxConfig.NewTxBuilder()

1
x/auth/keeper/msg_server_test.go
View File

@ -97,7 +97,6 @@ func (s *KeeperTestSuite) TestUpdateParams() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
_, err := s.msgServer.UpdateParams(s.ctx, tc.req)
if tc.expectErr {

1
x/auth/migrations/legacytx/stdtx_test.go
View File

@ -90,7 +90,6 @@ func TestStdSignBytes(t *testing.T) {
FileResolver: proto.HybridResolver,
})
for i, tc := range tests {
tc := tc
t.Run(tc.name, func(t *testing.T) {
anyMsgs := make([]*anypb.Any, len(tc.args.msgs))
for j, msg := range tc.args.msgs {

1
x/auth/tx/aux_test.go
View File

@ -98,7 +98,6 @@ func TestBuilderWithAux(t *testing.T) {
{"happy case", func() {}, false},
}
for _, tc := range testcases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
txBuilder, txSig = makeTxBuilder(t)

1
x/authz/authorization_grant_test.go
View File

@ -34,7 +34,6 @@ func TestNewGrant(t *testing.T) {
}
for _, tc := range tcs {
tc := tc
t.Run(tc.title, func(t *testing.T) {
_, err := NewGrant(tc.blockTime, tc.a, tc.expire)
expecError(require.New(t), tc.err, err)

3
x/authz/client/cli/tx_test.go
View File

@ -592,7 +592,6 @@ func (s *CLITestSuite) TestCmdRevokeAuthorizations() {
},
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdRevokeAuthorization(addresscodec.NewBech32Codec("cosmos"))
@ -727,7 +726,6 @@ func (s *CLITestSuite) TestNewExecGenericAuthorized() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdExecAuthorization()
@ -812,7 +810,6 @@ func (s *CLITestSuite) TestNewExecGrantAuthorized() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdExecAuthorization()
clientCtx := s.clientCtx

1
x/authz/keeper/grpc_query_test.go
View File

@ -183,7 +183,6 @@ func (suite *TestSuite) TestGRPCQueryGranterGrants() {
}
for _, tc := range testCases {
tc := tc
suite.Run(fmt.Sprintf("Case %s", tc.msg), func() {
tc.preRun()
result, err := queryClient.GranterGrants(gocontext.Background(), &tc.request)

2
x/bank/client/cli/tx_test.go
View File

@ -111,7 +111,6 @@ func (s *CLITestSuite) TestSendTxCmd() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
args := append([]string{tc.from.String(), tc.to.String(), tc.amount.String()}, tc.extraArgs...)
@ -224,7 +223,6 @@ func (s *CLITestSuite) TestMultiSendTxCmd() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
ctx := svrcmd.CreateExecuteContext(context.Background())

1
x/bank/keeper/genesis_test.go
View File

@ -113,7 +113,6 @@ func (suite *KeeperTestSuite) TestTotalSupply() {
}
for _, tc := range testcases {
tc := tc
suite.Run(tc.name, func() {
if tc.expPanic {
suite.PanicsWithError(tc.expPanicMsg, func() { suite.bankKeeper.InitGenesis(suite.ctx, tc.genesis) })

1
x/bank/keeper/grpc_query_test.go
View File

@ -78,7 +78,6 @@ func (suite *KeeperTestSuite) TestQueryBalance() {
}
for _, tc := range testCases {
tc := tc
suite.Run(tc.name, func() {
res, err := queryClient.Balance(gocontext.Background(), tc.req)

1
x/bank/types/balance_test.go
View File

@ -103,7 +103,6 @@ func TestBalanceValidate(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.balance.Validate()

1
x/bank/types/genesis_test.go
View File

@ -146,7 +146,6 @@ func TestGenesisStateValidate(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(tt *testing.T) {
err := tc.genesisState.Validate()

2
x/bank/types/metadata_test.go
View File

@ -216,7 +216,6 @@ func TestMetadataValidate(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.metadata.Validate()
@ -258,7 +257,6 @@ func TestMarshalJSONMetaData(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
bz, err := cdc.MarshalJSON(tc.input)
require.NoError(t, err)

1
x/consensus/keeper/keeper_test.go
View File

@ -292,7 +292,6 @@ func (s *KeeperTestSuite) TestUpdateParams() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
s.SetupTest()
_, err := s.consensusParamsKeeper.UpdateParams(s.ctx, tc.input)

1
x/evidence/keeper/msg_server_test.go
View File

@ -66,7 +66,6 @@ func (s *KeeperTestSuite) TestSubmitEvidence() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
_, err := s.msgServer.SubmitEvidence(s.ctx, tc.req)
if tc.expErr {

1
x/evidence/types/evidence_test.go
View File

@ -65,7 +65,6 @@ func TestEquivocationValidateBasic(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
require.Equal(t, tc.expectErr, tc.e.ValidateBasic() != nil)
})

1
x/feegrant/client/cli/tx_test.go
View File

@ -412,7 +412,6 @@ func (s *CLITestSuite) TestNewCmdFeeGrant() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdFeeGrant(codecaddress.NewBech32Codec("cosmos"))

1
x/feegrant/grant_test.go
View File

@ -80,7 +80,6 @@ func TestGrant(t *testing.T) {
}
for name, tc := range cases {
tc := tc
t.Run(name, func(t *testing.T) {
grant, err := feegrant.NewGrant(tc.granter, tc.grantee, &feegrant.BasicAllowance{
SpendLimit: tc.limit,

1
x/feegrant/keeper/genesis_test.go
View File

@ -130,7 +130,6 @@ func TestInitGenesis(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
f := initFixture(t)
if !tc.invalidAddr {

3
x/feegrant/keeper/keeper_test.go
View File

@ -159,7 +159,6 @@ func (suite *KeeperTestSuite) TestKeeperCrud() {
}
for name, tc := range cases {
tc := tc
suite.Run(name, func() {
allow, _ := suite.feegrantKeeper.GetAllowance(suite.ctx, tc.granter, tc.grantee)
@ -253,7 +252,6 @@ func (suite *KeeperTestSuite) TestUseGrantedFee() {
}
for name, tc := range cases {
tc := tc
suite.Run(name, func() {
err := suite.feegrantKeeper.GrantAllowance(suite.ctx, tc.granter, tc.grantee, future)
suite.Require().NoError(err)
@ -389,7 +387,6 @@ func (suite *KeeperTestSuite) TestPruneGrants() {
}
for _, tc := range testCases {
tc := tc
suite.Run(tc.name, func() {
if tc.preRun != nil {
tc.preRun()

1
x/genutil/client/cli/gentx_test.go
View File

@ -113,7 +113,6 @@ func (s *CLITestSuite) TestGenTxCmd() {
}
for _, tc := range tests {
tc := tc
dir := s.T().TempDir()
genTxFile := filepath.Join(dir, "myTx")

1
x/genutil/client/cli/migrate_test.go
View File

@ -53,7 +53,6 @@ func TestMigrateGenesis(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
genesisFile := testutil.WriteToNewTempFile(t, tc.genesis)
jsonOutput, err := clitestutil.ExecTestCLICmd(

1
x/genutil/client/cli/validate_genesis_test.go
View File

@ -80,7 +80,6 @@ func TestValidateGenesis(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
genesisFile := testutil.WriteToNewTempFile(t, tc.genesis)

8
x/gov/client/cli/tx_test.go
View File

@ -155,8 +155,6 @@ func (s *CLITestSuite) TestNewCmdSubmitProposal() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdSubmitProposal()
@ -249,8 +247,6 @@ func (s *CLITestSuite) TestNewCmdSubmitLegacyProposal() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdSubmitLegacyProposal()
@ -314,8 +310,6 @@ func (s *CLITestSuite) TestNewCmdDeposit() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdDeposit()
@ -393,7 +387,6 @@ func (s *CLITestSuite) TestNewCmdVote() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdVote()
out, err := clitestutil.ExecTestCLICmd(s.clientCtx, cmd, tc.args)
@ -494,7 +487,6 @@ func (s *CLITestSuite) TestNewCmdWeightedVote() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
cmd := cli.NewCmdWeightedVote()
out, err := clitestutil.ExecTestCLICmd(s.clientCtx, cmd, tc.args)

1
x/gov/client/utils/query_test.go
View File

@ -140,7 +140,6 @@ func TestGetPaginatedVotes(t *testing.T) {
},
},
} {
tc := tc
t.Run(tc.description, func(t *testing.T) {
marshaled := make([]cmttypes.Tx, len(tc.msgs))

1
x/gov/keeper/msg_server_test.go
View File

@ -1688,7 +1688,6 @@ func (suite *KeeperTestSuite) TestMsgUpdateParams() {
}
for _, tc := range testCases {
tc := tc
suite.Run(tc.name, func() {
msg := tc.input()
exec := func(updateParams *v1.MsgUpdateParams) error {

1
x/gov/migrations/v3/convert_test.go
View File

@ -49,7 +49,6 @@ func TestConvertToLegacyProposal(t *testing.T) {
for name, tc := range testCases {
t.Run(name, func(t *testing.T) {
tc := tc
proposal.FinalTallyResult = &tc.tallyResult
v1beta1Proposal, err := v3.ConvertToLegacyProposal(proposal)
if tc.expErr {

1
x/gov/types/v1/genesis_test.go
View File

@ -173,7 +173,6 @@ func TestValidateGenesis(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := v1.ValidateGenesis(tc.genesisState())
if tc.expErrMsg != "" {

4
x/group/client/cli/tx_test.go
View File

@ -207,7 +207,6 @@ func (s *CLITestSuite) TestTxCreateGroup() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
ctx := svrcmd.CreateExecuteContext(context.Background())
@ -335,7 +334,6 @@ func (s *CLITestSuite) TestTxUpdateGroupAdmin() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
ctx := svrcmd.CreateExecuteContext(context.Background())
@ -430,7 +428,6 @@ func (s *CLITestSuite) TestTxUpdateGroupMetadata() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
ctx := svrcmd.CreateExecuteContext(context.Background())
@ -545,7 +542,6 @@ func (s *CLITestSuite) TestTxUpdateGroupMembers() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
ctx := svrcmd.CreateExecuteContext(context.Background())

1
x/group/genesis_test.go
View File

@ -735,7 +735,6 @@ func TestGenesisStateValidate(t *testing.T) {
},
}
for _, tc := range testCases {
tc := tc
t.Run(tc.name, func(t *testing.T) {
err := tc.genesisState.Validate()
if tc.expErr {

1
x/mint/keeper/msg_server_test.go
View File

@ -60,7 +60,6 @@ func (s *IntegrationTestSuite) TestUpdateParams() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
_, err := s.msgServer.UpdateParams(s.ctx, tc.request)
if tc.expectErr {

2
x/slashing/keeper/msg_server_test.go
View File

@ -132,7 +132,6 @@ func (s *KeeperTestSuite) TestUpdateParams() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
_, err := s.msgServer.UpdateParams(s.ctx, tc.request)
if tc.expectErr {
@ -318,7 +317,6 @@ func (s *KeeperTestSuite) TestUnjail() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
req := tc.malleate()
_, err := s.msgServer.Unjail(s.ctx, req)

4
x/staking/client/cli/tx_test.go
View File

@ -145,7 +145,6 @@ func (s *CLITestSuite) TestPrepareConfigForTxCreateValidator() {
}
for _, tc := range tests {
tc := tc
s.Run(tc.name, func() {
fs, _ := cli.CreateValidatorMsgFlagSet(ip)
fs.String(flags.FlagName, "", "name of private key with which to sign the gentx")
@ -292,7 +291,6 @@ func (s *CLITestSuite) TestNewCreateValidatorCmd() {
},
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
out, err := clitestutil.ExecTestCLICmd(s.clientCtx, cmd, tc.args)
if tc.expectErrMsg != "" {
@ -415,8 +413,6 @@ func (s *CLITestSuite) TestNewEditValidatorCmd() {
}
for _, tc := range testCases {
tc := tc
s.Run(tc.name, func() {
out, err := clitestutil.ExecTestCLICmd(s.clientCtx, cmd, tc.args)
if tc.expectErrMsg != "" {

7
x/staking/keeper/msg_server_test.go
View File

@ -227,7 +227,6 @@ func (s *KeeperTestSuite) TestMsgCreateValidator() {
},
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.CreateValidator(ctx, tc.input)
if tc.expErr {
@ -403,7 +402,6 @@ func (s *KeeperTestSuite) TestMsgEditValidator() {
},
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.EditValidator(tc.ctx, tc.input)
if tc.expErr {
@ -521,7 +519,6 @@ func (s *KeeperTestSuite) TestMsgDelegate() {
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.Delegate(ctx, tc.input)
if tc.expErr {
@ -689,7 +686,6 @@ func (s *KeeperTestSuite) TestMsgBeginRedelegate() {
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.BeginRedelegate(ctx, tc.input)
if tc.expErr {
@ -813,7 +809,6 @@ func (s *KeeperTestSuite) TestMsgUndelegate() {
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.Undelegate(ctx, tc.input)
if tc.expErr {
@ -975,7 +970,6 @@ func (s *KeeperTestSuite) TestMsgCancelUnbondingDelegation() {
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.CancelUnbondingDelegation(ctx, tc.input)
if tc.expErr {
@ -1114,7 +1108,6 @@ func (s *KeeperTestSuite) TestMsgUpdateParams() {
}
for _, tc := range testCases {
tc := tc
s.T().Run(tc.name, func(t *testing.T) {
_, err := msgServer.UpdateParams(ctx, tc.input)
if tc.expErr {

1
x/staking/types/authz_test.go
View File

@ -353,7 +353,6 @@ func TestAuthzAuthorizations(t *testing.T) {
}
for _, tc := range testCases {
tc := tc
t.Run(tc.msg, func(t *testing.T) {
delAuth, err := stakingtypes.NewStakeAuthorization(tc.allowed, tc.denied, tc.msgType, tc.limit)
require.NoError(t, err)

1
x/upgrade/keeper/keeper_test.go
View File

@ -169,7 +169,6 @@ func (s *KeeperTestSuite) TestScheduleUpgrade() {
}
for _, tc := range cases {
tc := tc
s.Run(tc.name, func() {
// reset suite

3
x/upgrade/types/plan_test.go
View File

@ -42,7 +42,6 @@ func TestPlanString(t *testing.T) {
}
for name, tc := range cases {
tc := tc // copy to local variable for scopelint
t.Run(name, func(t *testing.T) {
s := tc.p.String()
require.Equal(t, tc.expect, s)
@ -93,7 +92,6 @@ func TestPlanValid(t *testing.T) {
}
for name, tc := range cases {
tc := tc // copy to local variable for scopelint
t.Run(name, func(t *testing.T) {
err := tc.p.ValidateBasic()
if tc.valid {
@ -142,7 +140,6 @@ func TestShouldExecute(t *testing.T) {
}
for name, tc := range cases {
tc := tc // copy to local variable for scopelint
t.Run(name, func(t *testing.T) {
should := tc.p.ShouldExecute(tc.ctxHeight)
assert.Equal(t, tc.expected, should)

1
x/upgrade/types/storeloader_test.go
View File

@ -106,7 +106,6 @@ func TestSetLoader(t *testing.T) {
v := []byte("value")
for name, tc := range cases {
tc := tc
t.Run(name, func(t *testing.T) {
// prepare a db with some data
db := dbm.NewMemDB()