LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix(cosmovisor): fixed cosmovisor add-upgrade permissions (#20062)

Browse Source
This commit is contained in:
Sergey 2024-05-02 17:17:15 +03:00 committed by GitHub
parent 2e39dcb5dd
commit 8f10576177
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/cosmovisor/CHANGELOG.md
View File

@ -35,6 +35,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
# Changelog
## [Unreleased]
* [#20062](https://github.com/cosmos/cosmos-sdk/pull/20062) Fixed cosmovisor add-upgrade permissions
## v1.5.0 - 2023-07-17

8
tools/cosmovisor/cmd/cosmovisor/add_upgrade.go
View File

@ -5,7 +5,6 @@ import (
"fmt"
"os"
"path"
"path/filepath"
"strings"
"github.com/spf13/cobra"
@ -54,7 +53,7 @@ func AddUpgrade(cmd *cobra.Command, args []string) error {
// create upgrade dir
upgradeLocation := cfg.UpgradeDir(upgradeName)
if err := os.MkdirAll(path.Join(upgradeLocation, "bin"), 0o750); err != nil {
if err := os.MkdirAll(path.Join(upgradeLocation, "bin"), 0o755); err != nil {
return fmt.Errorf("failed to create upgrade directory: %w", err)
}
@ -94,7 +93,7 @@ func AddUpgrade(cmd *cobra.Command, args []string) error {
return err
}
logger.Info(fmt.Sprintf("%s created, %s upgrade binary will switch at height %d", filepath.Join(cfg.UpgradeInfoFilePath(), upgradetypes.UpgradeInfoFilename), upgradeName, upgradeHeight))
logger.Info(fmt.Sprintf("%s created, %s upgrade binary will switch at height %d", cfg.UpgradeInfoFilePath(), upgradeName, upgradeHeight))
}
return nil
@ -110,7 +109,8 @@ func saveOrAbort(path string, data []byte, force bool) error {
return fmt.Errorf("failed to check if file exists: %w", err)
}
if err := os.WriteFile(path, data, 0o600); err != nil {
//nolint:gosec // We need broader permissions to make it executable
if err := os.WriteFile(path, data, 0o755); err != nil {
return fmt.Errorf("failed to write binary to location: %w", err)
}