From 8ee472830f661adbec58eff18a4acc0fa09a479a Mon Sep 17 00:00:00 2001 From: Aaron Craelius Date: Wed, 25 May 2022 11:03:10 -0400 Subject: [PATCH] fix: sims missing app name (#12045) ## Description This was causing the following sims failure: ``` --- FAIL: TestAppSimulationAfterImport (0.09s) sim_test.go:222: Error Trace: sim_test.go:222 Error: Not equal: expected: "SimApp" actual : "" Diff: --- Expected +++ Actual @@ -1 +1 @@ -SimApp + ``` --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- simapp/app.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/simapp/app.yaml b/simapp/app.yaml index 82ceeb8450..b4f037daa7 100644 --- a/simapp/app.yaml +++ b/simapp/app.yaml @@ -3,6 +3,8 @@ modules: config: "@type": cosmos.app.runtime.v1alpha1.Module + app_name: SimApp + # During begin block slashing happens after distr.BeginBlocker so that # there is nothing left over in the validator fee pool, so as to keep the # CanWithdrawInvariant invariant.