From 8c24b6bef1f7480314aaade52f6b2154413856f2 Mon Sep 17 00:00:00 2001 From: Julien Robert Date: Tue, 5 Nov 2024 13:02:47 +0400 Subject: [PATCH] fix(x/group): proper address rendering in error (#22425) --- x/group/keeper/proposal_executor.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/x/group/keeper/proposal_executor.go b/x/group/keeper/proposal_executor.go index 4ecef52d19..24d372daca 100644 --- a/x/group/keeper/proposal_executor.go +++ b/x/group/keeper/proposal_executor.go @@ -70,7 +70,13 @@ func ensureMsgAuthZ(msgs []sdk.Msg, groupPolicyAcc sdk.AccAddress, cdc codec.Cod if err != nil { return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; error retrieving group policy address") } - return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acct) + + acctStr, _ := addressCodec.BytesToString(acct) + if acctStr == "" { + acctStr = "unmarshalable address" + } + + return errorsmod.Wrapf(sdkerrors.ErrUnauthorized, "msg does not have group policy authorization; expected %s, got %s", groupPolicyAddr, acctStr) } } }