From 884ce49f7ff35bc8460e4e2f6acf27eb78656faa Mon Sep 17 00:00:00 2001 From: Alessio Treglia Date: Fri, 1 Feb 2019 17:03:57 -0800 Subject: [PATCH] allow generation of gentxs with empty memo field (#3478) --- PENDING.md | 1 + cmd/gaia/init/gentx.go | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/PENDING.md b/PENDING.md index 75c3c799bf..3f62c3b349 100644 --- a/PENDING.md +++ b/PENDING.md @@ -51,6 +51,7 @@ IMPROVEMENTS * [\#3418](https://github.com/cosmos/cosmos-sdk/issues/3418) Add vesting account genesis validation checks to `GaiaValidateGenesisState`. * [\#3420](https://github.com/cosmos/cosmos-sdk/issues/3420) Added maximum length to governance proposal descriptions and titles + * [\#3424](https://github.com/cosmos/cosmos-sdk/issues/3424) Allow generation of gentxs with empty memo field. * SDK * [\#2986](https://github.com/cosmos/cosmos-sdk/pull/2986) Store Refactor diff --git a/cmd/gaia/init/gentx.go b/cmd/gaia/init/gentx.go index 142a9801e0..ec3ae35739 100644 --- a/cmd/gaia/init/gentx.go +++ b/cmd/gaia/init/gentx.go @@ -61,9 +61,11 @@ following delegation and commission default parameters: if err != nil { return err } + ip, err := server.ExternalIP() if err != nil { - return err + fmt.Fprintf(os.Stderr, "couldn't retrieve an external IP, "+ + "consequently the tx's memo field will be unset: %s", err) } genDoc, err := LoadGenesisDoc(cdc, config.GenesisFile())