LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix: avoid cli redundant log in stdout (#19371)

Browse Source
This commit is contained in:
mmsqe 2024-02-08 02:31:47 +08:00 committed by GitHub
parent 4b8f32657b
commit 863194f99c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -94,6 +94,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
* (baseapp) [#18551](https://github.com/cosmos/cosmos-sdk/pull/18551) Fix SelectTxForProposal the calculation method of tx bytes size is inconsistent with CometBFT
* (abci): [#19200](https://github.com/cosmos/cosmos-sdk/pull/19200) Ensure that sdk side ve math matches cometbft
* (server) [#18994](https://github.com/cosmos/cosmos-sdk/pull/18994) Update server context directly rather than a reference to a sub-object
* (crypto) [#19371](https://github.com/cosmos/cosmos-sdk/pull/19371) Avoid cli redundant log in stdout, log to stderr instead.
### API Breaking Changes

4
crypto/keyring/keyring.go
View File

@ -916,7 +916,7 @@ func (ks keystore) MigrateAll() ([]*Record, error) {
rec, err := ks.migrate(key)
if err != nil {
fmt.Printf("migrate err for key %s: %q\n", key, err)
fmt.Fprintf(os.Stderr, "migrate err for key %s: %q\n", key, err)
continue
}
@ -990,7 +990,7 @@ func (ks keystore) migrate(key string) (*Record, error) {
return nil, errorsmod.Wrap(err, "unable to set keyring.Item")
}
fmt.Printf("Successfully migrated key %s.\n", key)
fmt.Fprintf(os.Stderr, "Successfully migrated key %s.\n", key)
return k, nil
}