From 7f69b088d92170f596e4374497fd8f8280a26782 Mon Sep 17 00:00:00 2001 From: Emmanuel T Odeke Date: Fri, 10 Jul 2020 03:34:43 -0700 Subject: [PATCH] types: fix invalid int->string conversion in benchmarks (#6678) Fixes an invalid int->string conversion that will become a vet error for Go1.15. The correct conversion was to use fmt.Sprintf("COINZ_%d", i) instead of "COINZ_" + string(i) Noticed during a coverage audit. --- types/coin_benchmark_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/types/coin_benchmark_test.go b/types/coin_benchmark_test.go index 34e93d6229..fc73afe87a 100644 --- a/types/coin_benchmark_test.go +++ b/types/coin_benchmark_test.go @@ -5,6 +5,10 @@ import ( "testing" ) +func coinName(suffix int) string { + return fmt.Sprintf("COINZ_%d", suffix) +} + func BenchmarkCoinsAdditionIntersect(b *testing.B) { benchmarkingFunc := func(numCoinsA int, numCoinsB int) func(b *testing.B) { return func(b *testing.B) { @@ -12,10 +16,10 @@ func BenchmarkCoinsAdditionIntersect(b *testing.B) { coinsB := Coins(make([]Coin, numCoinsB)) for i := 0; i < numCoinsA; i++ { - coinsA[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i))) + coinsA[i] = NewCoin(coinName(i), NewInt(int64(i))) } for i := 0; i < numCoinsB; i++ { - coinsB[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i))) + coinsB[i] = NewCoin(coinName(i), NewInt(int64(i))) } b.ResetTimer() @@ -41,10 +45,10 @@ func BenchmarkCoinsAdditionNoIntersect(b *testing.B) { coinsB := Coins(make([]Coin, numCoinsB)) for i := 0; i < numCoinsA; i++ { - coinsA[i] = NewCoin("COINZ_"+string(numCoinsB+i), NewInt(int64(i))) + coinsA[i] = NewCoin(coinName(numCoinsB+i), NewInt(int64(i))) } for i := 0; i < numCoinsB; i++ { - coinsB[i] = NewCoin("COINZ_"+string(i), NewInt(int64(i))) + coinsB[i] = NewCoin(coinName(i), NewInt(int64(i))) } b.ResetTimer()