fix(client/keys): don't return when key not found in keys delete (#18562)

This commit is contained in:
Julián Toledano
2023-11-27 12:08:53 +00:00
committed by GitHub
parent 02b1b0089e
commit 7d5c2dbae6
3 changed files with 4 additions and 3 deletions
+2 -1
View File
@@ -37,7 +37,8 @@ private keys stored in a ledger device cannot be deleted with the CLI.
for _, name := range args {
k, err := clientCtx.Keyring.Key(name)
if err != nil {
return err
cmd.PrintErrf("key %s not found\n", name)
continue
}
// confirm deletion, unless -y is passed
+1 -2
View File
@@ -53,8 +53,7 @@ func Test_runDeleteCmd(t *testing.T) {
ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
err = cmd.ExecuteContext(ctx)
require.Error(t, err)
require.EqualError(t, err, "blah.info: key not found")
require.NoError(t, err)
// User confirmation missing
cmd.SetArgs([]string{