From 7818b36f4226c2f27bc1d9fa0e759ea8bb0755a2 Mon Sep 17 00:00:00 2001 From: strmfos <155266597+strmfos@users.noreply.github.com> Date: Tue, 29 Jul 2025 16:01:33 +0200 Subject: [PATCH] fix: typos across the codebase (#25035) --- .../staking/keeper/unbonding_test.go | 26 ++++++------- x/auth/migrations/v2/store_test.go | 38 +++++++++---------- x/auth/tx/sigs.go | 2 +- x/auth/types/credentials.go | 2 +- x/auth/types/credentials_test.go | 2 +- x/auth/vesting/autocli.go | 2 +- x/authz/authorization_grant_test.go | 4 +- x/authz/simulation/decoder.go | 2 +- 8 files changed, 39 insertions(+), 39 deletions(-) diff --git a/tests/integration/staking/keeper/unbonding_test.go b/tests/integration/staking/keeper/unbonding_test.go index 5f730f6998..d394706190 100644 --- a/tests/integration/staking/keeper/unbonding_test.go +++ b/tests/integration/staking/keeper/unbonding_test.go @@ -23,9 +23,9 @@ func SetupUnbondingTests(t *testing.T, f *fixture, hookCalled *bool, ubdeID *uin // setup hooks mockCtrl := gomock.NewController(t) - mockStackingHooks := testutil.NewMockStakingHooks(mockCtrl) - mockStackingHooks.EXPECT().AfterDelegationModified(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().AfterUnbondingInitiated(gomock.Any(), gomock.Any()).DoAndReturn(func(ctx sdk.Context, id uint64) error { + mockStakingHooks := testutil.NewMockStakingHooks(mockCtrl) + mockStakingHooks.EXPECT().AfterDelegationModified(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().AfterUnbondingInitiated(gomock.Any(), gomock.Any()).DoAndReturn(func(ctx sdk.Context, id uint64) error { *hookCalled = true // save id *ubdeID = id @@ -35,16 +35,16 @@ func SetupUnbondingTests(t *testing.T, f *fixture, hookCalled *bool, ubdeID *uin return nil }).AnyTimes() - mockStackingHooks.EXPECT().AfterValidatorBeginUnbonding(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().AfterValidatorBonded(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().AfterValidatorCreated(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().AfterValidatorRemoved(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().BeforeDelegationCreated(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().BeforeDelegationRemoved(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().BeforeDelegationSharesModified(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().BeforeValidatorModified(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - mockStackingHooks.EXPECT().BeforeValidatorSlashed(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() - f.stakingKeeper.SetHooks(types.NewMultiStakingHooks(mockStackingHooks)) + mockStakingHooks.EXPECT().AfterValidatorBeginUnbonding(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().AfterValidatorBonded(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().AfterValidatorCreated(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().AfterValidatorRemoved(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().BeforeDelegationCreated(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().BeforeDelegationRemoved(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().BeforeDelegationSharesModified(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().BeforeValidatorModified(gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + mockStakingHooks.EXPECT().BeforeValidatorSlashed(gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes() + f.stakingKeeper.SetHooks(types.NewMultiStakingHooks(mockStakingHooks)) addrDels = simtestutil.AddTestAddrsIncremental(f.bankKeeper, f.stakingKeeper, f.sdkCtx, 2, math.NewInt(10000)) addrVals = simtestutil.ConvertAddrsToValAddrs(addrDels) diff --git a/x/auth/migrations/v2/store_test.go b/x/auth/migrations/v2/store_test.go index 3238055ba9..3021553273 100644 --- a/x/auth/migrations/v2/store_test.go +++ b/x/auth/migrations/v2/store_test.go @@ -115,7 +115,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(100), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 0, 300, @@ -138,7 +138,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 0, 300, @@ -165,7 +165,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(100), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 0, 300, @@ -186,7 +186,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 200, 100, @@ -211,7 +211,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(100), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 200, 100, @@ -236,7 +236,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(100), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 300, 0, @@ -257,7 +257,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 300, 0, @@ -280,7 +280,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 0, 300, @@ -305,7 +305,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 300, 0, @@ -330,7 +330,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 200, 100, @@ -355,7 +355,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(300), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 0, 300, @@ -386,7 +386,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(150), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 300, 100, 50, @@ -433,7 +433,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(3666666670000), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 3666666670000, 3666666670000, 0, @@ -482,7 +482,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(3666666670000), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 3666666670000, 0, 3666666670000, @@ -531,7 +531,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(3666666670000), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 3666666670000, 3666666670000 - 1833333335000, 1833333335000, @@ -580,7 +580,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, err = stakingKeeper.Delegate(ctx, delegatorAddr, sdkmath.NewInt(3666666670000), stakingtypes.Unbonded, validator, true) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 3666666670000, 3666666670000 - 1833333335000 - 916666667500, 1833333335000 + 916666667500, @@ -612,7 +612,7 @@ func TestMigrateVestingAccounts(t *testing.T) { _, _, err = stakingKeeper.Undelegate(ctx, delegatorAddr, valAddr, sdkmath.LegacyNewDecFromInt(sdkmath.NewInt(300))) require.NoError(t, err) }, - cleartTrackingFields, + clearTrackingFields, 450, 300, 0, @@ -631,7 +631,7 @@ func TestMigrateVestingAccounts(t *testing.T) { accountKeeper.SetAccount(ctx, delayedAccount) }, - cleartTrackingFields, + clearTrackingFields, 450, 0, 0, @@ -723,7 +723,7 @@ func trackingCorrected(t *testing.T, ctx sdk.Context, ak keeper.AccountKeeper, a require.True(t, freeOk, vDA.GetDelegatedFree().String()) } -func cleartTrackingFields(ctx sdk.Context, vesting exported.VestingAccount, accountKeeper keeper.AccountKeeper) error { +func clearTrackingFields(ctx sdk.Context, vesting exported.VestingAccount, accountKeeper keeper.AccountKeeper) error { switch t := vesting.(type) { case *types.DelayedVestingAccount: t.DelegatedFree = nil diff --git a/x/auth/tx/sigs.go b/x/auth/tx/sigs.go index 7d4716acec..7e54cad775 100644 --- a/x/auth/tx/sigs.go +++ b/x/auth/tx/sigs.go @@ -96,7 +96,7 @@ func decodeMultisignatures(bz []byte) ([][]byte, error) { if err != nil { return nil, err } - // NOTE: it is import to reject multi-signatures that contain unrecognized fields because this is an exploitable + // NOTE: it is important to reject multi-signatures that contain unrecognized fields because this is an exploitable // malleability in the protobuf message. Basically an attacker could bloat a MultiSignature message with unknown // fields, thus bloating the transaction and causing it to fail. if len(multisig.XXX_unrecognized) > 0 { diff --git a/x/auth/types/credentials.go b/x/auth/types/credentials.go index 4c63fc8d8c..72051ddbee 100644 --- a/x/auth/types/credentials.go +++ b/x/auth/types/credentials.go @@ -9,7 +9,7 @@ import ( "github.com/cosmos/cosmos-sdk/types/address" ) -// NewBaseAccountWithPubKey creates an account with an a pubkey. +// NewBaseAccountWithPubKey creates an account with a pubkey. func NewBaseAccountWithPubKey(pubkey cryptotypes.PubKey) (*BaseAccount, error) { if pubkey == nil { return nil, fmt.Errorf("pubkey cannot be nil") diff --git a/x/auth/types/credentials_test.go b/x/auth/types/credentials_test.go index 1e5a0ce6d1..3ddc2d579c 100644 --- a/x/auth/types/credentials_test.go +++ b/x/auth/types/credentials_test.go @@ -10,7 +10,7 @@ import ( authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" ) -func TestNewModuleCrendentials(t *testing.T) { +func TestNewModuleCredentials(t *testing.T) { // wrong derivation keys _, err := authtypes.NewModuleCredential("group", []byte{}) require.Error(t, err, "derivation keys must be non empty") diff --git a/x/auth/vesting/autocli.go b/x/auth/vesting/autocli.go index 2ff4585db1..0551c3cf7e 100644 --- a/x/auth/vesting/autocli.go +++ b/x/auth/vesting/autocli.go @@ -34,7 +34,7 @@ timestamp.`, Use: "create-permanent-locked-account [to_address] [amount]", Short: "Create a new permanently locked account funded with an allocation of tokens.", Long: `Create a new account funded with an allocation of permanently locked tokens. -These tokens may be used for staking but are non-transferable. Staking rewards will acrue as liquid and transferable tokens.`, +These tokens may be used for staking but are non-transferable. Staking rewards will accrue as liquid and transferable tokens.`, PositionalArgs: []*autocliv1.PositionalArgDescriptor{ {ProtoField: "to_address"}, {ProtoField: "amount", Varargs: true}, diff --git a/x/authz/authorization_grant_test.go b/x/authz/authorization_grant_test.go index 82a7991b5e..75534c147f 100644 --- a/x/authz/authorization_grant_test.go +++ b/x/authz/authorization_grant_test.go @@ -8,7 +8,7 @@ import ( ) // TODO: remove and use: robert/expect-error -func expecError(r *require.Assertions, expected string, received error) { +func expectError(r *require.Assertions, expected string, received error) { if expected == "" { r.NoError(received) } else { @@ -36,7 +36,7 @@ func TestNewGrant(t *testing.T) { for _, tc := range tcs { t.Run(tc.title, func(t *testing.T) { _, err := NewGrant(tc.blockTime, tc.a, tc.expire) - expecError(require.New(t), tc.err, err) + expectError(require.New(t), tc.err, err) }) } } diff --git a/x/authz/simulation/decoder.go b/x/authz/simulation/decoder.go index 22a686f1a7..4f75b30db0 100644 --- a/x/authz/simulation/decoder.go +++ b/x/authz/simulation/decoder.go @@ -10,7 +10,7 @@ import ( "github.com/cosmos/cosmos-sdk/x/authz/keeper" ) -// NewDecodeStore returns a decoder function closure that umarshals the KVPair's +// NewDecodeStore returns a decoder function closure that unmarshals the KVPair's // Value to the corresponding authz type. func NewDecodeStore(cdc codec.Codec) func(kvA, kvB kv.Pair) string { return func(kvA, kvB kv.Pair) string {