From 73d83b02cb678c51db3e282d92f32a41ebcdf1c5 Mon Sep 17 00:00:00 2001 From: mossid Date: Sun, 14 Oct 2018 02:50:32 +0900 Subject: [PATCH] typo --- x/params/doc.go | 4 ++-- x/params/keeper_test.go | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/x/params/doc.go b/x/params/doc.go index 77b05273b3..bee45e79ec 100644 --- a/x/params/doc.go +++ b/x/params/doc.go @@ -33,7 +33,7 @@ recommended to use the same name with the module's. ps params.Subspace } -Pass a params.Subspace to NewKeeper with DefaultParamSubspace (or another) +Pass a params.Subspace to NewKeeper with DefaultParamspace (or another) app.myKeeper = mymodule.NewKeeper(app.paramStore.SubStore(mymodule.DefaultParamspace)) @@ -79,7 +79,7 @@ params.Keeper itself to access all subspace(using GetSubspace) } func (k MasterKeeper) SetParam(ctx sdk.Context, space string, key string, param interface{}) { - space, ok := k.ps.GetSubspace(space) + space, ok := k.pk.GetSubspace(space) if !ok { return } diff --git a/x/params/keeper_test.go b/x/params/keeper_test.go index 30584421f5..585db3c410 100644 --- a/x/params/keeper_test.go +++ b/x/params/keeper_test.go @@ -82,7 +82,7 @@ func TestKeeper(t *testing.T) { for i, kv := range kvs { var param int64 require.NotPanics(t, func() { space.Get(ctx, []byte(kv.key), ¶m) }, "space.Get panics, tc #%d", i) - require.Equal(t, kv.param, param, "param not equal, tc #%d", i) + require.Equal(t, kv.param, param, "stored param not equal, tc #%d", i) } // Test space.GetRaw @@ -91,7 +91,7 @@ func TestKeeper(t *testing.T) { bz := space.GetRaw(ctx, []byte(kv.key)) err := cdc.UnmarshalJSON(bz, ¶m) require.Nil(t, err, "err is not nil, tc #%d", i) - require.Equal(t, kv.param, param, "param not equal, tc #%d", i) + require.Equal(t, kv.param, param, "stored param not equal, tc #%d", i) } // Test store.Get equals space.Get @@ -101,7 +101,7 @@ func TestKeeper(t *testing.T) { require.NotNil(t, bz, "KVStore.Get returns nil, tc #%d", i) err := cdc.UnmarshalJSON(bz, ¶m) require.NoError(t, err, "UnmarshalJSON returns error, tc #%d", i) - require.Equal(t, kv.param, param, "param not equal, tc #%d", i) + require.Equal(t, kv.param, param, "stored param not equal, tc #%d", i) } // Test invalid space.Get @@ -195,9 +195,9 @@ func TestSubspace(t *testing.T) { require.Equal(t, kv.zero, indirect(kv.ptr), "invalid space.Get unmarshalls when no value exists, tc #%d", i) require.NotPanics(t, func() { space.GetIfExists(ctx, []byte(kv.key), kv.ptr) }, "space.GetIfExists panics, tc #%d", i) - require.Equal(t, kv.param, indirect(kv.ptr), "spaced param not equal, tc #%d", i) + require.Equal(t, kv.param, indirect(kv.ptr), "stored param not equal, tc #%d", i) require.NotPanics(t, func() { space.Get(ctx, []byte(kv.key), kv.ptr) }, "space.Get panics, tc #%d", i) - require.Equal(t, kv.param, indirect(kv.ptr), "spaced param not equal, tc #%d", i) + require.Equal(t, kv.param, indirect(kv.ptr), "stored param not equal, tc #%d", i) require.Panics(t, func() { space.Get(ctx, []byte("invalid"), kv.ptr) }, "invalid space.Get not panics when no value exists, tc #%d", i) require.Equal(t, kv.param, indirect(kv.ptr), "invalid space.Get unmarshalls when no value existt, tc #%d", i) @@ -212,6 +212,6 @@ func TestSubspace(t *testing.T) { require.NotNil(t, bz, "store.Get() returns nil, tc #%d", i) err := cdc.UnmarshalJSON(bz, kv.ptr) require.NoError(t, err, "cdc.UnmarshalJSON() returns error, tc #%d", i) - require.Equal(t, kv.param, indirect(kv.ptr), "param not equal, tc #%d", i) + require.Equal(t, kv.param, indirect(kv.ptr), "stored param not equal, tc #%d", i) } }