Merge PR #1119: Unbonding, Redelegation

* stake/fees spec updates
* staking overview.md revisions, moving files
* docs reorganization
* staking spec state revisions
* transaction stake updates
* complete staking spec update
* WIP adding unbonding/redelegation commands
* added msg types for unbonding, redelegation
* stake sub-package reorg
* working stake reorg
* modify lcd tests to not use hardcoded json strings
* add description update
* index keys
* key managment for unbonding redelegation complete
* update stake errors
* completed handleMsgCompleteUnbonding fn
* updated to use begin/complete unbonding/redelegation
* fix token shares bug
* develop docs into unbonding
* got non-tests compiling after merge develop
* working fixing tests
* PrivlegedKeeper -> PrivilegedKeeper
* tests compile
* fix some tests
* fixing tests
* remove PrivilegedKeeper
* get unbonding bug
* only rpc sig verification failed tests now
* move percent unbonding/redelegation to the CLI and out of handler logic
* remove min unbonding height
* add lcd txs
* add pool sanity checks, fix a buncha tests
* fix ante. set lcd log to debug (#1322)
* redelegation tests, adding query functionality for bonds
* add self-delegations at genesis ref #1165
* PR comments (mostly) addressed
* cleanup, added Query LCD functionality
* test cleanup/fixes
* fix governance test
* SlashValidatorSet -> ValidatorSet
* changelog
* stake lcd fix
* x/auth: fix chainID in ante
* fix lcd test
* fix lint, update lint make command for spelling
* lowercase error string
* don't expose coinkeeper in staking
* remove a few duplicate lines in changelog
* chain_id in stake lcd tests
* added transient redelegation
* 'transient' => 'transitive'
* Re-add nolint instruction
* Fix tiny linter error

types/rational.go

@@ -110,7 +110,9 @@ func (r Rat) Denom() int64        { return r.Rat.Denom().Int64() } // Denom  - r
 func (r Rat) IsZero() bool        { return r.Num() == 0 }          // IsZero - Is the Rat equal to zero
 func (r Rat) Equal(r2 Rat) bool   { return (r.Rat).Cmp(r2.Rat) == 0 }
 func (r Rat) GT(r2 Rat) bool      { return (r.Rat).Cmp(r2.Rat) == 1 }             // greater than
+func (r Rat) GTE(r2 Rat) bool     { return !r.LT(r2) }                            // greater than or equal
 func (r Rat) LT(r2 Rat) bool      { return (r.Rat).Cmp(r2.Rat) == -1 }            // less than
+func (r Rat) LTE(r2 Rat) bool     { return !r.GT(r2) }                            // less than or equal
 func (r Rat) Mul(r2 Rat) Rat      { return Rat{new(big.Rat).Mul(r.Rat, r2.Rat)} } // Mul - multiplication
 func (r Rat) Quo(r2 Rat) Rat      { return Rat{new(big.Rat).Quo(r.Rat, r2.Rat)} } // Quo - quotient
 func (r Rat) Add(r2 Rat) Rat      { return Rat{new(big.Rat).Add(r.Rat, r2.Rat)} } // Add - addition

types/rational_test.go

@@ -229,7 +229,7 @@ func TestSerializationText(t *testing.T) {
 	bz, err := r.MarshalText()
 	require.NoError(t, err)
 
-	var r2 Rat = Rat{new(big.Rat)}
+	var r2 = Rat{new(big.Rat)}
 	err = r2.UnmarshalText(bz)
 	require.NoError(t, err)
 	assert.True(t, r.Equal(r2), "original: %v, unmarshalled: %v", r, r2)

types/stake.go

@@ -59,8 +59,9 @@ type ValidatorSet interface {
 	IterateValidatorsBonded(Context,
 		func(index int64, validator Validator) (stop bool))
 
-	Validator(Context, Address) Validator     // get a particular validator by owner address
-	TotalPower(Context) Rat                   // total power of the validator set
+	Validator(Context, Address) Validator // get a particular validator by owner address
+	TotalPower(Context) Rat               // total power of the validator set
+
 	Slash(Context, crypto.PubKey, int64, Rat) // slash the validator and delegators of the validator, specifying offence height & slash fraction
 	Revoke(Context, crypto.PubKey)            // revoke a validator
 	Unrevoke(Context, crypto.PubKey)          // unrevoke a validator

types/tags.go

@@ -21,8 +21,8 @@ func (t Tags) AppendTag(k string, v []byte) Tags {
 }
 
 // Append two lists of tags
-func (t Tags) AppendTags(a Tags) Tags {
-	return append(t, a...)
+func (t Tags) AppendTags(tags Tags) Tags {
+	return append(t, tags...)
 }
 
 // Turn tags into KVPair list
@@ -51,3 +51,13 @@ func NewTags(tags ...interface{}) Tags {
 func MakeTag(k string, v []byte) Tag {
 	return Tag{Key: []byte(k), Value: v}
 }
+
+//__________________________________________________
+
+// common tags
+var (
+	TagAction       = "action"
+	TagSrcValidator = "source-validator"
+	TagDstValidator = "destination-validator"
+	TagDelegator    = "delegator"
+)