From 6e7e624b275cec3dfefc96b6c0e701c284fbd7a9 Mon Sep 17 00:00:00 2001 From: Robert Zaremba Date: Wed, 1 Sep 2021 15:55:16 +0200 Subject: [PATCH] test: bring back Marshalling/unmarshalling of a wrapped tx test (#10044) ## Description We still use wrapped transactions so we should test marshaling. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) --- codec/amino_codec_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/codec/amino_codec_test.go b/codec/amino_codec_test.go index 56daf97fb5..c2f09710ae 100644 --- a/codec/amino_codec_test.go +++ b/codec/amino_codec_test.go @@ -11,6 +11,7 @@ import ( "github.com/cosmos/cosmos-sdk/codec/types" "github.com/cosmos/cosmos-sdk/simapp" "github.com/cosmos/cosmos-sdk/testutil/testdata" + "github.com/cosmos/cosmos-sdk/x/auth/client/cli" "github.com/cosmos/cosmos-sdk/x/auth/migrations/legacytx" ) @@ -129,4 +130,12 @@ func TestAminoCodecFullDecodeAndEncode(t *testing.T) { marshaledTx, err := legacyCdc.MarshalJSON(tx) require.NoError(t, err) require.Equal(t, string(marshaledTx), txSigned) + + // Marshalling/unmarshalling the tx wrapped in a struct should work. + txRequest := &cli.BroadcastReq{ + Mode: "block", + Tx: tx, + } + _, err = legacyCdc.MarshalJSON(txRequest) + require.NoError(t, err) }