From 6bda2aa061b039c96fbd8da00756ef6e33eebbbd Mon Sep 17 00:00:00 2001
From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com>
Date: Fri, 20 Sep 2024 00:38:13 +0200
Subject: [PATCH] fix(staking): avoid the double iterator close in staking
 (backport #21823) (#21824)

Co-authored-by: cool-developer <51834436+cool-develope@users.noreply.github.com>
---
 x/staking/keeper/cons_pubkey.go | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/x/staking/keeper/cons_pubkey.go b/x/staking/keeper/cons_pubkey.go
index e1938597fa..d60d4628b9 100644
--- a/x/staking/keeper/cons_pubkey.go
+++ b/x/staking/keeper/cons_pubkey.go
@@ -258,8 +258,7 @@ func (k Keeper) GetBlockConsPubKeyRotationHistory(ctx context.Context) ([]types.
 	if err != nil {
 		return nil, err
 	}
-	defer iterator.Close()
-
+	// iterator would be closed in the CollectValues
 	return indexes.CollectValues(ctx, k.RotationHistory, iterator)
 }