LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

fix(tests): resolve timer resource leaks causing "too many concurrent timer firings" panic (#25102)

Browse Source 
Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Co-authored-by: Alex | Interchain Labs <alex@interchainlabs.io>
This commit is contained in:
Hwangjae Lee 2025-08-07 00:43:59 +09:00 committed by GitHub
parent 41ba54bede
commit 56775c81d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 38 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/conv/string_test.go
View File

@ -25,7 +25,9 @@ func (s *StringSuite) TestUnsafeStrToBytes() {
for range 5 {
b := unsafeConvertStr()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
b2 := append(b, 'd')
s.Equal("abc", string(b))
s.Equal("abcd", string(b2))
@ -42,7 +44,9 @@ func (s *StringSuite) TestUnsafeBytesToStr() {
for range 5 {
str := unsafeConvertBytes()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
s.Equal("abc", str)
}
}

8
store/internal/conv/string_test.go
View File

@ -25,7 +25,9 @@ func (s *StringSuite) TestUnsafeStrToBytes() {
for i := 0; i < 5; i++ {
b := unsafeConvertStr()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
b2 := append(b, 'd')
s.Equal("abc", string(b))
s.Equal("abcd", string(b2))
@ -42,7 +44,9 @@ func (s *StringSuite) TestUnsafeBytesToStr() {
for i := 0; i < 5; i++ {
str := unsafeConvertBytes()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
s.Equal("abc", str)
}
}

20
systemtests/system.go
View File

@ -314,11 +314,13 @@ func (s *SystemUnderTest) AwaitNodeUp(t *testing.T, rpcAddr string) {
started <- struct{}{}
}
}()
timer := time.NewTimer(timeout)
defer timer.Stop()
select {
case <-started:
case <-ctx.Done():
require.NoError(t, ctx.Err())
case <-time.NewTimer(timeout).C:
case <-timer.C:
t.Fatalf("timeout waiting for node start: %s", timeout)
}
}
@ -403,7 +405,9 @@ func (s *SystemUnderTest) AwaitBlockHeight(t *testing.T, targetHeight int64, tim
} else {
maxWaitTime = time.Duration(targetHeight-s.currentHeight.Load()+4) * s.blockTime
}
abort := time.NewTimer(maxWaitTime).C
timer := time.NewTimer(maxWaitTime)
defer timer.Stop()
abort := timer.C
for {
select {
case <-abort:
@ -433,10 +437,12 @@ func (s *SystemUnderTest) AwaitNextBlock(t *testing.T, timeout ...time.Duration)
done <- s.currentHeight.Load()
close(done)
}()
timer := time.NewTimer(maxWaitTime)
defer timer.Stop()
select {
case v := <-done:
return v
case <-time.NewTimer(maxWaitTime).C:
case <-timer.C:
t.Fatalf("Timeout - no block within %s", maxWaitTime)
return -1
}
@ -907,6 +913,7 @@ func TimeoutConsumer(t *testing.T, maxWaitTime time.Duration, next EventConsumer
ctx, done := context.WithCancel(context.Background())
t.Cleanup(done)
timeout := time.NewTimer(maxWaitTime)
t.Cleanup(func() { timeout.Stop() })
timedOut := make(chan struct{}, 1)
go func() {
select {
@ -922,6 +929,13 @@ func TimeoutConsumer(t *testing.T, maxWaitTime time.Duration, next EventConsumer
t.Fatalf("Timeout waiting for new events %s", maxWaitTime)
return false
default:
if !timeout.Stop() {
// Drain the channel if the timer already fired
select {
case <-timeout.C:
default:
}
}
timeout.Reset(maxWaitTime)
result := next(e)
if !result {

8
x/nft/internal/conv/string_test.go
View File

@ -25,7 +25,9 @@ func (s *StringSuite) TestUnsafeStrToBytes() {
for i := 0; i < 5; i++ {
b := unsafeConvertStr()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
b2 := append(b, 'd')
s.Equal("abc", string(b))
s.Equal("abcd", string(b2))
@ -42,7 +44,9 @@ func (s *StringSuite) TestUnsafeBytesToStr() {
for i := 0; i < 5; i++ {
str := unsafeConvertBytes()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
s.Equal("abc", str)
}
}

4
x/upgrade/internal/conv/string_test.go
View File

@ -25,7 +25,9 @@ func (s *StringSuite) TestUnsafeStrToBytes() {
for i := 0; i < 5; i++ {
b := unsafeConvertStr()
runtime.GC()
<-time.NewTimer(2 * time.Millisecond).C
timer := time.NewTimer(2 * time.Millisecond)
<-timer.C
timer.Stop()
b2 := append(b, 'd')
s.Equal("abc", string(b))
s.Equal("abcd", string(b2))