From 5013933e6f960274804d7c71492f4b7da04a25d9 Mon Sep 17 00:00:00 2001 From: Marko Date: Mon, 12 Sep 2022 08:55:32 +0200 Subject: [PATCH] chore: pin version of golangci-lint (#13238) * pin point version fo golangci-lint * remove dep * version variable --- .github/workflows/lint.yml | 2 +- Makefile | 13 ++++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 9da290f170..a100013b2b 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -24,4 +24,4 @@ jobs: uses: golangci/golangci-lint-action@v3 with: # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version - version: latest + version: v1.49.0 diff --git a/Makefile b/Makefile index 1a302c3c1f..75810961a4 100644 --- a/Makefile +++ b/Makefile @@ -342,23 +342,26 @@ benchmark: ### Linting ### ############################################################################### -golangci_lint_cmd=github.com/golangci/golangci-lint/cmd/golangci-lint +golangci_lint_cmd=golangci-lint +golangci_version=v1.49.0 lint: @echo "--> Running linter" - @go run $(golangci_lint_cmd) run --timeout=10m + @go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version) + @$(golangci_lint_cmd) run --timeout=10m lint-fix: @echo "--> Running linter" - @go run $(golangci_lint_cmd) run --fix --out-format=tab --issues-exit-code=0 + @go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version) + @$(golangci_lint_cmd) run --fix --out-format=tab --issues-exit-code=0 .PHONY: lint lint-fix format: @go install mvdan.cc/gofumpt@latest - @go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest + @go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version) find . -name '*.go' -type f -not -path "./vendor*" -not -path "*.git*" -not -path "./client/docs/statik/statik.go" -not -path "./tests/mocks/*" -not -name "*.pb.go" -not -name "*.pb.gw.go" -not -name "*.pulsar.go" -not -path "./crypto/keys/secp256k1/*" | xargs gofumpt -w -l - golangci-lint run --fix + $(golangci_lint_cmd) run --fix .PHONY: format ###############################################################################