LaconicNetwork/cosmos-sdk
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

test: migrate e2e/group to system tests (backport #22278) (#22286)

Browse Source 
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
This commit is contained in:
mergify[bot] 2024-10-17 10:20:25 +02:00 committed by GitHub
parent 1cd7babcf2
commit 40f7878ca0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 131 additions and 310 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/e2e/group/cli_test.go
View File

@ -1,20 +0,0 @@
//go:build e2e
// +build e2e
package group
import (
"testing"
"github.com/stretchr/testify/suite"
"cosmossdk.io/simapp"
"github.com/cosmos/cosmos-sdk/testutil/network"
)
func TestE2ETestSuite(t *testing.T) {
cfg := network.DefaultConfig(simapp.NewTestNetworkFixture)
cfg.NumValidators = 1
suite.Run(t, NewE2ETestSuite(cfg))
}

290
tests/e2e/group/suite.go
View File

@ -1,290 +0,0 @@
package group
import (
"encoding/base64"
"encoding/json"
"fmt"
"github.com/stretchr/testify/suite"
// without this import amino json encoding will fail when resolving any types
_ "cosmossdk.io/api/cosmos/group/v1"
"cosmossdk.io/math"
banktypes "cosmossdk.io/x/bank/types"
"cosmossdk.io/x/group"
client "cosmossdk.io/x/group/client/cli"
"github.com/cosmos/cosmos-sdk/client/flags"
"github.com/cosmos/cosmos-sdk/crypto/hd"
"github.com/cosmos/cosmos-sdk/crypto/keyring"
"github.com/cosmos/cosmos-sdk/testutil"
clitestutil "github.com/cosmos/cosmos-sdk/testutil/cli"
"github.com/cosmos/cosmos-sdk/testutil/network"
sdk "github.com/cosmos/cosmos-sdk/types"
)
type E2ETestSuite struct {
suite.Suite
cfg network.Config
network network.NetworkI
group *group.GroupInfo
groupPolicies []*group.GroupPolicyInfo
proposal *group.Proposal
vote *group.Vote
voter *group.Member
commonFlags []string
}
const validMetadata = "metadata"
func NewE2ETestSuite(cfg network.Config) *E2ETestSuite {
return &E2ETestSuite{cfg: cfg}
}
func (s *E2ETestSuite) SetupSuite() {
s.T().Log("setting up e2e test suite")
s.commonFlags = []string{
fmt.Sprintf("--%s=true", flags.FlagSkipConfirmation),
fmt.Sprintf("--%s=%s", flags.FlagBroadcastMode, flags.BroadcastSync),
fmt.Sprintf("--%s=%s", flags.FlagFees, sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, math.NewInt(10))).String()),
}
var err error
s.network, err = network.New(s.T(), s.T().TempDir(), s.cfg)
s.Require().NoError(err)
s.Require().NoError(s.network.WaitForNextBlock())
val := s.network.GetValidators()[0]
// create a new account
info, _, err := val.GetClientCtx().Keyring.NewMnemonic("NewValidator", keyring.English, sdk.FullFundraiserPath, keyring.DefaultBIP39Passphrase, hd.Secp256k1)
s.Require().NoError(err)
pk, err := info.GetPubKey()
s.Require().NoError(err)
account := sdk.AccAddress(pk.Address())
msgSend := &banktypes.MsgSend{
FromAddress: val.GetAddress().String(),
ToAddress: account.String(),
Amount: sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, math.NewInt(2000))),
}
_, err = clitestutil.SubmitTestTx(
val.GetClientCtx(),
msgSend,
val.GetAddress(),
clitestutil.TestTxConfig{
GenOnly: true,
},
)
s.Require().NoError(err)
s.Require().NoError(s.network.WaitForNextBlock())
memberWeight := "3"
// create a group
validMembers := fmt.Sprintf(`
{
"members": [
{
"address": "%s",
"weight": "%s",
"metadata": "%s"
}
]
}`, val.GetAddress().String(), memberWeight, validMetadata)
validMembersFile := testutil.WriteToNewTempFile(s.T(), validMembers)
out, err := clitestutil.ExecTestCLICmd(val.GetClientCtx(), client.MsgCreateGroupCmd(),
append(
[]string{
val.GetAddress().String(),
validMetadata,
validMembersFile.Name(),
},
s.commonFlags...,
),
)
s.Require().NoError(err, out.String())
txResp := sdk.TxResponse{}
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
s.Require().NoError(clitestutil.CheckTxCode(s.network, val.GetClientCtx(), txResp.TxHash, 0))
s.group = &group.GroupInfo{Id: 1, Admin: val.GetAddress().String(), Metadata: validMetadata, TotalWeight: "3", Version: 1}
// create 5 group policies
for i := 0; i < 5; i++ {
threshold := i + 1
if threshold > 3 {
threshold = 3
}
s.createGroupThresholdPolicyWithBalance(val.GetAddress().String(), "1", threshold, 1000)
s.Require().NoError(s.network.WaitForNextBlock())
resp, err := testutil.GetRequest(fmt.Sprintf("%s/cosmos/group/v1/group_policies_by_group/1", val.GetAPIAddress()))
s.Require().NoError(err)
var groupPoliciesResp group.QueryGroupPoliciesByGroupResponse
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(resp, &groupPoliciesResp))
s.Require().Len(groupPoliciesResp.GroupPolicies, i+1)
}
// create group policy with percentage decision policy
out, err = clitestutil.ExecTestCLICmd(val.GetClientCtx(), client.MsgCreateGroupPolicyCmd(),
append(
[]string{
val.GetAddress().String(),
"1",
validMetadata,
testutil.WriteToNewTempFile(s.T(), fmt.Sprintf(`{"@type":"/cosmos.group.v1.PercentageDecisionPolicy", "percentage":"%f", "windows":{"voting_period":"30000s"}}`, 0.5)).Name(),
},
s.commonFlags...,
),
)
s.Require().NoError(err, out.String())
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
s.Require().NoError(clitestutil.CheckTxCode(s.network, val.GetClientCtx(), txResp.TxHash, 0))
resp, err := testutil.GetRequest(fmt.Sprintf("%s/cosmos/group/v1/group_policies_by_group/1", val.GetAPIAddress()))
s.Require().NoError(err)
var groupPoliciesResp group.QueryGroupPoliciesByGroupResponse
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(resp, &groupPoliciesResp))
s.Require().Equal(len(groupPoliciesResp.GroupPolicies), 6)
s.groupPolicies = groupPoliciesResp.GroupPolicies
// create a proposal
out, err = clitestutil.ExecTestCLICmd(val.GetClientCtx(), client.MsgSubmitProposalCmd(),
append(
[]string{
s.createCLIProposal(
s.groupPolicies[0].Address, val.GetAddress().String(),
s.groupPolicies[0].Address, val.GetAddress().String(),
"", "title", "summary"),
},
s.commonFlags...,
),
)
s.Require().NoError(err, out.String())
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
s.Require().NoError(clitestutil.CheckTxCode(s.network, val.GetClientCtx(), txResp.TxHash, 0))
msg := &group.MsgVote{
ProposalId: uint64(1),
Voter: val.GetAddress().String(),
Option: group.VOTE_OPTION_YES,
}
// vote
out, err = clitestutil.SubmitTestTx(val.GetClientCtx(), msg, val.GetAddress(), clitestutil.TestTxConfig{})
s.Require().NoError(err, out.String())
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
s.Require().NoError(clitestutil.CheckTxCode(s.network, val.GetClientCtx(), txResp.TxHash, 0))
resp, err = testutil.GetRequest(fmt.Sprintf("%s/cosmos/group/v1/proposal/1", val.GetAPIAddress()))
s.Require().NoError(err)
var proposalRes group.QueryProposalResponse
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(resp, &proposalRes))
s.proposal = proposalRes.Proposal
resp, err = testutil.GetRequest(fmt.Sprintf("%s/cosmos/group/v1/vote_by_proposal_voter/1/%s", val.GetAPIAddress(), val.GetAddress().String()))
s.Require().NoError(err)
var voteRes group.QueryVoteByProposalVoterResponse
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(resp, &voteRes))
s.vote = voteRes.Vote
s.voter = &group.Member{
Address: val.GetAddress().String(),
Weight: memberWeight,
Metadata: validMetadata,
}
}
func (s *E2ETestSuite) TearDownSuite() {
s.T().Log("tearing down e2e test suite")
s.network.Cleanup()
}
// createCLIProposal writes a CLI proposal with a MsgSend to a file. Returns
// the path to the JSON file.
func (s *E2ETestSuite) createCLIProposal(groupPolicyAddress, proposer, sendFrom, sendTo, metadata, title, summary string) string {
_, err := base64.StdEncoding.DecodeString(metadata)
s.Require().NoError(err)
msg := banktypes.MsgSend{
FromAddress: sendFrom,
ToAddress: sendTo,
Amount: sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, math.NewInt(20))),
}
msgJSON, err := s.cfg.Codec.MarshalInterfaceJSON(&msg)
s.Require().NoError(err)
p := client.Proposal{
GroupPolicyAddress: groupPolicyAddress,
Messages: []json.RawMessage{msgJSON},
Metadata: metadata,
Proposers: []string{proposer},
Title: title,
Summary: summary,
}
bz, err := json.Marshal(&p)
s.Require().NoError(err)
return testutil.WriteToNewTempFile(s.T(), string(bz)).Name()
}
func (s *E2ETestSuite) createGroupThresholdPolicyWithBalance(adminAddress, groupID string, threshold int, tokens int64) string {
s.Require().NoError(s.network.WaitForNextBlock())
val := s.network.GetValidators()[0]
clientCtx := val.GetClientCtx()
out, err := clitestutil.ExecTestCLICmd(clientCtx, client.MsgCreateGroupPolicyCmd(),
append(
[]string{
adminAddress,
groupID,
validMetadata,
testutil.WriteToNewTempFile(s.T(), fmt.Sprintf(`{"@type":"/cosmos.group.v1.ThresholdDecisionPolicy", "threshold":"%d", "windows":{"voting_period":"30000s"}}`, threshold)).Name(),
},
s.commonFlags...,
),
)
txResp := sdk.TxResponse{}
s.Require().NoError(err, out.String())
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(out.Bytes(), &txResp), out.String())
s.Require().NoError(clitestutil.CheckTxCode(s.network, val.GetClientCtx(), txResp.TxHash, 0))
resp, err := testutil.GetRequest(fmt.Sprintf("%s/cosmos/group/v1/group_policies_by_group/%s", val.GetAPIAddress(), groupID))
s.Require().NoError(err)
var res group.QueryGroupPoliciesByGroupResponse
s.Require().NoError(val.GetClientCtx().Codec.UnmarshalJSON(resp, &res))
groupPolicyAddress := res.GroupPolicies[0].Address
addr, err := sdk.AccAddressFromBech32(groupPolicyAddress)
s.Require().NoError(err)
msgSend := &banktypes.MsgSend{
FromAddress: val.GetAddress().String(),
ToAddress: addr.String(),
Amount: sdk.NewCoins(sdk.NewCoin(s.cfg.BondDenom, math.NewInt(tokens))),
}
_, err = clitestutil.SubmitTestTx(
val.GetClientCtx(),
msgSend,
val.GetAddress(),
clitestutil.TestTxConfig{
GenOnly: true,
},
)
s.Require().NoError(err)
return groupPolicyAddress
}

131
tests/systemtests/group_test.go Normal file
View File

@ -0,0 +1,131 @@
//go:build system_test
package systemtests
import (
"fmt"
"testing"
"github.com/stretchr/testify/require"
"github.com/tidwall/gjson"
)
const (
validMetadata = "metadata"
)
func TestGroupCommands(t *testing.T) {
// scenario: test group commands
// given a running chain
sut.ResetChain(t)
require.GreaterOrEqual(t, sut.NodesCount(), 2)
cli := NewCLIWrapper(t, sut, verbose)
// get validator address
valAddr := cli.GetKeyAddr("node0")
require.NotEmpty(t, valAddr)
sut.StartChain(t)
baseurl := sut.APIAddress()
// test create group
memberWeight := "5"
validMembers := fmt.Sprintf(`
{
"members": [
{
"address": "%s",
"weight": "%s",
"metadata": "%s"
}
]
}`, valAddr, memberWeight, validMetadata)
validMembersFile := StoreTempFile(t, []byte(validMembers))
createGroupCmd := []string{"tx", "group", "create-group", valAddr, validMetadata, validMembersFile.Name(), "--from=" + valAddr}
rsp := cli.RunAndWait(createGroupCmd...)
RequireTxSuccess(t, rsp)
// query groups by admin to confirm group creation
rsp = cli.CustomQuery("q", "group", "groups-by-admin", valAddr)
require.Len(t, gjson.Get(rsp, "groups").Array(), 1)
groupId := gjson.Get(rsp, "groups.0.id").String()
// test create group policies
for i := 0; i < 5; i++ {
threshold := i + 1
policyFile := StoreTempFile(t, []byte(fmt.Sprintf(`{"@type":"/cosmos.group.v1.ThresholdDecisionPolicy", "threshold":"%d", "windows":{"voting_period":"30000s"}}`, threshold)))
policyCmd := []string{"tx", "group", "create-group-policy", valAddr, groupId, validMetadata, policyFile.Name(), "--from=" + valAddr}
rsp = cli.RunAndWait(policyCmd...)
RequireTxSuccess(t, rsp)
// TODO: remove isV2() check once v2 is integrated with grpc gateway
var groupPoliciesResp, policyAddrQuery string
if isV2() {
groupPoliciesResp = cli.CustomQuery("q", "group", "group-policies-by-group", groupId)
policyAddrQuery = fmt.Sprintf("group_policies.#(decision_policy.value.threshold==%d).address", threshold)
} else {
groupPoliciesResp = string(GetRequest(t, fmt.Sprintf("%s/cosmos/group/v1/group_policies_by_group/%s", baseurl, groupId)))
policyAddrQuery = fmt.Sprintf("group_policies.#(decision_policy.threshold==%d).address", threshold)
}
require.Equal(t, gjson.Get(groupPoliciesResp, "pagination.total").Int(), int64(threshold))
policyAddr := gjson.Get(groupPoliciesResp, policyAddrQuery).String()
require.NotEmpty(t, policyAddr)
rsp = cli.RunCommandWithArgs(cli.withTXFlags("tx", "bank", "send", valAddr, policyAddr, "1000stake", "--generate-only")...)
require.Equal(t, policyAddr, gjson.Get(rsp, "body.messages.0.to_address").String())
}
// test create group policy with percentage decision policy
percentagePolicyType := "/cosmos.group.v1.PercentageDecisionPolicy"
policyFile := StoreTempFile(t, []byte(fmt.Sprintf(`{"@type":"%s", "percentage":"%f", "windows":{"voting_period":"30000s"}}`, percentagePolicyType, 0.5)))
policyCmd := []string{"tx", "group", "create-group-policy", valAddr, groupId, validMetadata, policyFile.Name(), "--from=" + valAddr}
rsp = cli.RunAndWait(policyCmd...)
RequireTxSuccess(t, rsp)
groupPoliciesResp := cli.CustomQuery("q", "group", "group-policies-by-admin", valAddr)
require.Equal(t, gjson.Get(groupPoliciesResp, "pagination.total").Int(), int64(6))
policyAddr := gjson.Get(groupPoliciesResp, fmt.Sprintf("group_policies.#(decision_policy.type==%s).address", percentagePolicyType)).String()
require.NotEmpty(t, policyAddr)
// test create proposal
proposalJSON := fmt.Sprintf(`{
"group_policy_address": "%s",
"messages":[
{
"@type": "/cosmos.bank.v1beta1.MsgSend",
"from_address": "%s",
"to_address": "%s",
"amount": [{"denom": "stake","amount": "100"}]
}
],
"metadata": "%s",
"title": "My Proposal",
"summary": "Summary",
"proposers": ["%s"]
}`, policyAddr, policyAddr, valAddr, validMetadata, valAddr)
proposalFile := StoreTempFile(t, []byte(proposalJSON))
rsp = cli.RunAndWait("tx", "group", "submit-proposal", proposalFile.Name())
RequireTxSuccess(t, rsp)
// query proposals
rsp = cli.CustomQuery("q", "group", "proposals-by-group-policy", policyAddr)
require.Len(t, gjson.Get(rsp, "proposals").Array(), 1)
proposalId := gjson.Get(rsp, "proposals.0.id").String()
// test vote proposal
rsp = cli.RunAndWait("tx", "group", "vote", proposalId, valAddr, "yes", validMetadata)
RequireTxSuccess(t, rsp)
// query votes
// TODO: remove isV2() check once v2 is integrated with grpc gateway
var voteResp string
if isV2() {
voteResp = cli.CustomQuery("q", "group", "vote", proposalId, valAddr)
} else {
voteResp = string(GetRequest(t, fmt.Sprintf("%s/cosmos/group/v1/vote_by_proposal_voter/%s/%s", baseurl, proposalId, valAddr)))
}
require.Equal(t, "VOTE_OPTION_YES", gjson.Get(voteResp, "vote.option").String())
}