Co-authored-by: Ocenka <testoviydiman1@gmail.com> Co-authored-by: Julien Robert <julien@rbrt.fr>
This commit is contained in:
parent
4b225cacb8
commit
39dfcb5d8e
@ -18,7 +18,7 @@ This ADR replaces the current BaseApp `runTx` and antehandlers design with a mid
|
||||
|
||||
BaseApp's implementation of ABCI `{Check,Deliver}Tx()` and its own `Simulate()` method call the `runTx` method under the hood, which first runs antehandlers, then executes `Msg`s. However, the [transaction Tips](https://github.com/cosmos/cosmos-sdk/issues/9406) and [refunding unused gas](https://github.com/cosmos/cosmos-sdk/issues/2150) use cases require custom logic to be run after the `Msg`s execution. There is currently no way to achieve this.
|
||||
|
||||
An naive solution would be to add post-`Msg` hooks to BaseApp. However, the Cosmos SDK team thinks in parallel about the bigger picture of making app wiring simpler ([#9181](https://github.com/cosmos/cosmos-sdk/discussions/9182)), which includes making BaseApp more lightweight and modular.
|
||||
A naive solution would be to add post-`Msg` hooks to BaseApp. However, the Cosmos SDK team thinks in parallel about the bigger picture of making app wiring simpler ([#9181](https://github.com/cosmos/cosmos-sdk/discussions/9182)), which includes making BaseApp more lightweight and modular.
|
||||
|
||||
## Decision
|
||||
|
||||
|
||||
@ -10,7 +10,7 @@ The Cosmos SDK has a very powerful and flexible module system that has been test
|
||||
and proven to be very good in production. The design of how messages are handled
|
||||
is built around Protobuf services and gRPC. This design was proposed and implemented
|
||||
during a time when we migrated from Amino to Protocol Buffers. This design has
|
||||
fulfilled the needs of users today. While this design is useful it has caused a
|
||||
fulfilled the needs of users today. While this design is useful it has caused an
|
||||
elevated learning curve to be adopted by users. Today, these services are the
|
||||
only way to write a module. This RFC proposes a new design that simplifies the
|
||||
design and enables new use cases we are seeing today.
|
||||
|
||||
@ -103,7 +103,7 @@ responsibility of the caller to ensure that concurrent access to the store is
|
||||
not performed.
|
||||
|
||||
The main issue with concurrent use is when data is written at the same time as
|
||||
it's being iterated over. Doing so will cause a irrecoverable fatal error because
|
||||
it's being iterated over. Doing so will cause an irrecoverable fatal error because
|
||||
of concurrent reads and writes to an internal map.
|
||||
|
||||
Although it's not recommended, you can iterate through values while writing to
|
||||
|
||||
@ -132,7 +132,7 @@ When running a node (not a validator!) and not wanting to run the application me
|
||||
|
||||
```toml
|
||||
[mempool]
|
||||
# Setting max-txs to 0 will allow for a unbounded amount of transactions in the mempool.
|
||||
# Setting max-txs to 0 will allow for an unbounded amount of transactions in the mempool.
|
||||
# Setting max_txs to negative 1 (-1) will disable transactions from being inserted into the mempool.
|
||||
# Setting max_txs to a positive number (> 0) will limit the number of transactions in the mempool, by the specified amount.
|
||||
#
|
||||
|
||||
@ -103,7 +103,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
|
||||
|
||||
### State Breaking changes
|
||||
|
||||
* [#18841](https://github.com/cosmos/cosmos-sdk/pull/18841) In a undelegation or redelegation if the shares being left delegated correspond to less than 1 token (in base denom) the entire delegation gets removed.
|
||||
* [#18841](https://github.com/cosmos/cosmos-sdk/pull/18841) In an undelegation or redelegation if the shares being left delegated correspond to less than 1 token (in base denom) the entire delegation gets removed.
|
||||
* [#18142](https://github.com/cosmos/cosmos-sdk/pull/18142) Introduce `key_rotation_fee` param to calculate fees while rotating the keys
|
||||
* [#19740](https://github.com/cosmos/cosmos-sdk/pull/19740) `InitGenesis` and `ExportGenesis` module code and keeper code do not panic but return errors.
|
||||
* [#20845](https://github.com/cosmoc/cosmos-sdk/pull/20845) Remove HistoricalInfo from the staking modules storage
|
||||
|
||||
Loading…
Reference in New Issue
Block a user