LaconicNetwork/cosmos-sdk
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 2 Wiki Activity

test(client/v2): Fix TestMsg flakiness (#19753)

Browse Source
This commit is contained in:
Likhita Polavarapu 2024-03-14 16:06:53 +05:30 committed by GitHub
parent 3ce9224f00
commit 36981e640f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 33 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
client/v2/autocli/msg_test.go
View File

@ -1,8 +1,12 @@
package autocli
import (
"bytes"
"context"
"encoding/json"
"fmt"
"os"
"path/filepath"
"testing"
"github.com/spf13/cobra"
@ -53,7 +57,7 @@ func TestMsg(t *testing.T) {
"--output", "json",
)
assert.NilError(t, err)
golden.Assert(t, out.String(), "msg-output.golden")
assertNormalizedJSONEqual(t, out.Bytes(), goldenLoad(t, "msg-output.golden"))
out, err = runCmd(fixture, buildCustomModuleMsgCommand(&autocliv1.ServiceCommandDescriptor{
Service: bankv1beta1.Msg_ServiceDesc.ServiceName,
@ -74,7 +78,7 @@ func TestMsg(t *testing.T) {
"--output", "json",
)
assert.NilError(t, err)
golden.Assert(t, out.String(), "msg-output.golden")
assertNormalizedJSONEqual(t, out.Bytes(), goldenLoad(t, "msg-output.golden"))
out, err = runCmd(fixture, buildCustomModuleMsgCommand(&autocliv1.ServiceCommandDescriptor{
Service: bankv1beta1.Msg_ServiceDesc.ServiceName,
@ -97,7 +101,33 @@ func TestMsg(t *testing.T) {
"--output", "json",
)
assert.NilError(t, err)
golden.Assert(t, out.String(), "msg-output.golden")
assertNormalizedJSONEqual(t, out.Bytes(), goldenLoad(t, "msg-output.golden"))
}
func goldenLoad(t *testing.T, filename string) []byte {
t.Helper()
content, err := os.ReadFile(filepath.Join("testdata", filename))
assert.NilError(t, err)
return content
}
func assertNormalizedJSONEqual(t *testing.T, expected, actual []byte) {
t.Helper()
normalizedExpected, err := normalizeJSON(expected)
assert.NilError(t, err)
normalizedActual, err := normalizeJSON(actual)
assert.NilError(t, err)
assert.Equal(t, string(normalizedExpected), string(normalizedActual))
}
// normalizeJSON normalizes the JSON content by removing unnecessary white spaces and newlines.
func normalizeJSON(content []byte) ([]byte, error) {
var buf bytes.Buffer
err := json.Compact(&buf, content)
if err != nil {
return nil, err
}
return buf.Bytes(), nil
}
func TestMsgOptionsError(t *testing.T) {