chore: bump golangci-lint and fix all linting issues (backport #21761) (#21779)

Co-authored-by: Julien Robert <julien@rbrt.fr>

x/genutil/client/cli/gentx_test.go

@@ -109,7 +109,6 @@ func (s *CLITestSuite) TestGenTxCmd() {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 
 		dir := s.T().TempDir()
 		genTxFile := filepath.Join(dir, "myTx")

x/genutil/client/cli/migrate_test.go

@@ -50,7 +50,6 @@ func TestMigrateGenesis(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			genesisFile := testutil.WriteToNewTempFile(t, tc.genesis)
 			jsonOutput, err := clitestutil.ExecTestCLICmd(

x/genutil/client/cli/validate_genesis_test.go

@@ -85,8 +85,6 @@ func TestValidateGenesis(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			genesisFile := testutil.WriteToNewTempFile(t, tc.genesis)
 			_, err := clitestutil.ExecTestCLICmd(client.Context{}, cli.ValidateGenesisCmd(tc.genMM), []string{genesisFile.Name()})