fix(codec): MarshalInterface should err when UnmarshalInterface will fail (#12964)
## Description Closes: #12894 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
This commit is contained in:
@@ -176,3 +176,7 @@ func (f failingInterfaceRegistry) ListAllInterfaces() []string {
|
||||
func (f failingInterfaceRegistry) ListImplementations(ifaceTypeURL string) []string {
|
||||
panic("cannot be called")
|
||||
}
|
||||
|
||||
func (f failingInterfaceRegistry) EnsureRegistered(iface interface{}) error {
|
||||
panic("cannot be called")
|
||||
}
|
||||
|
||||
@@ -0,0 +1,31 @@
|
||||
package client
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestFailingInterfaceRegistry(t *testing.T) {
|
||||
reg := failingInterfaceRegistry{}
|
||||
|
||||
require.Error(t, reg.UnpackAny(nil, nil))
|
||||
_, err := reg.Resolve("")
|
||||
require.Error(t, err)
|
||||
|
||||
require.Panics(t, func() {
|
||||
reg.RegisterInterface("", nil)
|
||||
})
|
||||
require.Panics(t, func() {
|
||||
reg.RegisterImplementations(nil, nil)
|
||||
})
|
||||
require.Panics(t, func() {
|
||||
reg.ListAllInterfaces()
|
||||
})
|
||||
require.Panics(t, func() {
|
||||
reg.ListImplementations("")
|
||||
})
|
||||
require.Panics(t, func() {
|
||||
reg.EnsureRegistered(nil)
|
||||
})
|
||||
}
|
||||
Reference in New Issue
Block a user