feat(schema/appdata)!: make commit async (#21306)
This commit is contained in:
@@ -68,14 +68,14 @@ func StartIndexer(ctx context.Context, logger SqlLogger, config Config) (appdata
|
||||
|
||||
return mm.InitializeSchema(ctx, tx)
|
||||
},
|
||||
Commit: func(data appdata.CommitData) error {
|
||||
Commit: func(data appdata.CommitData) (completionCallback func() error, err error) {
|
||||
err = tx.Commit()
|
||||
if err != nil {
|
||||
return err
|
||||
return nil, err
|
||||
}
|
||||
|
||||
tx, err = db.BeginTx(ctx, nil)
|
||||
return err
|
||||
return nil, err
|
||||
},
|
||||
}, nil
|
||||
}
|
||||
|
||||
@@ -58,7 +58,11 @@ func testInitSchema(t *testing.T, disableRetainDeletions bool, goldenFileName st
|
||||
}))
|
||||
|
||||
require.NotNil(t, listener.Commit)
|
||||
require.NoError(t, listener.Commit(appdata.CommitData{}))
|
||||
cb, err := listener.Commit(appdata.CommitData{})
|
||||
require.NoError(t, err)
|
||||
if cb != nil {
|
||||
require.NoError(t, cb())
|
||||
}
|
||||
|
||||
golden.Assert(t, buf.String(), goldenFileName)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user