From 250c47854359c42d7fedded220dc1309d93ee172 Mon Sep 17 00:00:00 2001 From: bjwswang <30621793+bjwswang@users.noreply.github.com> Date: Thu, 11 May 2023 18:43:48 +0800 Subject: [PATCH] refactor: duplicate message verification at msg server and keeper (#16098) Signed-off-by: bjwswang --- x/gov/keeper/msg_server.go | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/x/gov/keeper/msg_server.go b/x/gov/keeper/msg_server.go index 274c881b82..d37dbb5339 100644 --- a/x/gov/keeper/msg_server.go +++ b/x/gov/keeper/msg_server.go @@ -57,10 +57,6 @@ func (k msgServer) SubmitProposal(goCtx context.Context, msg *v1.MsgSubmitPropos return nil, err } - if err := validateMsgs(proposalMsgs); err != nil { - return nil, err - } - ctx := sdk.UnwrapSDKContext(goCtx) initialDeposit := msg.GetInitialDeposit() @@ -412,19 +408,3 @@ func validateDeposit(deposit sdk.Coins) error { return nil } - -func validateMsgs(msgs []sdk.Msg) error { - for idx, msg := range msgs { - m, ok := msg.(sdk.HasValidateBasic) - if !ok { - continue - } - - if err := m.ValidateBasic(); err != nil { - return errors.Wrap(govtypes.ErrInvalidProposalMsg, - fmt.Sprintf("msg: %d, err: %s", idx, err.Error())) - } - } - - return nil -}